u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>
Subject: [PATCH 07/19] buildman: Drop use of 'board' in board module
Date: Mon, 11 Jul 2022 19:04:01 -0600	[thread overview]
Message-ID: <20220712010413.331984-8-sjg@chromium.org> (raw)
In-Reply-To: <20220712010413.331984-1-sjg@chromium.org>

Use brds instead so that we can reserve 'boards' and 'board' as module
names.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 tools/buildman/board.py | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/tools/buildman/board.py b/tools/buildman/board.py
index 08771b3f158..8de71e487ee 100644
--- a/tools/buildman/board.py
+++ b/tools/buildman/board.py
@@ -116,7 +116,7 @@ class Boards:
     def ReadBoards(self, fname):
         """Read a list of boards from a board file.
 
-        Create a board object for each and add it to our _boards list.
+        Create a Board object for each and add it to our _boards list.
 
         Args:
             fname: Filename of boards.cfg file
@@ -238,21 +238,21 @@ class Boards:
             terms.append(term)
         return terms
 
-    def SelectBoards(self, args, exclude=[], boards=None):
+    def SelectBoards(self, args, exclude=[], brds=None):
         """Mark boards selected based on args
 
         Normally either boards (an explicit list of boards) or args (a list of
         terms to match against) is used. It is possible to specify both, in
         which case they are additive.
 
-        If boards and args are both empty, all boards are selected.
+        If brds and args are both empty, all boards are selected.
 
         Args:
             args: List of strings specifying boards to include, either named,
                   or by their target, architecture, cpu, vendor or soc. If
                   empty, all boards are selected.
             exclude: List of boards to exclude, regardless of 'args'
-            boards: List of boards to build
+            brds: List of boards to build
 
         Returns:
             Tuple
@@ -283,8 +283,8 @@ class Boards:
                         matching_term = str(term)
                         build_it = True
                         break
-            elif boards:
-                if brd.target in boards:
+            elif brds:
+                if brd.target in brds:
                     build_it = True
                     found.append(brd.target)
             else:
@@ -302,8 +302,8 @@ class Boards:
                     result[matching_term].append(brd.target)
                 result['all'].append(brd.target)
 
-        if boards:
-            remaining = set(boards) - set(found)
+        if brds:
+            remaining = set(brds) - set(found)
             if remaining:
                 warnings.append('Boards not found: %s\n' % ', '.join(remaining))
 
-- 
2.37.0.144.g8ac04bfd2-goog


  parent reply	other threads:[~2022-07-12  1:05 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-12  1:03 [PATCH 00/19] buildman: Integration of boards.cfg file Simon Glass
2022-07-12  1:03 ` [PATCH 01/19] buildman: Drop -I option Simon Glass
2022-07-12  1:03 ` [PATCH 02/19] buildman: Support running from an IDE Simon Glass
2022-07-12  1:03 ` [PATCH 03/19] buildman: Avoid using board as a variable Simon Glass
2022-07-12  1:03 ` [PATCH 04/19] buildman: Fix use of 'boards' in func_test Simon Glass
2022-07-12  1:03 ` [PATCH 05/19] buildman: Fix use of 'boards' in test Simon Glass
2022-07-12  1:04 ` [PATCH 06/19] buildman: Drop use of 'boards' in control Simon Glass
2022-07-12  1:04 ` Simon Glass [this message]
2022-07-12  1:04 ` [PATCH 08/19] buildman: Convert camel case in board.py Simon Glass
2022-07-12  1:04 ` [PATCH 09/19] buildman: Split out Boards into its own file Simon Glass
2022-07-12  1:04 ` [PATCH 10/19] buildman: Incorporate the genboardscfg.py tool Simon Glass
2022-07-12 21:38   ` Tom Rini
2022-07-13 15:28     ` Simon Glass
2022-07-13 18:21       ` Tom Rini
2022-07-14 10:21         ` Simon Glass
2022-07-18 12:11           ` Tom Rini
2022-07-20 15:01             ` Simon Glass
2022-07-20 17:15               ` Tom Rini
2022-07-22  8:59                 ` Simon Glass
2022-07-12  1:04 ` [PATCH 11/19] buildman: Tidy up pylint problems in boards module Simon Glass
2022-07-12  1:04 ` [PATCH 12/19] buildman: Replace the Options column with config name Simon Glass
2022-07-12  1:04 ` [PATCH 13/19] Revert "Revert "global: Remove CONFIG_SYS_EXTRA_OPTIONS support"" Simon Glass
2022-07-12 21:38   ` Tom Rini
2022-07-12  1:04 ` [PATCH 14/19] buildman: Return an error if there are maintainer warnings Simon Glass
2022-07-12  1:04 ` [PATCH 15/19] gitlab/azure: Use buildman instead of genboardscfg Simon Glass
2022-07-12 12:06   ` Tom Rini
2022-07-12  1:04 ` [PATCH 16/19] Drop genboardscfg.py Simon Glass
2022-07-12  1:04 ` [PATCH 17/19] buildman: Allow lines without a symbol Simon Glass
2022-07-12  1:04 ` [PATCH 18/19] buildman: Drop a Python 2.7 comment Simon Glass
2022-07-12  1:04 ` [PATCH 19/19] buildman: Drop a TODO that is done Simon Glass
2022-08-05 17:24 ` [PATCH 00/19] buildman: Integration of boards.cfg file Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220712010413.331984-8-sjg@chromium.org \
    --to=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).