u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Xavier Drudis Ferran <xdrudis@tinet.cat>
To: Quentin Schulz <foss+uboot@0leil.net>
Cc: sjg@chromium.org, philipp.tomsich@vrull.eu,
	kever.yang@rock-chips.com, alpernebiyasak@gmail.com,
	email2tema@gmail.com, u-boot@lists.denx.de,
	Quentin Schulz <quentin.schulz@theobroma-systems.com>
Subject: Re: [PATCH 2/2] rockchip: rk3399: sync spl_boot_devices_tbl and boot_devices node paths
Date: Mon, 18 Jul 2022 23:12:21 +0200	[thread overview]
Message-ID: <20220718211221.GJ1686@begut> (raw)
In-Reply-To: <20220715151552.953654-2-foss+uboot@0leil.net>

El Fri, Jul 15, 2022 at 05:15:52PM +0200, Quentin Schulz deia:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> 
> While technically not a bug, let's have some consistency in paths
> returned by u-boot,spl-boot-order look-up and the one saved in
> u-boot,spl-boot-device by syncing spl_boot_devices_tbl and boot_devices
> node paths.
> 
> Cc: Quentin Schulz <foss+uboot@0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> ---


Tested on a Rock-Pi-4B and didn't see any regression.
Tested-by: Xavier Drudis Ferran <xdrudis@tinet.cat>
Reviewed-by: Xavier Drudis Ferran <xdrudis@tinet.cat>


>  arch/arm/mach-rockchip/rk3399/rk3399.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-rockchip/rk3399/rk3399.c b/arch/arm/mach-rockchip/rk3399/rk3399.c
> index f280cb1dbf..7147dc09f5 100644
> --- a/arch/arm/mach-rockchip/rk3399/rk3399.c
> +++ b/arch/arm/mach-rockchip/rk3399/rk3399.c
> @@ -182,7 +182,7 @@ const char *spl_decode_boot_device(u32 boot_device)
>  	} spl_boot_devices_tbl[] = {
>  		{ BOOT_DEVICE_MMC2, "/mmc@fe320000" },
>  		{ BOOT_DEVICE_MMC1, "/mmc@fe330000" },
> -		{ BOOT_DEVICE_SPI, "/spi@ff1d0000" },
> +		{ BOOT_DEVICE_SPI, "/spi@ff1d0000/flash@0" },
>  	};
>  
>  	for (i = 0; i < ARRAY_SIZE(spl_boot_devices_tbl); ++i)
> -- 
> 2.36.1
> 

  reply	other threads:[~2022-07-18 21:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-15 15:15 [PATCH 1/2] rockchip: rk3399: fix incorrect boot-device in u-boot, spl-boot-device Quentin Schulz
2022-07-15 15:15 ` [PATCH 2/2] rockchip: rk3399: sync spl_boot_devices_tbl and boot_devices node paths Quentin Schulz
2022-07-18 21:12   ` Xavier Drudis Ferran [this message]
2022-08-12 10:35     ` Quentin Schulz
2022-08-27  3:59   ` Kever Yang
2022-07-18 21:10 ` [SPAM] [PATCH 1/2] rockchip: rk3399: fix incorrect boot-device in u-boot, spl-boot-device Xavier Drudis Ferran
2022-08-27  3:57 ` [PATCH 1/2] rockchip: rk3399: fix incorrect boot-device in u-boot,spl-boot-device Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220718211221.GJ1686@begut \
    --to=xdrudis@tinet.cat \
    --cc=alpernebiyasak@gmail.com \
    --cc=email2tema@gmail.com \
    --cc=foss+uboot@0leil.net \
    --cc=kever.yang@rock-chips.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=quentin.schulz@theobroma-systems.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).