From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A7CBC43334 for ; Mon, 18 Jul 2022 21:12:30 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4D6CD84014; Mon, 18 Jul 2022 23:12:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=tinet.cat Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 9E3818401F; Mon, 18 Jul 2022 23:12:26 +0200 (CEST) Received: from mx1.tinet.cat (mx1.tinet.cat [195.77.216.146]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7E8988400E for ; Mon, 18 Jul 2022 23:12:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=tinet.cat Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xdrudis@tinet.cat X-ASG-Debug-ID: 1658178742-163e7b70c579b9a0001-4l7tJC Received: from smtp01.tinet.cat (smtp01.tinet.cat [195.77.216.131]) by mx1.tinet.cat with ESMTP id dbML8Pm2EhieUsU3; Mon, 18 Jul 2022 23:12:22 +0200 (CEST) X-Barracuda-Envelope-From: xdrudis@tinet.cat X-Barracuda-Effective-Source-IP: smtp01.tinet.cat[195.77.216.131] X-Barracuda-Apparent-Source-IP: 195.77.216.131 Received: from begut (99.red-79-152-185.dynamicip.rima-tde.net [79.152.185.99]) by smtp01.tinet.cat (Postfix) with ESMTPSA id 85574605D0A1; Mon, 18 Jul 2022 23:12:22 +0200 (CEST) Date: Mon, 18 Jul 2022 23:12:21 +0200 From: Xavier Drudis Ferran To: Quentin Schulz Cc: sjg@chromium.org, philipp.tomsich@vrull.eu, kever.yang@rock-chips.com, alpernebiyasak@gmail.com, email2tema@gmail.com, u-boot@lists.denx.de, Quentin Schulz Subject: Re: [PATCH 2/2] rockchip: rk3399: sync spl_boot_devices_tbl and boot_devices node paths Message-ID: <20220718211221.GJ1686@begut> X-ASG-Orig-Subj: Re: [PATCH 2/2] rockchip: rk3399: sync spl_boot_devices_tbl and boot_devices node paths References: <20220715151552.953654-1-foss+uboot@0leil.net> <20220715151552.953654-2-foss+uboot@0leil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220715151552.953654-2-foss+uboot@0leil.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Barracuda-Connect: smtp01.tinet.cat[195.77.216.131] X-Barracuda-Start-Time: 1658178742 X-Barracuda-URL: https://webmail.tinet.cat:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 1379 X-Barracuda-BRTS-Status: 1 X-Barracuda-Bayes: INNOCENT GLOBAL 0.8712 1.0000 2.9242 X-Barracuda-Spam-Score: 3.42 X-Barracuda-Spam-Status: No, SCORE=3.42 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=6.0 KILL_LEVEL=8.0 tests=BSF_RULE_7582B X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.99471 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE_7582B Custom Rule 7582B X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean El Fri, Jul 15, 2022 at 05:15:52PM +0200, Quentin Schulz deia: > From: Quentin Schulz > > While technically not a bug, let's have some consistency in paths > returned by u-boot,spl-boot-order look-up and the one saved in > u-boot,spl-boot-device by syncing spl_boot_devices_tbl and boot_devices > node paths. > > Cc: Quentin Schulz > Signed-off-by: Quentin Schulz > --- Tested on a Rock-Pi-4B and didn't see any regression. Tested-by: Xavier Drudis Ferran Reviewed-by: Xavier Drudis Ferran > arch/arm/mach-rockchip/rk3399/rk3399.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-rockchip/rk3399/rk3399.c b/arch/arm/mach-rockchip/rk3399/rk3399.c > index f280cb1dbf..7147dc09f5 100644 > --- a/arch/arm/mach-rockchip/rk3399/rk3399.c > +++ b/arch/arm/mach-rockchip/rk3399/rk3399.c > @@ -182,7 +182,7 @@ const char *spl_decode_boot_device(u32 boot_device) > } spl_boot_devices_tbl[] = { > { BOOT_DEVICE_MMC2, "/mmc@fe320000" }, > { BOOT_DEVICE_MMC1, "/mmc@fe330000" }, > - { BOOT_DEVICE_SPI, "/spi@ff1d0000" }, > + { BOOT_DEVICE_SPI, "/spi@ff1d0000/flash@0" }, > }; > > for (i = 0; i < ARRAY_SIZE(spl_boot_devices_tbl); ++i) > -- > 2.36.1 >