From: Quentin Schulz <foss+uboot@0leil.net>
Cc: bharat.gooty@broadcom.com, rayagonda.kokatanur@broadcom.com,
sjg@chromium.org, philipp.tomsich@vrull.eu,
kever.yang@rock-chips.com, jagan@amarulasolutions.com,
alpernebiyasak@gmail.com, andy.yan@rock-chips.com,
hl@rock-chips.com, chenjh@rock-chips.com,
manivannan.sadhasivam@linaro.org, nick@khadas.com,
klaus.goger@theobroma-systems.com, jernej.skrabec@gmail.com,
jbx6244@gmail.com, deepakdas.linux@gmail.com, linux@alxd.me,
mail@david-bauer.net, peterwillcn@gmail.com, heiko@sntech.de,
w.egorov@phytec.de, pbrobinson@gmail.com,
sunil@amarulasolutions.com, ldevulder@suse.com,
akash@openedev.com, banglang.huang@foxmail.com,
matwey.kornilov@gmail.com, michael@amarulasolutions.com,
xypron.glpk@gmx.de, u-boot@lists.denx.de,
Quentin Schulz <quentin.schulz@theobroma-systems.com>,
Quentin Schulz <foss+uboot@0leil.net>
Subject: [PATCH v2 4/7] rockchip: simplify binman image dependencies addition to INPUTS
Date: Fri, 22 Jul 2022 13:35:02 +0200 [thread overview]
Message-ID: <20220722113505.3875669-5-foss+uboot@0leil.net> (raw)
In-Reply-To: <20220722113505.3875669-1-foss+uboot@0leil.net>
From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
By factoring SPL check in the first condition, this makes the checks a
bit less convoluted and more readable.
Cc: Quentin Schulz <foss+uboot@0leil.net>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
---
Makefile | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/Makefile b/Makefile
index 7761a10b11..279aeacee3 100644
--- a/Makefile
+++ b/Makefile
@@ -995,19 +995,14 @@ ifeq ($(CONFIG_MPC85xx)$(CONFIG_OF_SEPARATE),yy)
INPUTS-y += u-boot-with-dtb.bin
endif
-ifeq ($(CONFIG_ARCH_ROCKCHIP),y)
-# On ARM64 this target is produced by binman so we don't need this dep
+ifeq ($(CONFIG_ARCH_ROCKCHIP)$(CONFIG_SPL),yy)
+# Binman image dependencies
ifeq ($(CONFIG_ARM64),y)
-ifeq ($(CONFIG_SPL),y)
INPUTS-y += u-boot.itb
endif
else
-ifeq ($(CONFIG_SPL),y)
-# Generate these inputs for binman which will create the output files
INPUTS-y += u-boot.img
endif
-endif
-endif
INPUTS-$(CONFIG_X86) += u-boot-x86-start16.bin u-boot-x86-reset16.bin \
$(if $(CONFIG_SPL_X86_16BIT_INIT),spl/u-boot-spl.bin) \
--
2.37.1
next prev parent reply other threads:[~2022-07-22 12:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 11:34 [PATCH v2 0/7] migrate u-boot-rockchip.bin to binman and generate an image for SPI Quentin Schulz
2022-07-22 11:34 ` [PATCH v2 1/7] rockchip: generate idbloader.img content for u-boot-rockchip.bin with binman for ARM Quentin Schulz
2022-07-23 12:07 ` Johan Jonker
2022-07-23 18:04 ` Matwey V. Kornilov
2022-07-23 19:49 ` [SPAM] " Xavier Drudis Ferran
2022-07-25 10:25 ` Quentin Schulz
2022-07-25 11:05 ` Xavier Drudis Ferran
2022-07-25 11:56 ` Johan Jonker
2022-07-28 13:26 ` Jagan Teki
2022-07-22 11:35 ` [PATCH v2 2/7] rockchip: generate u-boot-rockchip.bin with binman for ARM64 boards Quentin Schulz
2022-07-22 11:35 ` [PATCH v2 3/7] rockchip: remove unneeded CONFIG_SPL_PAD_TO Quentin Schulz
2022-07-22 11:35 ` Quentin Schulz [this message]
2022-07-22 11:35 ` [PATCH v2 5/7] rockchip: allow to build SPI images even without HAS_ROM option Quentin Schulz
2022-07-22 11:35 ` [PATCH v2 6/7] binman: add support for skipping file concatenation for mkimage Quentin Schulz
2022-07-22 11:35 ` [PATCH v2 7/7] rockchip: add u-boot-rockchip-spi.bin image for booting from SPI-NOR flash Quentin Schulz
2022-07-24 7:46 ` [SPAM] [PATCH v2 0/7] migrate u-boot-rockchip.bin to binman and generate an image for SPI Xavier Drudis Ferran
2022-07-25 10:54 ` Quentin Schulz
2022-07-25 11:20 ` Xavier Drudis Ferran
2022-07-25 16:39 ` Quentin Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220722113505.3875669-5-foss+uboot@0leil.net \
--to=foss+uboot@0leil.net \
--cc=akash@openedev.com \
--cc=alpernebiyasak@gmail.com \
--cc=andy.yan@rock-chips.com \
--cc=banglang.huang@foxmail.com \
--cc=bharat.gooty@broadcom.com \
--cc=chenjh@rock-chips.com \
--cc=deepakdas.linux@gmail.com \
--cc=heiko@sntech.de \
--cc=hl@rock-chips.com \
--cc=jagan@amarulasolutions.com \
--cc=jbx6244@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=kever.yang@rock-chips.com \
--cc=klaus.goger@theobroma-systems.com \
--cc=ldevulder@suse.com \
--cc=linux@alxd.me \
--cc=mail@david-bauer.net \
--cc=manivannan.sadhasivam@linaro.org \
--cc=matwey.kornilov@gmail.com \
--cc=michael@amarulasolutions.com \
--cc=nick@khadas.com \
--cc=pbrobinson@gmail.com \
--cc=peterwillcn@gmail.com \
--cc=philipp.tomsich@vrull.eu \
--cc=quentin.schulz@theobroma-systems.com \
--cc=rayagonda.kokatanur@broadcom.com \
--cc=sjg@chromium.org \
--cc=sunil@amarulasolutions.com \
--cc=u-boot@lists.denx.de \
--cc=w.egorov@phytec.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).