From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 026ACC00140 for ; Mon, 15 Aug 2022 08:06:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 36C1984965; Mon, 15 Aug 2022 10:06:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="O3tlt3Ce"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0BA8C84979; Mon, 15 Aug 2022 10:06:45 +0200 (CEST) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 55BF28493D for ; Mon, 15 Aug 2022 10:06:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E85B7B80C87; Mon, 15 Aug 2022 08:06:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72148C433C1; Mon, 15 Aug 2022 08:06:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660550801; bh=ZWdD4//qy21Fy+UM9otgzHjJebmsEssapMjiu0ARq+c=; h=Date:From:To:Subject:References:In-Reply-To:From; b=O3tlt3Ceekk+gJbrHR6jczJyrdpNDWIBKOTocSABCcsY29yr4yo+gCNXbGTppGlZA ecOVymblGuaSalToVYFlp8hVZi3uWY0VHOHNBZfKZDi72UqAOCn09ZzD0g44SnbPdb QnIe0+HM30X7OzNn/eugGdbo5k9YZYTVI/J3kBZnXsMlXc2DFc06XtDb6fEsB232km v+ObJGBW00gKck1OdP57OC2oZIiuPzLj/iXkUtJVmoRPNngUmAc9QNrOWjml7+njaK lDgvxKtEsrshTzvkU7yIQUUNKUdk1Y6wMfdMaL5LaQExoreZqD/t7pN62fvNWRoDb/ aPcZpZSqJ9Lcg== Received: by pali.im (Postfix) id A1326BE0; Mon, 15 Aug 2022 10:06:38 +0200 (CEST) Date: Mon, 15 Aug 2022 10:06:38 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Scott Wood , u-boot@lists.denx.de, linux-mtd@lists.infradead.org Subject: Re: Have fsl_elbc_nand controllers subpage write support? Message-ID: <20220815080638.p7623xyjf6kccdtc@pali> References: <20220807120027.2zz43afbqtqljhul@pali> <20220807141300.tatzjlsjyhcxgegs@pali> <20220813103637.2qiikhitegxctlak@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220813103637.2qiikhitegxctlak@pali> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Saturday 13 August 2022 12:36:37 Pali Rohár wrote: > Hello! > > On Sunday 07 August 2022 16:13:00 Pali Rohár wrote: > > On Sunday 07 August 2022 14:00:27 Pali Rohár wrote: > > > Hello Scott! > > > > > > In past you disabled nand subpage write support for freescale eLBC and > > > IFC U-Boot nand drivers in following patch: > > > https://lore.kernel.org/u-boot/20121102234432.GA18129@buserror.net/ > > > > > > But in Linux kernel you disabled it only in freescale IFC nand driver: > > > https://lore.kernel.org/linux-mtd/20130410223437.GA26900@home.buserror.net/ > > > > > > letting kernel's freescale eLBC driver to have enabled subpage write > > > support. > > > > > > I would like to ask, has freescale eLBC nand controller support for > > > subpage writes? Or not and it should be disabled also in kernel? > > > > > > Or has somebody else these details? > > > > Now I found following commit http://git.kernel.org/torvalds/c/f034d87def51 > > which seems to be fixing/emulating subpage write support. > > If there is not any objections I would send patch to U-boot eLBC nand > controller driver which would remove that NAND_NO_SUBPAGE_WRITE too. As > those subpage write functions are present also in U-Boot driver. > > Any comments? No objections, so U-Boot patch is here: https://lore.kernel.org/u-boot/20220815080140.4048-1-pali@kernel.org/T/#u > > > The main issue is that U-Boot nand and UBI support for boards with eLBC > > > controllers is compatible with Linux kernel nand and UBI support because > > > these two drivers calculate UBI geometry differently. UBI header offset > > > is calculated from nand subpage size and nand subpage size obviously > > > depends on the fact if subpage write is supported or not. > > > > > > I would like to fix this issue, but I do not know if wrong information > > > is in U-Boot driver or in Linux kernel driver.