From: Tom Rini <trini@konsulko.com>
To: Daniel Golle <daniel@makrotopia.org>
Cc: u-boot@lists.denx.de, Simon Glass <sjg@chromium.org>,
Alexandru Gagniuc <mr.nuke.me@gmail.com>,
Chia-Wei Wang <chiawei_wang@aspeedtech.com>,
Sean Anderson <sean.anderson@seco.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH] image-fit: don't set compression if it can't be read
Date: Fri, 26 Aug 2022 17:11:33 -0400 [thread overview]
Message-ID: <20220826211133.GD7942@bill-the-cat> (raw)
In-Reply-To: <YvoiI9gVKYop4Y/A@makrotopia.org>
[-- Attachment #1: Type: text/plain, Size: 762 bytes --]
On Mon, Aug 15, 2022 at 12:38:27PM +0200, Daniel Golle wrote:
> fit_image_get_comp() should not set value -1 in case it can't read
> the compression node. Instead, leave the value untouched in that case
> as it can be absent and a default value previously defined by the
> caller of fit_image_get_comp() should be used.
>
> As a result the warning message
> WARNING: 'compression' nodes for ramdisks are deprecated, please fix your .its file!
> no longer shows if the compression node is actually absent.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>
This causes most platforms to fail to build with an error such as:
https://source.denx.de/u-boot/u-boot/-/jobs/486959#L140
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-08-26 21:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 10:38 [PATCH] image-fit: don't set compression if it can't be read Daniel Golle
2022-08-15 17:37 ` Simon Glass
2022-08-26 21:11 ` Tom Rini [this message]
2022-08-26 21:27 ` [PATCH v2] " Daniel Golle
2022-08-27 0:21 ` Simon Glass
2022-08-27 3:09 ` [PATCH v3 1/2] bootm: fix typo imape_comp -> image_comp Daniel Golle
2022-08-27 3:09 ` [PATCH v3 2/2] image-fit: don't set compression if it can't be read Daniel Golle
2022-08-27 3:14 ` [PATCH v4 1/2] bootm: fix typo imape_comp -> image_comp Daniel Golle
2022-08-30 2:30 ` Simon Glass
2022-08-30 3:03 ` Daniel Golle
2022-08-30 15:56 ` Simon Glass
2022-08-30 16:54 ` Tom Rini
2022-08-31 23:34 ` Tom Rini
2022-08-27 3:17 ` [PATCH v4 2/2] image-fit: don't set compression if it can't be read Daniel Golle
2022-08-30 2:30 ` Simon Glass
2022-08-31 23:34 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220826211133.GD7942@bill-the-cat \
--to=trini@konsulko.com \
--cc=chiawei_wang@aspeedtech.com \
--cc=daniel@makrotopia.org \
--cc=joel@jms.id.au \
--cc=mr.nuke.me@gmail.com \
--cc=sean.anderson@seco.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).