From: Ovidiu Panait <ovpanait@gmail.com>
To: u-boot@lists.denx.de
Cc: Ovidiu Panait <ovpanait@gmail.com>,
Simon Glass <sjg@chromium.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Dzmitry Sankouski <dsankouski@gmail.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Jason Liu <jason.hui.liu@nxp.com>
Subject: [PATCH v2 3/4] cmd: bdinfo: introduce bdinfo_print_size() helper
Date: Mon, 29 Aug 2022 20:02:04 +0300 [thread overview]
Message-ID: <20220829170205.1274484-3-ovpanait@gmail.com> (raw)
In-Reply-To: <20220829170205.1274484-1-ovpanait@gmail.com>
Add bdinfo_print_size() helper to display size variables (such as cache
sizes) in bdinfo format. The size is printed as "xxx Bytes", "xxx KiB",
"xxx MiB", "xxx GiB", etc as needed;
Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Ovidiu Panait <ovpanait@gmail.com>
---
Changes in v2:
Added "Reviewed-by" tag from Simon.
cmd/bdinfo.c | 7 +++++++
include/init.h | 13 +++++++++++++
2 files changed, 20 insertions(+)
diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c
index 37cd8a57eb..9e23c4dd8f 100644
--- a/cmd/bdinfo.c
+++ b/cmd/bdinfo.c
@@ -16,9 +16,16 @@
#include <vsprintf.h>
#include <asm/cache.h>
#include <asm/global_data.h>
+#include <display_options.h>
DECLARE_GLOBAL_DATA_PTR;
+void bdinfo_print_size(const char *name, uint64_t size)
+{
+ printf("%-12s= ", name);
+ print_size(size, "\n");
+}
+
void bdinfo_print_num_l(const char *name, ulong value)
{
printf("%-12s= 0x%0*lx\n", name, 2 * (int)sizeof(value), value);
diff --git a/include/init.h b/include/init.h
index 7b8f62c121..02bb4ce13e 100644
--- a/include/init.h
+++ b/include/init.h
@@ -343,6 +343,19 @@ void bdinfo_print_num_ll(const char *name, unsigned long long value);
/* Print a clock speed in MHz */
void bdinfo_print_mhz(const char *name, unsigned long hz);
+/**
+ * bdinfo_print_size - print size variables in bdinfo format
+ * @name: string to print before the size
+ * @size: size to print
+ *
+ * Helper function for displaying size variables as properly formatted bdinfo
+ * entries. The size is printed as "xxx Bytes", "xxx KiB", "xxx MiB",
+ * "xxx GiB", etc. as needed;
+ *
+ * For use in arch_print_bdinfo().
+ */
+void bdinfo_print_size(const char *name, uint64_t size);
+
/* Show arch-specific information for the 'bd' command */
void arch_print_bdinfo(void);
--
2.25.1
next prev parent reply other threads:[~2022-08-29 17:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 17:02 [PATCH v2 1/4] microblaze: drop CONFIG_SYS_INIT_RAM_ADDR and CONFIG_SYS_INIT_RAM_SIZE Ovidiu Panait
2022-08-29 17:02 ` [PATCH v2 2/4] cpu: microblaze: add error handling in microblaze_cpu_get_desc() Ovidiu Panait
2022-08-29 17:02 ` Ovidiu Panait [this message]
2022-08-30 1:50 ` [PATCH v2 3/4] cmd: bdinfo: introduce bdinfo_print_size() helper Jason Liu
2022-08-29 17:02 ` [PATCH v2 4/4] microblaze: add arch_print_bdinfo() implementation Ovidiu Panait
2022-08-31 8:21 ` [PATCH v2 1/4] microblaze: drop CONFIG_SYS_INIT_RAM_ADDR and CONFIG_SYS_INIT_RAM_SIZE Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220829170205.1274484-3-ovpanait@gmail.com \
--to=ovpanait@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dsankouski@gmail.com \
--cc=jason.hui.liu@nxp.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).