u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Alexander Dahl <ada@thorsis.com>
To: u-boot@lists.denx.de
Cc: Michal Simek <michal.simek@amd.com>, Simon Glass <sjg@chromium.org>
Subject: [PATCH v2 0/8] Use logging feature instead of FPGA_DEBUG
Date: Wed, 21 Sep 2022 15:22:08 +0200	[thread overview]
Message-ID: <20220921132216.7089-1-ada@thorsis.com> (raw)

Hei hei,

while working on FPGA support for a new device I discovered debug
logging in some FPGA drivers is still done as in the old days.  Bring
that to what I thougt would be the currently preferred approach.

Notes: Adding those Kconfig symbols in patch 4 is just to be able to
build those two old drivers.

All drivers touched were build tested with sandbox64_defconfig and GCC8
on Debian GNU/Linux 10 (buster).

Lines with other possibly questionable output were not touched, only
what seemed to be designated debug output, and only for FPGA drivers
having that ancient FPGA_DEBUG / PRINTF macros, so there's room for
future improvements.

Changelog:

v1 -> v2:

- Rebased on master
- Added patch to introduce new FPGA uclass in front of the other patches
- Use that new uclass as log category
- Slightly reworded cover letter

Greets
Alex

Alexander Dahl (8):
  dm: fpga: Introduce new uclass
  fpga: altera: Use logging feature instead of FPGA_DEBUG
  fpga: cyclon2: Use logging feature instead of FPGA_DEBUG
  fpga: Add missing Kconfig symbols for old FPGA drivers
  fpga: ACEX1K: Use logging feature instead of FPGA_DEBUG
  fpga: spartan2: Use logging feature instead of FPGA_DEBUG
  fpga: spartan3: Use logging feature instead of FPGA_DEBUG
  fpga: virtex2: Use logging feature instead of FPGA_DEBUG

 drivers/fpga/ACEX1K.c   | 22 +++++++++-------------
 drivers/fpga/Kconfig    | 12 ++++++++++++
 drivers/fpga/altera.c   | 13 ++++++-------
 drivers/fpga/cyclon2.c  | 24 ++++++++++--------------
 drivers/fpga/spartan2.c | 34 +++++++++++++++-------------------
 drivers/fpga/spartan3.c | 34 +++++++++++++++-------------------
 drivers/fpga/virtex2.c  | 37 +++++++++++++++----------------------
 include/dm/uclass-id.h  |  1 +
 8 files changed, 83 insertions(+), 94 deletions(-)


base-commit: 12ed6d4911ced1df099a365e0a994b54211b60f3
-- 
2.30.2


             reply	other threads:[~2022-09-21 13:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-21 13:22 Alexander Dahl [this message]
2022-09-21 13:22 ` [PATCH v2 1/8] dm: fpga: Introduce new uclass Alexander Dahl
2022-09-22 10:27   ` Michal Simek
2022-09-22 11:35     ` Simon Glass
2022-09-22 11:45       ` Michal Simek
2022-09-25 14:15         ` Simon Glass
2022-09-26  6:14           ` Alexander Dahl
2022-09-28  1:54             ` Simon Glass
2022-09-21 13:22 ` [PATCH v2 2/8] fpga: altera: Use logging feature instead of FPGA_DEBUG Alexander Dahl
2022-09-21 13:22 ` [PATCH v2 3/8] fpga: cyclon2: " Alexander Dahl
2022-09-21 13:22 ` [PATCH v2 4/8] fpga: Add missing Kconfig symbols for old FPGA drivers Alexander Dahl
2022-09-21 13:22 ` [PATCH v2 5/8] fpga: ACEX1K: Use logging feature instead of FPGA_DEBUG Alexander Dahl
2022-09-21 13:22 ` [PATCH v2 6/8] fpga: spartan2: " Alexander Dahl
2022-09-21 13:22 ` [PATCH v2 7/8] fpga: spartan3: " Alexander Dahl
2022-09-21 13:22 ` [PATCH v2 8/8] fpga: virtex2: " Alexander Dahl
2022-09-22 10:30   ` Michal Simek
2022-09-22 11:26     ` Alexander Dahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220921132216.7089-1-ada@thorsis.com \
    --to=ada@thorsis.com \
    --cc=michal.simek@amd.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).