From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BCE3C433FE for ; Fri, 14 Oct 2022 15:20:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8FCC884AF8; Fri, 14 Oct 2022 17:20:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Vt+HTave"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6FB6C84AF8; Fri, 14 Oct 2022 17:20:36 +0200 (CEST) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7E0DC84E06 for ; Fri, 14 Oct 2022 17:20:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x729.google.com with SMTP id o22so2643599qkl.8 for ; Fri, 14 Oct 2022 08:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vyh0oxwwQVOGYQjCLP520nlOl5dcLi8TY0r8hzandOw=; b=Vt+HTaveqKpY70TbrKxfRqRI4JGKm7FfGXm57RnviEMKk6QEknJM90TXyA4UHBoc69 mIY7pMu3MUW+azJCDzBVMAXsZ6TQtgbfnoximC8RYiwOY8myHyOp03Kdx442IYDRSs+p GlluHKnWMggx9fdaW/soaz3Rg5bazR2oBf+Fs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vyh0oxwwQVOGYQjCLP520nlOl5dcLi8TY0r8hzandOw=; b=SnvGNcyKQ0Nf8X3Uvq025I/vaPmNWlq/BeJV7Bg/XGiOJvRRRSCFuRUqLGCvip8o0X 2x9qBhuMwmAxk1VYSuousuyBHUEfUpuPyZuU+k9p2P3UvEP/1yrX0846wbjbfixGkXWJ yXNom3pm/8Lv+bzjYh+W+4RfB3AmM4LVfzMC/BxdROPUFZL3TBeTayszVXmqUfGDKqNo 5dp1RP/1BYNQTItXmhKkgIBnLXFpFVMVfK8YpuARS2xsDjf1Lc5DpeC5Lxlvedai85KK R6KdQn/mn2XgpA0czJyNUjs1TvujgOqhR3is2jR7YHNqTVtuvzzCwGgn4RvQJbjJFP4F QV/Q== X-Gm-Message-State: ACrzQf0w/wB2G2RLOCPqXxWzcdWSaeSdG9CYG529dDqI01zY3pI/mMRc YbQZCmIknjnSguk2hY6+/JxMZZbaV976+Q== X-Google-Smtp-Source: AMsMyM7Lvjb0ZT7Lc8I4k4hsyRYYFNzdfK0H+ShqWcmJuCTAXmZWHsLgb5zW3ZsjPD8qiAaRIiKh4w== X-Received: by 2002:a05:620a:4081:b0:6ee:80ab:25b6 with SMTP id f1-20020a05620a408100b006ee80ab25b6mr4229396qko.517.1665760832191; Fri, 14 Oct 2022 08:20:32 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-b049-0e25-0576-9c40.res6.spectrum.com. [2603:6081:7b00:6400:b049:e25:576:9c40]) by smtp.gmail.com with ESMTPSA id b14-20020ac84f0e000000b00398426e706fsm2109990qte.65.2022.10.14.08.20.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Oct 2022 08:20:31 -0700 (PDT) Date: Fri, 14 Oct 2022 11:20:29 -0400 From: Tom Rini To: Heinrich Schuchardt Cc: Jan Kiszka , Bin Meng , Christian Melki , Ilias Apalodimas , U-Boot Mailing List , Alexander Graf , Simon Glass Subject: Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model Message-ID: <20221014152029.GT2020586@bill-the-cat> References: <20210925003055.759305-1-sjg@chromium.org> <20210924183029.v2.1.Id572ddf5eb457096b95d30ae2d8675f539367fe8@changeid> <5e4facbe-c78b-c3a6-2fb6-b268e8761d66@gmx.de> <87380b1a-5011-1e75-a02c-2508227e9818@siemens.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Q+W+CH9ft+eKPnpy" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --Q+W+CH9ft+eKPnpy Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 14, 2022 at 05:10:55PM +0200, Heinrich Schuchardt wrote: > On 10/14/22 13:51, Jan Kiszka wrote: > > On 21.10.21 01:34, Heinrich Schuchardt wrote: > > > On 9/25/21 2:30 AM, Simon Glass wrote: > > > > This code should never have been added as it builds a new feature o= n top > > > > of legacy code. This has already been improved with the dependency = on > > > > BLK. > > > >=20 > > > > Add a dependency on DM_ETH also, to avoid needing to deal with this= old > > > > code. > > > >=20 > > > > Boards which want EFI_LOADER should migrate to driver model first. > > > >=20 > > > > Note this patch is included to resolve the following build error: > > > >=20 > > > > lib/efi_loader/efi_runtime.c:680:16: error: =E2=80=98CONFIG_SYS_TEX= T_BASE=E2=80=99 > > > > =C2=A0=C2=A0=C2=A0=C2=A0undeclared (first use in this function); d= id you mean > > > > =C2=A0=C2=A0=C2=A0=C2=A0=E2=80=98CONFIG_SYS_SRAM_BASE=E2=80=99? > > > > =C2=A0=C2=A0 680 |=C2=A0=C2=A0 ulong base =3D CONFIG_SYS_TEXT_BASE; > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~~~~~= ~~~~~~~~~ > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 CONFIG_SYS_= SRAM_BASE > > > >=20 > > > > Signed-off-by: Simon Glass > > >=20 > > > Reviewed-by: Heinrich Schuchardt > > >=20 > >=20 > > How to deal with boards that need CONFIG_NET but do not actually > > implement any driver (yet)? This now broke UEFI for the IOT2050 which > > needs NET for network-related device tree setup (see also [1]) and > > enforces a local hack for us. >=20 > UEFI will not provide network without a DM driver. > The migration period ended 2020.07. >=20 > make iot2050_defconfig set EFI_LOADER=3Dy. > What does not work in UEFI? >=20 > Are you missing a way to call eth_get_dev() to trigger aforementioned > devicetree setup? >=20 > Adding 'net list' to CONFIG_PREBOOT might do the trick. I think, and this is why I suggested NETDEVICES, the issue is that there is no network driver in U-Boot, but we need to have networking support enabled in general, in order to perform device tree fixups for Linux where there is the network driver. --=20 Tom --Q+W+CH9ft+eKPnpy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNJfj0ACgkQFHw5/5Y0 tyyKgAv+IWPfXCrJCihegn/d5jB6/2ZQzgAmIQ6bsmUASdaxk0pxLg65L6ye+4Yx FP+5e5TiCkTFsgNvsbFxjHc0ApI8CWlKRotUlin4KkAl49um1dMbEzlUOV8AW15I beL9Z9WpviUlN7dj/V/CAtUavEPRBa9aKKFu8J/mZTwN/DVGSJNmB4M+w3d/pYlt /0jraVjgEGT56Jx7JC7VM9oKa5FBT9lBnZ5NnAIQvQnWaoGZMafw63ur3ZFOTLpN hLFod1UcLaAMW+mFadIdawKJFZv72B0p6am9HVW2hnIqmzW7r5TLU5Uw7h5BSjgy T9BweCpRp6b2jUOh6hcz9Wsp/qOGOOKfGJtsgyyxYTfUBEuDW4A+rftVdr98dsNk HdO4K7+YGL8Vd2JoTdakmLB7NLgJL2bLE77FdrD8vp5DesOGP/RaIE4a9Miolf8c 7kKFQ0KGdXZYB4rc6i1UPB395Ln1DB9zDGmxiZS0HCDEDI9YIkPPzNIeQjBXOojI jgVaWWqI =SlmG -----END PGP SIGNATURE----- --Q+W+CH9ft+eKPnpy--