From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9846EC4332F for ; Fri, 14 Oct 2022 15:39:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A2DFB84EA5; Fri, 14 Oct 2022 17:39:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="O4uonJI9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 800B584EA8; Fri, 14 Oct 2022 17:39:55 +0200 (CEST) Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A0B1184E06 for ; Fri, 14 Oct 2022 17:39:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf35.google.com with SMTP id o67so3439239qvo.13 for ; Fri, 14 Oct 2022 08:39:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=udiamGAUGMnwpyWvaYLsiQ5pydy5bfMS143fniZt5mU=; b=O4uonJI9KMjDmMy1mA4gf9sc1SveVVxGZZsO9CWIXdGs3j/IQDc7BzpC6NvKeNEgde GfoFNEKKUsNs+T7fPClyoSAQ2nNW88a5yttrRs7N+u1MzuXfHAZnJ+7ro9uaHep2CIMa 4mjx8ydcR8zWJ6mFnoHPM4MMuL+soB9Zb/xY4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=udiamGAUGMnwpyWvaYLsiQ5pydy5bfMS143fniZt5mU=; b=PdrnvJYSU2VJoHQEKH7doeQ02RC+g/Hd9m2iEippkrnttc3npCckCXWbpp6HprJ8KH ehnxThlUC6ttiq5w8Cgz/hXm10L6sKh7k+JbZmJjFWVkswWUHT57ke+KuNJ4CqgzC4oj YtiOohj06UmBynD21jn+WkgFJZSEVrCWvMv72r6ivam4iw24vYnOiqxE2lezvMEJRy6l e8W97TUngeaSUgjQL2eMZ3xb/Kr5tzCyRVHK8OEh6qLiMO+X13p0NG7xnuAqNdbNtmRP 57n9NncO5YhyKy9Svd6nGRQLv/E1r+cbLslP3piXdXOvYskApnfWza2JLejk8rqK7hId 5Drg== X-Gm-Message-State: ACrzQf2fNkuyBK5hVV/tUnmeLFBS15lNhehzbLzt+h8pHTGYW9xbw4/X GXGdFrWyHzFIgcLGLZeENVd08g== X-Google-Smtp-Source: AMsMyM7wnNVBbcLaSUq8H3K3Sgk9QpMxOWVklhUAZ3osrYQNbazFcwUIZhUmqhP4XhJRvwEBehvBeg== X-Received: by 2002:ad4:4ee1:0:b0:4b1:25f6:b9b8 with SMTP id dv1-20020ad44ee1000000b004b125f6b9b8mr4466455qvb.48.1665761991463; Fri, 14 Oct 2022 08:39:51 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-b049-0e25-0576-9c40.res6.spectrum.com. [2603:6081:7b00:6400:b049:e25:576:9c40]) by smtp.gmail.com with ESMTPSA id l11-20020a37f90b000000b006ee2953fac4sm2588474qkj.136.2022.10.14.08.39.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Oct 2022 08:39:50 -0700 (PDT) Date: Fri, 14 Oct 2022 11:39:48 -0400 From: Tom Rini To: Simon Glass Cc: Jan Kiszka , Heinrich Schuchardt , Bin Meng , Christian Melki , Ilias Apalodimas , U-Boot Mailing List , Alexander Graf Subject: Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model Message-ID: <20221014153948.GW2020586@bill-the-cat> References: <20210925003055.759305-1-sjg@chromium.org> <20210924183029.v2.1.Id572ddf5eb457096b95d30ae2d8675f539367fe8@changeid> <5e4facbe-c78b-c3a6-2fb6-b268e8761d66@gmx.de> <87380b1a-5011-1e75-a02c-2508227e9818@siemens.com> <20221014131315.GM2020586@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NILByKcPRZiJ7ENr" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --NILByKcPRZiJ7ENr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 14, 2022 at 09:36:46AM -0600, Simon Glass wrote: > Hi Jan, >=20 > On Fri, 14 Oct 2022 at 09:35, Jan Kiszka wrote: > > > > On 14.10.22 17:33, Simon Glass wrote: > > > Hi Tom, > > > > > > On Fri, 14 Oct 2022 at 07:13, Tom Rini wrote: > > >> > > >> On Fri, Oct 14, 2022 at 01:51:54PM +0200, Jan Kiszka wrote: > > >>> On 21.10.21 01:34, Heinrich Schuchardt wrote: > > >>>> On 9/25/21 2:30 AM, Simon Glass wrote: > > >>>>> This code should never have been added as it builds a new feature= on top > > >>>>> of legacy code. This has already been improved with the dependenc= y on > > >>>>> BLK. > > >>>>> > > >>>>> Add a dependency on DM_ETH also, to avoid needing to deal with th= is old > > >>>>> code. > > >>>>> > > >>>>> Boards which want EFI_LOADER should migrate to driver model first. > > >>>>> > > >>>>> Note this patch is included to resolve the following build error: > > >>>>> > > >>>>> lib/efi_loader/efi_runtime.c:680:16: error: =E2=80=98CONFIG_SYS_T= EXT_BASE=E2=80=99 > > >>>>> undeclared (first use in this function); did you mean > > >>>>> =E2=80=98CONFIG_SYS_SRAM_BASE=E2=80=99? > > >>>>> 680 | ulong base =3D CONFIG_SYS_TEXT_BASE; > > >>>>> | ^~~~~~~~~~~~~~~~~~~~ > > >>>>> | CONFIG_SYS_SRAM_BASE > > >>>>> > > >>>>> Signed-off-by: Simon Glass > > >>>> > > >>>> Reviewed-by: Heinrich Schuchardt > > >>>> > > >>> > > >>> How to deal with boards that need CONFIG_NET but do not actually > > >>> implement any driver (yet)? This now broke UEFI for the IOT2050 whi= ch > > >>> needs NET for network-related device tree setup (see also [1]) and > > >>> enforces a local hack for us. > > >> > > >> Yes, looking at the patch, this should probably use NETDEVICES and n= ot > > >> NET as the test? Would that fix your problem, Jan? > > > > > > But that selects DM_ETH. You can still enable DM_ETH when there are no > > > devices, so I'm not sure what the problem is. Can you post an error? > > > > > > Things should be migrated to DM_ETH by now (end of 2020). > > > > > > > I am enable DM_ETH now at board-level, just to make EFI_LOADER happy, > > but that feels wrong. >=20 > I agree, but I wonder if this might need some code refactoring. > Perhaps EFI_LOADER_NET needs to be created, net functionality can be > disabled? I think we should be able to leverage existing flags already for this and not need a new one. The issue is that CONFIG_NET does not mean "we have network devices" but CONFIG_NETDEVICES does. --=20 Tom --NILByKcPRZiJ7ENr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNJgsQACgkQFHw5/5Y0 tyxt2wv/YyEzH6jlLUf6sIRjT7fgAKeHhWgAlfZmtpsf82YHBY85jvCaqbwwkUKH MdtUiNXrWCoKSsZbUA4Wsz+DvBp8mNDW0aN6QWD/vHpNSKHjzQoDFNpSzN07/b1f Twxj3FfRpRipUaos2zM2/01vOa4R8QcPu6Q3XgQjLap0LrOf+UYB1RZTsoUbecRj JJHnAqK0FoMoabxtr6pzsGs08BbO0ZUMje/WlGuHToosgvF0kbisZm5ihu+uzIIb c1Gf5Dh1MH3amiSHCxyMbK1Um/QLV1R62pq2kiOnfA1NQJs0qaS1fosNjWHgbjAg 8Fk/VAEL/lRz4K300BMfVQV39sP1DmSSvwGiaejz8J0EeSNnT2X5SEYybIuQntau qF0tU2RrEKpegi1yR7qm8rBUz7ZEsk615ekEByE1iXRdOpmISqYVNc39XMv8rDlH BntajBW5qwxGrcs+g17wGx8EvPGt7bvj8+s89NeGRtdbdr5kZ1PbYtIV3oznQVpQ Vq239BqL =/rGH -----END PGP SIGNATURE----- --NILByKcPRZiJ7ENr--