From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15E4DC7619A for ; Mon, 3 Apr 2023 00:06:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 53ACF85CD8; Mon, 3 Apr 2023 02:06:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="mJF/gvaq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 25D0285C52; Mon, 3 Apr 2023 02:06:23 +0200 (CEST) Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A611785ABA for ; Mon, 3 Apr 2023 02:06:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pj1-x1029.google.com with SMTP id qe8-20020a17090b4f8800b0023f07253a2cso28733788pjb.3 for ; Sun, 02 Apr 2023 17:06:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680480378; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=TKYdSdumWhlMJvCBtr+IyWlPhNtyPQ4bx+r5I4UlBcc=; b=mJF/gvaqwVH4FUH8P6qenGunr7qfp8OoI5ezs9AtSE3PJV++f5KwW2obwfTkFFZaVS BetX7FycfvdDA+h53Ns4wV4F4JjqhAWnjKfoUqxIkTembYg9ucrCnpTtSCliHvVtB2nS dcfl59Y7UCTEvmv+B0sFp+2W5QLkv7MI4Dym1AW8IePGpdVQmNKhSaKNr1prjOp6vznc kbrJLN2N6GOax0xnrz2YWhTSxVeMggg1zORlj1hzF3T6nk48t2ofWDIex9PLHArmvuES 0AKBbCPBfOi6zPK1rY4TS8EhIIgLGUuqAZicJSc0VQCZweyYRcDZXOXmryxmgfwCrLMy Y+BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680480378; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TKYdSdumWhlMJvCBtr+IyWlPhNtyPQ4bx+r5I4UlBcc=; b=V3jzHR7DLIqAtkmEtqj99zN93yqpjDXKH5PTYkPiFlm+jdpqAM0XcwIoGpDF5ZK1wq FrgC42IhHY3jb+tPIBOzZPxxbIW7ORz2wYfe06QMP1hlpeLTAT6yfTKApyr6Dz5DlbaB b4SH4muALMGWLwvWH/MVfhmQcDiCPb0Z9BWelkBpBEIOAQ0rU7OMZZ+kcCqeo63/hDvJ O976U0094yk1hjo5tYj7YdIiLevZahWAuOvK6pDt7qCZtSHQAh2vz3apoLMvd3dGlTBe 2XzfTiZO+ryOGTCX9zq7Qvp0XG1qWBSb37Qfp2FNHGdDCODb9CxWJ3mHTFmecc69eflA 5Wxg== X-Gm-Message-State: AAQBX9fFOw4OP5+7KPsj9TAmaS0bQNeVdPwFWZJKtX/ig2gLubkkFkC3 SRdCh7LiVl9O/oyzKV8THlSiLQ== X-Google-Smtp-Source: AKy350YU06QTOwQfZjbOIyr3meGGvCg2eoJkS8xAGkjjIabust521vTvsjc78ytWpKhCJ5gppL4YCQ== X-Received: by 2002:a17:90a:fd81:b0:240:c0df:64fc with SMTP id cx1-20020a17090afd8100b00240c0df64fcmr11871257pjb.2.1680480377695; Sun, 02 Apr 2023 17:06:17 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:1980:b903:d25d:8a2c]) by smtp.gmail.com with ESMTPSA id nl5-20020a17090b384500b00233ccd04a15sm8457173pjb.24.2023.04.02.17.06.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 17:06:17 -0700 (PDT) Date: Mon, 3 Apr 2023 09:06:13 +0900 From: AKASHI Takahiro To: Tom Rini Cc: Simon Glass , U-Boot Mailing List , Ilias Apalodimas , Heinrich Schuchardt Subject: Re: [PATCH v2] disk: Use a helper function to reduce duplication Message-ID: <20230403000613.GA37805@laputa> Mail-Followup-To: AKASHI Takahiro , Tom Rini , Simon Glass , U-Boot Mailing List , Ilias Apalodimas , Heinrich Schuchardt References: <20230319192957.1084530-1-sjg@chromium.org> <20230331141703.GV13222@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fdj2RfSjLxBAspz7" Content-Disposition: inline In-Reply-To: <20230331141703.GV13222@bill-the-cat> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --fdj2RfSjLxBAspz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Tom, On Fri, Mar 31, 2023 at 10:17:03AM -0400, Tom Rini wrote: > On Mon, Mar 20, 2023 at 08:29:57AM +1300, Simon Glass wrote: >=20 > > Reduce the duplicated code slightly by using a helper function to handle > > the common code. > >=20 > > This reduces the code size very slightly. > >=20 > > Signed-off-by: Simon Glass >=20 > Applied to u-boot/next, thanks! I think I said nak against this patch. https://lists.denx.de/pipermail/u-boot/2023-March/512677.html -Takahiro Akashi > --=20 > Tom --fdj2RfSjLxBAspz7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEjc56F+RxEkavfJvIJ6vpGq1myG0FAmQqGG0ACgkQJ6vpGq1m yG20oAf+PPMcpFEFqLLE5IQDfYu40lbJG1eHUOQMibY8Q5fPv5nZPjgZV6Ock1sc Hb4bRZtS357zb4XVXGnJ23N4rH6Jqagu7812vQaO5CR1U3EQHYp2FxWiaJDeV1qU 8U2ALC41K5HtScGHKKqWUJmUp8y6GNzNEqcdhkwOPLV1k83zD9as04rjiPX6pi8B A2W7EG+XL1Uf4ANXicjXjW2/zY7fDDPRG9LNoivaQGClhlC71BpcAfce+bhmFMBh nHIPr62CSenQhSrpHvkzrJH7qcQBp4fxE3cUBCJ1jzDAtXmZgoAgHOdhSLuucC+9 V2Um5jHOfJPXXTgTVgN5XCrU73btWg== =GyUh -----END PGP SIGNATURE----- --fdj2RfSjLxBAspz7--