From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D173FC6FD1D for ; Fri, 7 Apr 2023 14:50:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9C3238611D; Fri, 7 Apr 2023 16:50:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="AGNxKcSG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DAC358611D; Fri, 7 Apr 2023 16:50:21 +0200 (CEST) Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 746A486192 for ; Fri, 7 Apr 2023 16:50:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2b.google.com with SMTP id om8so306575qvb.3 for ; Fri, 07 Apr 2023 07:50:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1680879013; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aQ+OxyIzVdQlMmUVDP4V7gGo6Imc31MPZG8Z0d/TJBM=; b=AGNxKcSGwXB2GZdxJu9YbY8bZx9yiuns3n9kBSP0gE61dNtg0RYHBq5B1nRDW1rUQ3 cmeUNuGh0PTrHjzPXdvWMj62fuA70tZusw5AstXOZOES2ARaQvOR20nUzuzjmlAoTGR+ xs29yaEWDbMayIXxVVEioKoyK7ZNi5HHE3kN0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680879013; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aQ+OxyIzVdQlMmUVDP4V7gGo6Imc31MPZG8Z0d/TJBM=; b=1dkShKN0T1ovHEH/MqOyiMycdsHRikKCyl7WbNke1HHghsEzC3KF480YYUO2AP1FUy lYhpCSgMw7HkPLWl50wT7WvKe0S29A/uWhYy+Hx/MaYgcsPKKUHXwDlVmBs5CK/wlYYZ fLsPVFfSxBKe/uA76kv2RPvAqyriJgKVdpKB11Pb+xnkyKT4XqLWRksBEo/XRXd8hT+6 0ZWgSK0qKCZunroHVRqN4mNvAykTLdn7dPg4VRpNF63jfrV7JmOvZ7V9Eafg4QXVCCoN PNI22+SjzZl0OwETfpp8+ElmVZs/30PFUlKsjVskpASZwL66MKosYtAFri6WYtuOk+MY anbw== X-Gm-Message-State: AAQBX9cSGFLwDr7oZ8XCHo/L8/bpZsBHYAw2V9aqjBRBT7V4khZMfEP1 NG9uJgyQu2/WwhblyTu1XtPbaw== X-Google-Smtp-Source: AKy350aFH8u8W/IPQcS0A+bANJJd9zEZBc4bT6nXgjY0mpKjC5/69LkZb8Spbh76EkqDrhr0IZdNww== X-Received: by 2002:a05:6214:2a82:b0:56b:340c:ee1a with SMTP id jr2-20020a0562142a8200b0056b340cee1amr3535933qvb.49.1680879013061; Fri, 07 Apr 2023 07:50:13 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-4d7a-a40c-ed12-3a35.res6.spectrum.com. [2603:6081:7b00:6400:4d7a:a40c:ed12:3a35]) by smtp.gmail.com with ESMTPSA id lv6-20020a056214578600b005dd8b9345cbsm1395135qvb.99.2023.04.07.07.50.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Apr 2023 07:50:12 -0700 (PDT) Date: Fri, 7 Apr 2023 10:50:11 -0400 From: Tom Rini To: Heinrich Schuchardt Cc: Simon Glass , u-boot@lists.denx.de Subject: Re: [PATCH 1/1] cmd: convert fallthrough comment. Message-ID: <20230407145011.GO1134230@bill-the-cat> References: <20230401071411.110815-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zTt2BxinRT4PcndD" Content-Disposition: inline In-Reply-To: <20230401071411.110815-1-heinrich.schuchardt@canonical.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --zTt2BxinRT4PcndD Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 01, 2023 at 09:14:11AM +0200, Heinrich Schuchardt wrote: > gcc does not understand /* FALL TROUGH */ and emits a warning: >=20 > cmd/date.c: In function =E2=80=98do_date=E2=80=99: > cmd/date.c:62:20: warning: > this statement may fall through [-Wimplicit-fallthrough=3D] > 62 | if (strcmp(argv[1],"reset") =3D=3D 0) { > | ^ > cmd/date.c:102:9: note: here > 102 | case 1: /* get date & time */ > | ^~~~ >=20 > Use the fallthrough macro instead. >=20 > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --zTt2BxinRT4PcndD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQwLaIACgkQFHw5/5Y0 tyz3Mwv/apwtLOdvaRErkMFlWiLPA7crgwSMbdsHZiKJ5lqixeqk7tUQvvX6aViQ Vq3vKpjkMzAzkHIPPPQhJOhy9SRS+ePjguYo958nd7Hqpv7C//8hjADrkCwhmmmp rNJVAHlvOpIq9vwS7GiZhXCOX3yB+/aYLVoC3SVLbS0ZaWdH/56kaR5au5WRUgK5 GktyxTfDa/euOJTbfHZtC8ECL19n9hap0H2fUdz4/2wOXFXvkajdC/QDgHq9M259 5MNhDJ+BJJ6gZ1tCYFNKkdGY/U+m+ZC1WGvOR/kR9BO4+BT5AHqfS6/+AfX4llga 99SiXyB0oufYSoq6FnicBGW6p6xSssceDV++cXg9F0O4sfal6pVpM3VAQbmYvQ72 CxHcZOzKRkmjefzMKw1sEfGGWGDT1Af+a/rcUTZ7K7oeix/0syBuILTlko80Dlaq 76yeEBkj9D8uBCUYEpUJ0dLkHsJaZdHfetm71MpTjF3hUJ3xQAOJxTLTKpWmHT1G KO89sYNi =yvBk -----END PGP SIGNATURE----- --zTt2BxinRT4PcndD--