From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80254EB64D9 for ; Mon, 10 Jul 2023 16:18:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 847FD866BF; Mon, 10 Jul 2023 18:18:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="FHM18NMu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7782F86675; Mon, 10 Jul 2023 18:18:34 +0200 (CEST) Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 18A2F86714 for ; Mon, 10 Jul 2023 18:18:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-577637de4beso61040677b3.0 for ; Mon, 10 Jul 2023 09:18:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1689005910; x=1691597910; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bULYYfnSliRbPTwg6yapUEZvzZk5GLsKL9vgokSaC4Y=; b=FHM18NMu177K6gr8lblfhkk3ORfwnBlSHVf4yMrWBU20u2T6PdWd69QObT4rgDqOI4 mYQdF5JPtCrgsF2CzlLzmda1c8QVa+iawVqYUJDdZhb0eFc9nb3lHF1wh3Atm7oNFKdj 82TyXPRprjf6qw0xYIpJjhbrj2PpZpZiIPpvE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689005910; x=1691597910; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bULYYfnSliRbPTwg6yapUEZvzZk5GLsKL9vgokSaC4Y=; b=lFcO+owol2t/bJNFP/k19fjY15vhvDgeKnsNsa1HU7+s6Pi8OLDK3CAmM3+TvLjfLx UIb4yzDGf/KRghrkFhsrwz/cYW9stx+sjHHhQJnpv8UPtFYXARGXOVGuICcltX6YLh0m 4RE9zstl1NN0YoyZwXDvjBeURxJ7iNccfrAZ5pjX7gY9Vz/d8BDG1xMY4/nBW6O06EFZ Eryoq3FMDW9J88SS+EPgD1TMs0j5dZH9hBV4S0N4jtAyOTmBLxnf1gjbRkykSK/5qSzt OhH0EdBp30AVImfOByG5TMBwR5HstX81nns+0Y4K0lruT/RxUlS+KsYFH6tol9AB36yl iSKQ== X-Gm-Message-State: ABy/qLa39Z7VVk0emZ6otfqAnBXZKcuM5KYpsGYzK7x0NzQUGGoeMznD J6BH16fIgclbiGz5xj/gkyRuxw== X-Google-Smtp-Source: APBJJlH9S3Srn2HobHGsiOLnV3q6cpswqkA4PFxPD/Qjr1o52Rw/PHb8NttACS+tXRFAB44hmUQFqQ== X-Received: by 2002:a0d:d6c2:0:b0:56d:4b45:f9e1 with SMTP id y185-20020a0dd6c2000000b0056d4b45f9e1mr8248084ywd.3.1689005910697; Mon, 10 Jul 2023 09:18:30 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-df98-0e31-df37-537b.res6.spectrum.com. [2603:6081:7b00:6400:df98:e31:df37:537b]) by smtp.gmail.com with ESMTPSA id c23-20020a814e17000000b0057726fce046sm45595ywb.26.2023.07.10.09.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jul 2023 09:18:30 -0700 (PDT) Date: Mon, 10 Jul 2023 12:18:28 -0400 From: Tom Rini To: Abdellatif El Khlifi Cc: Simon Glass , nd@arm.com, u-boot@lists.denx.de Subject: Re: [PATCH v14 11/11] arm_ffa: efi: corstone1000: enable MM communication Message-ID: <20230710161828.GS148062@bill-the-cat> References: <20230707144410.228472-1-abdellatif.elkhlifi@arm.com> <20230707144410.228472-12-abdellatif.elkhlifi@arm.com> <20230707174405.GF148062@bill-the-cat> <20230710150322.GA235402@e130802.arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iPqiAShD7+YrUErH" Content-Disposition: inline In-Reply-To: <20230710150322.GA235402@e130802.arm.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --iPqiAShD7+YrUErH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 10, 2023 at 04:03:22PM +0100, Abdellatif El Khlifi wrote: > Hi Simon, Tom, >=20 > > > > > #include > > > > > > > > > > +#define FFA_SHARED_MM_BUFFER_SIZE SZ_4K /* 4 KB */ > > > > > + > > > > > +/* > > > > > + * shared buffer physical address used for communication between > > > > > + * u-boot and the MM SP > > > > > + */ > > > > > +#define FFA_SHARED_MM_BUFFER_ADDR 0x02000000UL > > > > > +#define FFA_SHARED_MM_BUFFER_OFFSET 0 > > > > > + > > > > > > > > These should be in devicetree properties, shouldn't they? We don't > > > > want things in board config.h files anymore. > > > > > > Wasn't one of the earlier debates on if the whole thing needs to be in > > > device tree, or not, because it's a "discoverable bus" and so Linux > > > wasn't needing one? I don't want to de-rail this series, which I think > > > we're just about otherwise ready to merge, over that debate again. > > > > > > As these values have to match up (I assume) with the other side, are > > > these truly per-board, or SoC dependent? > >=20 > > Yes let's not derail the series...it has gone on too long already. > >=20 > > But we do need to think about this. Addresses in #defines are not a > > great look. It isn't even a CFG. > >=20 >=20 > I think replacing the FFA_SHARED_MM_BUFFER_* defines with > a config makes sense. >=20 > In v15 I'll add these as configs if you think guys it's appropriate: >=20 > FFA_SHARED_MM_BUFFER_SIZE > FFA_SHARED_MM_BUFFER_ADDR > FFA_SHARED_MM_BUFFER_OFFSET Sounds good, thanks! --=20 Tom --iPqiAShD7+YrUErH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmSsL00ACgkQFHw5/5Y0 tywzXgv/ad7dV9TfqkHqlwuPhViSlbVMOXpIPdu4PUH0vQwij/wND/aKW3CQjDlE Xa8680SwpJqguMir7rcj24FrPDqo8kiU/JRemJ0CKEVVJReBXl3UP5oz1Mzen9AC VVgUnk8T+SZd2b6RyNPRNeeIR5DumNpLEi6kW0axxba3Q+CHoTgmWmSA7DyTX845 g3JkvRXFmsHliq9u+IQCi8zVIOnEtUMhHY2zr2Jiaib9u99SlGhHaOxyNSIt34JY Ir8nKLlXPHK226WH/ZVro9ibr5cR1Uviw1gYoj8GZKsBLe8xGsqLu6yJ9PEQP+XM jPWOS3YnmKxaInMR6vIHhaDMpCIvFhdCB4mxdxCLfCVApg65nVpDJdI5mAvN6IQi Gy6WNAYlOWCpTeYDF2EDZSQGuKvUx/T+1hnINEZiLldGSThNCy61lVvLcYqm7L4d C5Sr8D75yRFv1D40hKmVCJyHP+caP5GG8OMQd7Nh6GGRxzlDAk4G9UgGTHSOdm49 Q80jcXcO =S3X4 -----END PGP SIGNATURE----- --iPqiAShD7+YrUErH--