From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F838EB64DD for ; Tue, 25 Jul 2023 18:35:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6BCA986604; Tue, 25 Jul 2023 20:35:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id D853A86768; Tue, 25 Jul 2023 20:34:49 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 7E100866F4 for ; Tue, 25 Jul 2023 20:34:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=abdellatif.elkhlifi@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 086C715BF; Tue, 25 Jul 2023 11:35:29 -0700 (PDT) Received: from e130802.arm.com (unknown [10.57.31.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9D2433F6C4; Tue, 25 Jul 2023 11:34:44 -0700 (PDT) Date: Tue, 25 Jul 2023 19:34:39 +0100 From: Abdellatif El Khlifi To: Tom Rini Cc: nd@arm.com, u-boot@lists.denx.de Subject: Re: [PATCH v15 00/10] introduce Arm FF-A support Message-ID: <20230725183439.GA503876@e130802.arm.com> References: <20230710161828.GS148062@bill-the-cat> <20230713132847.176000-1-abdellatif.elkhlifi@arm.com> <20230724235007.GA3188301@bill-the-cat> <20230725092616.GA100869@e130802.arm.com> <20230725134724.GO3630934@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725134724.GO3630934@bill-the-cat> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Tue, Jul 25, 2023 at 09:47:24AM -0400, Tom Rini wrote: > On Tue, Jul 25, 2023 at 10:26:16AM +0100, Abdellatif El Khlifi wrote: > > Hi Tom, > > > > On Mon, Jul 24, 2023 at 07:50:07PM -0400, Tom Rini wrote: > > > On Thu, Jul 13, 2023 at 02:28:37PM +0100, Abdellatif El Khlifi wrote: > > > > Adding support for Arm FF-A v1.0 (Arm Firmware Framework for Armv8-A) [A]. > > > > > > > > FF-A specifies interfaces that enable a pair of software execution environments aka partitions to > > > > communicate with each other. A partition could be a VM in the Normal or Secure world, an > > > > application in S-EL0, or a Trusted OS in S-EL1. > > > > > > > > FF-A is a discoverable bus and similar to architecture features. > > > > FF-A bus is discovered using ARM_SMCCC_FEATURES mechanism performed > > > > by the PSCI driver. > > > > > > > > ... > > > > > > > > Changelog of changes: > > > > =========================== > > > > > > > > v15: > > > > > > So, this does not pass CI: > > > https://source.denx.de/u-boot/u-boot/-/jobs/662303 > > > https://source.denx.de/u-boot/u-boot/-/jobs/662304#L2234 > > > > > > And it's on me for merging this before letting the CI run I kicked > > > complete, sorry. But I'm reverting this now. > > > > > > > The v15 patchset has been built successfully on next using this SHA: [1]. > > > > The tested platforms are the following: [2]. > > > > Is there any action from my side please ? > > > > [1]: 56c7fac8ad89955d3e5d08864bbd1343a058bf4b > > [2]: tested platforms > > > > sandbox64 > > sandbox > > corstone1000-fvp > > corstone1000-mps3 > > qemu_arm64 > > Yes, you need to go and fix all of the problems that CI is showing: > - On 64bit, espresso7420 is building cmd/armffa.c and pointing out an > unused variable. > - Maybe related to why that platform is building the code, a ton of > 32bit platforms are building the code and showing warnings. And also > that your Kconfig logic is wrong. > - Finally, the MAINTAINERS file needs to be alphabetical. > Thanks for the details. I fixed all the issues and will send them shortly in v16 (a minor change). espresso7420 builds fine and Arm 32-bit boards no longer automatically pick up FF-A. For the alphabetical order in MAINTAINERS, please help me undertand where the issue is. The FF-A part is already in alphabetical order: ARM CORTINA ACCESS CAxxxx ... ARM FF-A M: Abdellatif El Khlifi S: Maintained F: arch/sandbox/include/asm/sandbox_arm_ffa.h F: arch/sandbox/include/asm/sandbox_arm_ffa_priv.h F: cmd/armffa.c F: doc/arch/arm64.ffa.rst F: doc/usage/cmd/armffa.rst F: drivers/firmware/arm-ffa/ F: include/arm_ffa.h F: test/cmd/armffa.c F: test/dm/ffa.c ARM FREESCALE IMX ... Cheers, Abdellatif