From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08C59C04A6A for ; Thu, 27 Jul 2023 13:30:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0E7E68681B; Thu, 27 Jul 2023 15:30:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Sgd6Pj//"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E8031867A8; Thu, 27 Jul 2023 15:30:26 +0200 (CEST) Received: from mail-ua1-x92a.google.com (mail-ua1-x92a.google.com [IPv6:2607:f8b0:4864:20::92a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 26E34867A8 for ; Thu, 27 Jul 2023 15:30:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-ua1-x92a.google.com with SMTP id a1e0cc1a2514c-794cddcab71so445214241.1 for ; Thu, 27 Jul 2023 06:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1690464622; x=1691069422; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=a476fumAzZ5mZvyt0jAEtlqs6OXUyDeDIhO0C5KkxFc=; b=Sgd6Pj//8OmLbmhL95/GKK+Cj4wdR77FHgHh6QE682We8GX8h/fFI7L/mMgg4SiJZN ufNBpyr4hEfm8kCUM0sloVy2z7cYVpH0Ccb6x8pAvjHcS6Z1yMCNF3INl4v2a6Y/PMkC 2aHNasScfHUsrFdVuCkvCL67ejURah5JX2gM0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690464622; x=1691069422; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=a476fumAzZ5mZvyt0jAEtlqs6OXUyDeDIhO0C5KkxFc=; b=HnQPxCPFhVio72R7O6DzeYF67LNlDARKkz4+ync19puMN1TDfs/p3KTOGMvuPoMWZv tY3SNcQVvOpTnd6qiyQc4HpFOxA9PVDKjFz8jnjjt301fHRBAL4W0xxRz5KF6cGBoZGa lM8fEFO7DJ98ImYA0+N8lFDgqGFUnhgZGXlmOGZI1imau0cA7ifthP1BEBfnoPW3yWMh fgpYBBB/QRHnCwRuQ2rHZoaUzSmClmaGOktCzRZFe8cVRDMuRG3Afxt9w2TSr1u0m/Hu ILcoS7RHmzToRh2L2wJDKlu3+QY1jHAbnptLVbAypv7ow5udT5WXXtYTgIgY0QN92vnZ sQ4w== X-Gm-Message-State: ABy/qLY4EHF6ieMV1grJH7UPoeUzW3xH1ZUOR+fTOymSqFgIsrl3rQAb EoVzsyajTXI9VACMI4hQiTbVZA== X-Google-Smtp-Source: APBJJlF6K2A/cRNwgW4pZZIm5ldOuBLtC+ipBdl3xT6pK2cWej7BocQUnQLnd4mCFTRjBFaIFAWtxw== X-Received: by 2002:a67:f901:0:b0:445:1977:be45 with SMTP id t1-20020a67f901000000b004451977be45mr1276238vsq.33.1690464621733; Thu, 27 Jul 2023 06:30:21 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-96a7-b348-5b90-69b9.res6.spectrum.com. [2603:6081:7b00:6400:96a7:b348:5b90:69b9]) by smtp.gmail.com with ESMTPSA id b6-20020a67d386000000b0043ad7a271a4sm210303vsj.17.2023.07.27.06.30.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 06:30:21 -0700 (PDT) Date: Thu, 27 Jul 2023 09:30:17 -0400 From: Tom Rini To: Abdellatif El Khlifi Cc: gowtham.sureshkumar@arm.com, ilias.apalodimas@linaro.org, jens.wiklander@linaro.org, meenakshi.aggarwal@nxp.com, nd@arm.com, priyanka.jain@nxp.com, sjg@chromium.org, u-boot@lists.denx.de, wasim.khan@nxp.com Subject: Re: [PATCH v16 09/10] arm_ffa: efi: introduce FF-A MM communication Message-ID: <20230727133017.GC3630934@bill-the-cat> References: <20230725185246.GE3630934@bill-the-cat> <20230726094503.100497-1-abdellatif.elkhlifi@arm.com> <20230726094503.100497-10-abdellatif.elkhlifi@arm.com> <20230726193912.GX3630934@bill-the-cat> <20230727093450.GA56607@e130802.arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ck8NPFu3NvKPj8KU" Content-Disposition: inline In-Reply-To: <20230727093450.GA56607@e130802.arm.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --ck8NPFu3NvKPj8KU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 27, 2023 at 10:34:50AM +0100, Abdellatif El Khlifi wrote: > Hi Tom, >=20 > On Wed, Jul 26, 2023 at 03:39:12PM -0400, Tom Rini wrote: > > On Wed, Jul 26, 2023 at 10:45:02AM +0100, Abdellatif El Khlifi wrote: > >=20 > > > Add MM communication support using FF-A transport > > >=20 > > > This feature allows accessing MM partitions services through > > > EFI MM communication protocol. MM partitions such as StandAlonneMM > > > or smm-gateway secure partitions which reside in secure world. > > >=20 > > > An MM shared buffer and a door bell event are used to exchange > > > the data. > > >=20 > > > The data is used by EFI services such as GetVariable()/SetVariable() > > > and copied from the communication buffer to the MM shared buffer. > > >=20 > > > The secure partition is notified about availability of data in the > > > MM shared buffer by an FF-A message (door bell). > > >=20 > > > On such event, MM SP can read the data and updates the MM shared > > > buffer with the response data. > > >=20 > > > The response data is copied back to the communication buffer and > > > consumed by the EFI subsystem. > > >=20 > > > MM communication protocol supports FF-A 64-bit direct messaging. > > >=20 > > > Signed-off-by: Abdellatif El Khlifi > > > Tested-by: Gowtham Suresh Kumar > > > Reviewed-by: Simon Glass > > > Cc: Tom Rini > > > Cc: Ilias Apalodimas > > > Cc: Jens Wiklander > >=20 > > So, at this point in the series we impact lx2160ardb_tfa_stmm which is > > the only config in the tree prior to this series that sets > > CONFIG_EFI_MM_COMM_TEE. I'm not going to block this series[1] on > > updating lx2160ardb_tfa_stmm as well, but I do want to make sure the > > maintainers there are aware and can update the config to support the > > current state of this technology. > >=20 > > [1]: https://patchwork.ozlabs.org/project/uboot/list/?series=3D365876&s= tate=3D* > > --=20 >=20 > Following a decision made with Ilias, the new MM comms design works as fo= llows: >=20 > - Try to communicate using FF-A bus first > - If that fails, try to communicate using Optee. So, platforms that don't= support FF-A > in the Secure side can still use Optee communication >=20 > This is done through the code below [1]. >=20 > This logic needs CONFIG_ARM_FFA_TRANSPORT=3Dy in the defconfig. >=20 > I added CONFIG_ARM_FFA_TRANSPORT=3Dy to lx2160ardb_tfa_stmm_defconfig, CO= NFIG_EFI_MM_COMM_TEE is enabled and it builds fine. >=20 > Is it expected that lx2160ardb_tfa_stmm maintainers add CONFIG_ARM_FFA_TR= ANSPORT=3Dy to lx2160ardb_tfa_stmm_defconfig ? Ah, it sounds like the Kconfig logic this patch adds is wrong then. Is there a use case for ARM_FFA_TRANSPORT without CONFIG_EFI_MM_COMM_TEE=3Dy ? If yes, then it's just that the FF-A related symbols for EFI_MM_COMM_TEE need to depend on ARM_FFA_TRANSPORT. If no, ARM_FFA_TRANSPORT needs to depend on EFI_MM_COMM_TEE (and these new symbols depend on ARM_FFA_TRANSPORT). --=20 Tom --ck8NPFu3NvKPj8KU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmTCcWIACgkQFHw5/5Y0 tyzcCgv/bSDRr7JMpFrqw5kWdLuz0E56WMB30t0CsLP8/XAGPl3MA1vlQa+d8nnI fb0sNIQw/FqGNxvE1liMcFcTIhoTSzMJpSPL9bxaCs0fXRG8COKLG3ya60aqZ4tA BAsUG9an4irTknd8cgpmH+grwOk4Eiay5p1Oie9baurXfJhOCe59hOGuAg/zHlKP NKlxAZWKNkRCL0ED6nPsthgOkW89scvaC612g/xswza8ZGOhzxjpd8kHY8B5FjHF EfcHL2GZ5JHAEOqMJAhX8PT4ov/JVSensiAdC0kbPXqRIaTKpK7mpqFAEyDc3Jzx Mux1pZiSUURVs6O/Lk4oNU96NnqH9erQ6WIPqUf4/tkeUaGdh1Gv9W7bEMDXhZfr WxrrtgoppE6RKHnQobJPaaf5ok1mJetcS22tzibjgcS1q3GGsFpeCy2pLX5VW5eF kcq2VFDtSOmcgd4M/HzLBIvJMDO2yP1/8lbv/C0ZgoTha+n6Rt0AD/XZOMQBvxq9 ayQHCEX9 =dxZ6 -----END PGP SIGNATURE----- --ck8NPFu3NvKPj8KU--