From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B7C2C001DC for ; Thu, 27 Jul 2023 16:43:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9C9FD86849; Thu, 27 Jul 2023 18:43:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="dq3a4fD/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 01FB586863; Thu, 27 Jul 2023 18:43:53 +0200 (CEST) Received: from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com [IPv6:2607:f8b0:4864:20::92b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9153786839 for ; Thu, 27 Jul 2023 18:43:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-ua1-x92b.google.com with SMTP id a1e0cc1a2514c-78f36f37e36so468167241.3 for ; Thu, 27 Jul 2023 09:43:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1690476228; x=1691081028; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+rUSZEi1F9HGwkjxQlClNSmaldb1Mzjpm/2d/DM0rSo=; b=dq3a4fD/6DmRB2ZpI6iz3UElJgf7cvEa2SrFqxJV5gheODWKF+dYT8/BFt97OBWJkY /m3v/5pdyo++XlbsiUsQSIh3jE5W5c5eXzHUu/tRYN0B5LfaL983R94IF02prOcF5c5p 3vCJdiv5iDlE6nmg+/UaS607CK6oNcZ5b+Wys= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690476228; x=1691081028; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+rUSZEi1F9HGwkjxQlClNSmaldb1Mzjpm/2d/DM0rSo=; b=jASEUq+oflsR/71jbSvgczgnIAlEMwlDzR9X9shEGgge9/77B8oLq7otG3ipbbRjeE 371WPTog2RLAI97BJoNyKOiS2NFM/iU08aRHm54Lt2CO6QLPw9AyLI0GyY329zQvLX4e A4qQ3dr1CsJVoJX7p5yU+U4pTfSNWmQWqyrOfCmAyFdex4I3cSeiBkTj6yeR2B/7L7Bs sjk40K1raiediHPiA4yIQMcGz7gGvlDM1W3n3rLPi8Ei70hEh8uoOWYVc4DecWaOolbQ nruN3tMshutMn7WxLQKq7vRDqd/hfsY0M7fyHS0UQCZrYtuucGRYYNSI8/EjrAxDChhn Ubjw== X-Gm-Message-State: ABy/qLbEinRVenVCKHW8oXdHgBeheh9FvFGpPmDNkuwp1jpkPrAYBfpf m3zQVvlsj7d67EzLbO2jOuA1lg== X-Google-Smtp-Source: APBJJlGL/X/JiSEySY2vJ7iq1kxAvGy+ged5wDcgXms3oICrVHpJ8qVP/LxJ4W5uG+lLNMzK2rMfrg== X-Received: by 2002:a1f:5c8a:0:b0:481:3f5d:2667 with SMTP id q132-20020a1f5c8a000000b004813f5d2667mr38969vkb.15.1690476228030; Thu, 27 Jul 2023 09:43:48 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-96a7-b348-5b90-69b9.res6.spectrum.com. [2603:6081:7b00:6400:96a7:b348:5b90:69b9]) by smtp.gmail.com with ESMTPSA id c8-20020ac5c768000000b004814b85ca67sm258677vkn.24.2023.07.27.09.43.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 09:43:47 -0700 (PDT) Date: Thu, 27 Jul 2023 12:43:45 -0400 From: Tom Rini To: Abdellatif El Khlifi Cc: ilias.apalodimas@linaro.org, jens.wiklander@linaro.org, nd@arm.com, sjg@chromium.org, u-boot@lists.denx.de, Gowtham Suresh Kumar Subject: Re: [PATCH v17 09/10] arm_ffa: efi: introduce FF-A MM communication Message-ID: <20230727164345.GH3630934@bill-the-cat> References: <20230726160635.GS3630934@bill-the-cat> <20230727160712.81477-1-abdellatif.elkhlifi@arm.com> <20230727160712.81477-10-abdellatif.elkhlifi@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EUsT5iVkHTmvQuqc" Content-Disposition: inline In-Reply-To: <20230727160712.81477-10-abdellatif.elkhlifi@arm.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --EUsT5iVkHTmvQuqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 27, 2023 at 05:07:11PM +0100, Abdellatif El Khlifi wrote: > Add MM communication support using FF-A transport >=20 > This feature allows accessing MM partitions services through > EFI MM communication protocol. MM partitions such as StandAlonneMM > or smm-gateway secure partitions which reside in secure world. >=20 > An MM shared buffer and a door bell event are used to exchange > the data. >=20 > The data is used by EFI services such as GetVariable()/SetVariable() > and copied from the communication buffer to the MM shared buffer. >=20 > The secure partition is notified about availability of data in the > MM shared buffer by an FF-A message (door bell). >=20 > On such event, MM SP can read the data and updates the MM shared > buffer with the response data. >=20 > The response data is copied back to the communication buffer and > consumed by the EFI subsystem. >=20 > MM communication protocol supports FF-A 64-bit direct messaging. >=20 > Signed-off-by: Abdellatif El Khlifi > Tested-by: Gowtham Suresh Kumar > Reviewed-by: Simon Glass > Cc: Tom Rini > Cc: Ilias Apalodimas > Cc: Jens Wiklander >=20 > --- >=20 > Changelog: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > v17: >=20 > * show a debug message rather than an error when FF-A is not detected [snip] > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig > index c5835e6ef6..8fbadb9201 100644 > --- a/lib/efi_loader/Kconfig > +++ b/lib/efi_loader/Kconfig > @@ -55,13 +55,53 @@ config EFI_VARIABLE_FILE_STORE > stored as file /ubootefi.var on the EFI system partition. > =20 > config EFI_MM_COMM_TEE > - bool "UEFI variables storage service via OP-TEE" > - depends on OPTEE > + bool "UEFI variables storage service via the trusted world" > + depends on OPTEE && ARM_FFA_TRANSPORT You didn't get my changes in here however. If you can do EFI_MM_COMM_TEE without ARM_FFA_TRANSPORT (as lx2160ardb_tfa_stmm_defconfig does) then you don't make this option depend on EFI_MM_COMM_TEE. If FF-A is only for use here, you make FF-A depend on this, and the FF-A specific variable depend on ARM_FFA_TRANSPORT. --=20 Tom --EUsT5iVkHTmvQuqc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmTCnr4ACgkQFHw5/5Y0 tyy7AQv+NTaxwHY5b8m9vvu/zvg1iA5qqQaKFl+rhVmHrYFMYjbCHA6t64oI1IEN ZlR8dkJ0Y6tioGfmvPI4qsCcQidZ7pu3KPg0KOxxSa+2GjWEndovZZZJdy30iXbr J+pgkXB94/1SenoIHF1GFUZ02KHTnlsHRVyu5O5gKGxREL9r8T6bqQTRpXNV4z3S /g1f1BE/wkXA2I5CY4/PbBBEM0i3LY4wJg13K6VsCQ0wtMltwO6X/rpRmE6WWrJC kxdXlwdiFacqYNdEKqa24IAH1E+zzw+1C2CJcFzJrYIqv3hrAb0f8sA5fFnn3ihh TRZIifXIe8m3hTNyThOnF29BPs1p2kvuAQR6iITkcBC1wsNCVVyNnM9Iz6GI6Vwn 1/jMknlv6E9y0uhDEQG4OTmFFJ/6o1IwPXA4LTxoE/FQURaTrgul5Jy7wxm0Zyv7 G0XD56yIErOogsQNqVcQgo7o1x2Kwrz00JkKRmQBkPwoGyF/DRYldB35wzI1KpP6 wvZkLc1l =gRj6 -----END PGP SIGNATURE----- --EUsT5iVkHTmvQuqc--