Re: [PATCH v4 0/6] rpi5: initial support

From: Tom Rini <trini@konsulko.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: "Ivan T. Ivanov" <iivanov@suse.de>,
	wahrenst@gmx.net, mail@jens-maus.de, u-boot@lists.denx.de
Subject: Re: [PATCH v4 0/6] rpi5: initial support
Date: Mon, 22 Jan 2024 13:01:22 -0500	[thread overview]
Message-ID: <20240122180122.GP3652023@bill-the-cat> (raw)
In-Reply-To: <87frypsaon.fsf@bloch.sibelius.xs4all.nl>

[-- Attachment #1: Type: text/plain, Size: 2404 bytes --]

On Mon, Jan 22, 2024 at 03:30:00PM +0100, Mark Kettenis wrote:
> > Date: Mon, 22 Jan 2024 16:16:34 +0200
> > From: "Ivan T. Ivanov" <iivanov@suse.de>
> > 
> > Hi,
> > 
> > On 01-22 13:57, Ivan T. Ivanov wrote:
> > > > Am 20.01.24 um 10:48 schrieb Jens Maus:
> > > >> Hi,
> > > >> 
> > > >>> Am 20.01.2024 um 10:22 schrieb Stefan Wahren <wahrenst@gmx.net>:
> > > >>> 
> > > >>> Am 19.01.24 um 22:26 schrieb Jens Maus:
> > > >>>> I actually do have some good and bad news:
> > > >>>> 
> > > >>>> 1. Good news: I got u-boot finally showing up with my RaspberryPi5 8GB both on the HDMI and on the serial debug UART like you reported.
> > > >>>> 
> > > >>>> 2. Bad news: I actually got it working by downgrading the rpi-eeprom to the same 2023/10/30 (VERSION:30de0ba5) version like you have.
> > > >>>> 
> > > > 
> > > > One idea would be to enable early debug in U-Boot (no idea how to
> > > > achieve this). I assume U-Boot crashes before it's able to print the
> > > > first line, but it's hard to believe it crashes at the very first
> > > > instruction of U-Boot. So with some luck we should be able to narrow
> > > > done the cause.
> > > 
> > > I was able to enable early debug UART in U-Boot and I will try to
> > > find what is happening, once I get some free cycles.
> > 
> > Ok, this was relatively easy to find :-)
> > 
> > New versions of EEPROM firmware change “kernel”/U-Boot load address 
> > from 0x80000 to 0x200000. And because on RPi’s CONFIG_TEXT_BASE is
> > hardcoded to 0x80000 code run through the fields. 
> > 
> > Hopefully simple patch like bellow make it work fine in older and
> > newer EEPROM firmware versions.
> > 
> > Regards,
> > Ivan  
> > 
> > diff --git a/configs/rpi_arm64_defconfig b/configs/rpi_arm64_defconfig
> > index 11ede9435d..ce64f9554f 100644
> > --- a/configs/rpi_arm64_defconfig
> > +++ b/configs/rpi_arm64_defconfig
> > @@ -1,6 +1,7 @@
> >  CONFIG_ARM=y
> >  CONFIG_ARCH_BCM283X=y
> >  CONFIG_TEXT_BASE=0x00080000
> > +CONFIG_POSITION_INDEPENDENT=y
> 
> Not sure if it really matters, but for the Apple M1 config I set
> CONFIG_TEXT_BASE to 0x00000000 (zero).

It shouldn't matter. 0x0 is the default for TEXT_BASE in this case, but
also a number of platforms set it to something else seemingly valid,
but could I suspect still drop the setting as it should not matter at
run time.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]