From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01826C32771 for ; Mon, 26 Sep 2022 13:21:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3E82F84CEA; Mon, 26 Sep 2022 15:21:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="VXKBmZPW"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F004A84DDA; Mon, 26 Sep 2022 15:21:37 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C4E2284C90 for ; Mon, 26 Sep 2022 15:21:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1664198494; bh=1lfjIl3JsyWGbN1e1V39ZUKN9AbwhKI+GYEwBoB1ycY=; h=X-UI-Sender-Class:Date:Subject:To:References:Cc:From:In-Reply-To; b=VXKBmZPWElMPohwKorQhmj/+qSAoE78HRxYFBYghlTgr/qtG5u318FvIRxPvZoLpz XG90/ItY2bdvYSVsui3HwDe9RD2q/Jl8YjPMDvkpfLNEVEgsyGWj1FhTy2Kz3h6sOa 91ifLLfTr8m29zdLtkgnngRKQZCFmhHJILuFYJGU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.67] ([84.118.157.2]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MTRQq-1oowaY0zhE-00Tmsx; Mon, 26 Sep 2022 15:21:34 +0200 Message-ID: <21c36190-4684-d154-a439-cfabe4264097@gmx.de> Date: Mon, 26 Sep 2022 15:21:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v3 3/3] am335x_evm_defconfig: Enable Micron SPI flash support Content-Language: en-US To: Paul Barker References: <20220921160628.4166966-1-paul.barker@sancloud.com> <20220921160628.4166966-4-paul.barker@sancloud.com> Cc: u-boot@lists.denx.de, Tom Rini , Ilias Apalodimas From: Heinrich Schuchardt In-Reply-To: <20220921160628.4166966-4-paul.barker@sancloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:MmpeyZiA8hpMC1Gon7zS6GvxzRtNNUVi4Awx0hNQ7U4R/aTd3bo LJrjMFgv2+RkMYymShK6trXfHpGAx7NMaVf8qxfJJAAj4ttcbOGfV81299Pqtr2C/+ljQ2y voDd2QLqT4GWoYpBYEHUYJCz6Fw/PXavHMzp5CsiDa8176kUwVGnyoAbhMS9BUCzreF6RpW 8rB4IstL4wuGhOxY/iagA== X-UI-Out-Filterresults: notjunk:1;V03:K0:c1LXxKDOY6A=:zKReu2rTHymLHJmepA937p mTdVmeFteaKAmuwrDWUUDGWujLRLbJ8iNkFcYqM9LKT2boNCKG7TGF9GawVfDmo2LoocSNFyj t1108yErcarD76dRwcsm5sThnuhCflyu89QCBjZqlw8AUQY4fHPXB0Ks5md8B+GzNdXshzs9f /W/qypwNymNpj2gHIGqyYm+G6WiENjCqqxYk/0B1KSHBD/zoIPICw1/J13rd8/xgI1/8xkfqC ryVvdRNIi2yWT8YX0big+od1ELnCpImZKojjg8d2COwkdXMK1Kq7EoKQD2kcE4eVkJ9tlKLYh 2EkQjqV1CGe7oCtJYuO1+ir8eNXDx5w+tkRA7yyUzQ3Oe/8oTg1YpUR41fcTOfz4f2sGvK0YJ kYqoz02tlWgGQ2TnhcNVEOnAij9RJB6ykms9IbNSOCrTnQq1Zc+FPQ5wJd/RlZXzg3HXUexve rVXDgU7A7Kh/3HuOx1Oduanh9/KS6Nmmdbbl9pXWxg1Xnd2AkLec8Eor9AgJnuKvG4zc9IF7P oUJQCnMm0MHKb6/+9ewi8ehlGEOZ0lBF0fPx8p+4DleKC21nESUGcY5X7FZzJGCgYCiKQyMLw doSz/H/ywEkA6qgCxXReHxszxbeQYvkkQ/bsW9HqfW3aww4x7xCvrv9s0CnfDdIpVfPZUs4B6 flIOGx/Jc2zUcJvaaontlxBgaT03qJDauXC5t+1FP638PE1r2dqpr5P4nkA/Qa94JI+MG+qIp ugXBbt3610fuzCa3KNP7ei4/P/ndm3ocrc6AHQEZemyXiIZKJ2UTBKlI0iGJn2x6P900DFO2c tFKtM5IoMO5NPY9m3teOiDhejDDwrLoL7sSN1gLOgkAqou8N2aD52XOmDknoN/XyJuubnuPuA xJf/iVtHhGEFOEdpqmaDouXSfYVZ0dVg9DjTkFxREXbKZxdSTMSKH3jX6GpxWuel45lJsFMkQ 1fXtDzVSr4dvCNKe5oeZP7Vag6VzjphOfqvnHx9vfAFsbmD5zA4yB5xgDG8n1/+hG0quUx+fF it5pMOvbFE+jO+1ot2b5/2mlj6li5m/lptL5SvuWEPfiicmKx7BVn9MhGzVcy49FcIVvrMwC2 5YQ+oTS46Eb7uoeBWR34xr9VtYre+oJjD/hQswzOiEPRlbMAQtjA6+SX4niVsXo8NTIraGAYf dJi2jU0Z+ovvfwpiTLt+agSSsN X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 9/21/22 18:06, Paul Barker wrote: > Signed-off-by: Paul Barker > --- > configs/am335x_evm_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/am335x_evm_defconfig b/configs/am335x_evm_defconfig > index f0fbe475b394..f73123e0b71d 100644 > --- a/configs/am335x_evm_defconfig > +++ b/configs/am335x_evm_defconfig > @@ -92,6 +92,7 @@ CONFIG_SYS_NAND_U_BOOT_LOCATIONS=3Dy > CONFIG_SYS_NAND_U_BOOT_OFFS=3D0xc0000 > CONFIG_DM_SPI_FLASH=3Dy > CONFIG_SF_DEFAULT_SPEED=3D24000000 > +CONFIG_SPI_FLASH_STMICRO=3Dy You don't enable CONFIG_EFI_SPI_PROTOCOL anywhere; not even on the sandbox. So the code is never compiled and never tested. This cannot be correct. Best regards Heinrich > CONFIG_SPI_FLASH_WINBOND=3Dy > CONFIG_PHY_ATHEROS=3Dy > CONFIG_PHY_SMSC=3Dy