From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 143D9C432BE for ; Tue, 10 Aug 2021 10:04:29 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B028960232 for ; Tue, 10 Aug 2021 10:04:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B028960232 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6967A8296A; Tue, 10 Aug 2021 12:04:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1628589865; bh=irEC5r8ycjn7jBylStgQlphLm3nQ7RnrfwcRHXPaavY=; h=Subject:From:To:Cc:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=tSKSKaYNMkta9r6LWA0yQv2IrL0qfXbp8hgF/IqA82UfiXKCg7FB1T/pVaXFDomy+ 4jiVj4p44+RmSsy7/6sPQ40/YwwAU+sEMALKHFcTqk+vxAsZw0NrRq+NtLPSto5t6j ISaGd2iATfiBTJenzvCXoMpUc9FQ9FStZR21yZ5ejB29lQFma3NeP1vhyDpubmwOpJ ErCzRvbkUOsLTEsik6VJff8X3yp4eyV7ZY4c7JkG8sO/2goWQNtFrhlivu1YGx7qqo LN/rZNUnQG73gSZetfi//wftaWbqoSS85F85ZNEJ0aAQ6G18wGb1Ws6jxBZahnVor1 Na92RbCnHpx2Q== Received: from maia.denx.de (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: hws@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id E766580F2E; Tue, 10 Aug 2021 12:04:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1628589864; bh=irEC5r8ycjn7jBylStgQlphLm3nQ7RnrfwcRHXPaavY=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=ebaHXnRxbzHtEsNgaxh8xIanvyYPsl6/KnmRsautBe2TUOA1xk/0SLr2o3NMYUt3K 7ocDGUJ0jkXQksseh6rcPExoTNJNDLJZVKpoI3NiRKNExUSxTukSM+bEoHu5zX5u+f a3M4ifRtKtrn/1k39AwonIo77vRBslQEKu7HPSDb6MeS48BiEMk2wXCqTf1ZMFWHNf +M2JsEf2+CGtPTkX9vQQUTVtIirsbfimJ7P0YZzNBliGS++JLbFEOmvmm4+kb3Rzsk yN5hgA332wsZc5vv4kxwIVGviEWzUafgGayMNZzIjgGPQhawb+7aGf/tK3swTouxs6 NxdN6K1lZ9Alw== Message-ID: <222aacd30ec9edd3e680f6c2ecc65e32b1c9e208.camel@denx.de> Subject: Re: [PATCH] am33xx: Fix USB for am335x boards From: Harald Seiler To: "Matwey V. Kornilov" , paul.barker@sancloud.com, dariobin@libero.it, pbrobinson@gmail.com, trini@konsulko.com Cc: u-boot@lists.denx.de Date: Tue, 10 Aug 2021 12:04:23 +0200 In-Reply-To: <20210807111738.8391-1-matwey.kornilov@gmail.com> References: <20210807111738.8391-1-matwey.kornilov@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.3 (3.40.3-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi, On Sat, 2021-08-07 at 14:17 +0300, Matwey V. Kornilov wrote: > USB nodes were mistakenly disabled in > > commit 942853dd96df ("arm: dts: Resync BeagleBone device trees") To be precise, the problem is that only half of the device tree files were synced. am33xx.dtsi (and seemingly some more) were skipped, leading to the symptoms you found. I think it is likely that the upstream changes in am33xx.dtsi which we are missing right now will lead to more regressions of similar nature. So I'd say we should dig deeper into the problems you encountered while attempting to just sync the entirety of am33xx.dtsi. The end goal is that all device-tree files not ending in `-uboot` match what is in Linux, so it is inevitable that someone needs to look into this anyway. -- Harald > This commit is to fix the following issue: > > starting USB... > No working controllers found > USB is stopped. Please issue 'usb start' first. > starting USB... > No working controllers found > > Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0782e8572ce43f521ed6ff15e4a7ab9aa5acdc85 > Fixes: 942853dd96df ("arm: dts: Resync BeagleBone device trees") > Signed-off-by: Matwey V. Kornilov > --- > arch/arm/dts/am33xx.dtsi | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/arch/arm/dts/am33xx.dtsi b/arch/arm/dts/am33xx.dtsi > index ce07cec846..b5093020ee 100644 > --- a/arch/arm/dts/am33xx.dtsi > +++ b/arch/arm/dts/am33xx.dtsi > @@ -380,28 +380,24 @@ > #address-cells = <1>; > #size-cells = <1>; > ti,hwmods = "usb_otg_hs"; > - status = "disabled"; > > usb_ctrl_mod: control@44e10620 { > compatible = "ti,am335x-usb-ctrl-module"; > reg = <0x44e10620 0x10 > 0x44e10648 0x4>; > reg-names = "phy_ctrl", "wakeup"; > - status = "disabled"; > }; > > usb0_phy: usb-phy@47401300 { > compatible = "ti,am335x-usb-phy"; > reg = <0x47401300 0x100>; > reg-names = "phy"; > - status = "disabled"; > ti,ctrl_mod = <&usb_ctrl_mod>; > #phy-cells = <0>; > }; > > usb0: usb@47401000 { > compatible = "ti,musb-am33xx"; > - status = "disabled"; > reg = <0x47401400 0x400 > 0x47401000 0x200>; > reg-names = "mc", "control"; > @@ -443,14 +439,12 @@ > compatible = "ti,am335x-usb-phy"; > reg = <0x47401b00 0x100>; > reg-names = "phy"; > - status = "disabled"; > ti,ctrl_mod = <&usb_ctrl_mod>; > #phy-cells = <0>; > }; > > usb1: usb@47401800 { > compatible = "ti,musb-am33xx"; > - status = "disabled"; > reg = <0x47401c00 0x400 > 0x47401800 0x200>; > reg-names = "mc", "control"; -- Harald DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-62  Fax: +49-8142-66989-80   Email: hws@denx.de