From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC3F0C4338F for ; Wed, 4 Aug 2021 19:53:18 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFE8D60F58 for ; Wed, 4 Aug 2021 19:53:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BFE8D60F58 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=buserror.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D225282F3F; Wed, 4 Aug 2021 21:53:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=buserror.net Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 66DC282F4D; Wed, 4 Aug 2021 21:53:12 +0200 (CEST) Received: from baldur.buserror.net (baldur.buserror.net [165.227.176.147]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A795D82DD4 for ; Wed, 4 Aug 2021 21:53:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=buserror.net Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=oss@buserror.net Received: from [2601:449:8480:af0::97c7] by baldur.buserror.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBMwN-0005KG-VS; Wed, 04 Aug 2021 14:52:36 -0500 Message-ID: <22eb78079a4f99f2966c99a59872b439de0a2237.camel@buserror.net> From: Scott Wood To: Simon Glass , U-Boot Mailing List Cc: Tim Harvey , Albert Aribaud , Tom Rini Date: Wed, 04 Aug 2021 14:52:34 -0500 In-Reply-To: <20210801205951.2202789-2-sjg@chromium.org> References: <20210801205951.2202789-1-sjg@chromium.org> <20210801205951.2202789-2-sjg@chromium.org> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2601:449:8480:af0::97c7 X-SA-Exim-Rcpt-To: sjg@chromium.org, u-boot@lists.denx.de, tharvey@gateworks.com, albert.u.boot@aribaud.net, trini@konsulko.com X-SA-Exim-Mail-From: oss@buserror.net Subject: Re: [PATCH v3 2/3] arm: Add an __image_copy_start symbol for ARMv8 X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on baldur.buserror.net) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sun, 2021-08-01 at 14:59 -0600, Simon Glass wrote: > This symbol is needed for binman to locate the start of the image. Add it. > > Note: the existing line to bring in the .__image_copy_start symbol does > not appear to do anything. > > Signed-off-by: Simon Glass > --- > I have copied Scott Wood who originally added the line about the > __image_copy_start in the hope that he can decide if we should remove it. It's been a long time since I looked at this stuff, but __image_copy_start is used for relocation and that code does not seem to be in the SPL, so the *(.__image_copy_start) was probably just a copy-and-paste leftover from the main SPL that can go away. Of course, that doesn't resolve the binman issue. :-) > diff --git a/arch/arm/cpu/armv8/u-boot-spl.lds b/arch/arm/cpu/armv8/u-boot- > spl.lds > index 9edb662b094..2827a07590d 100644 > --- a/arch/arm/cpu/armv8/u-boot-spl.lds > +++ b/arch/arm/cpu/armv8/u-boot-spl.lds > @@ -22,6 +22,7 @@ ENTRY(_start) >  SECTIONS >  { >         .text : { > +               __image_copy_start = .; >                 . = ALIGN(8); >                 *(.__image_copy_start) >                 CPUDIR/start.o (.text*) If for whatever reason you did need to define the symbol this way, shouldn't it be after the alignment? -Scott