From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A180BECAAD5 for ; Mon, 29 Aug 2022 14:50:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 24B358458A; Mon, 29 Aug 2022 16:50:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="c6cibExn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 327F084928; Mon, 29 Aug 2022 16:50:07 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DABE5805DA for ; Mon, 29 Aug 2022 16:50:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1661784602; bh=z7S4lSKkN5psW+ZRVaCBZxx4nL/lOl1LNdJ4yW0weoU=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=c6cibExnH9UlzIojbI2BUASM3J/Umm/upMF5l+GqtU7YcPQw2vamaGULK2YGzL0U3 Xuz1UVSdWeSXD+fM0L6ntnSHNDtN2wilckMng/U9GApylj5x0cLE3vLjhS8P/fR9xq EzYqc0pNg6KyyCPhbVfcZ9B6wxDsv2nBc8zEn9mo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.67] ([84.118.157.2]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MMGRK-1ojf0W2FGw-00JLkr; Mon, 29 Aug 2022 16:50:02 +0200 Message-ID: <23974856-0b7e-a766-4f6a-c04f75e7d023@gmx.de> Date: Mon, 29 Aug 2022 16:49:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH 01/15] scsi: Tidy up comments for struct scsi_cmd Content-Language: en-US To: Simon Glass Cc: Rob Herring , Stefan Roese , U-Boot Mailing List References: <20220827151513.736395-1-sjg@chromium.org> <20220827151513.736395-2-sjg@chromium.org> From: Heinrich Schuchardt In-Reply-To: <20220827151513.736395-2-sjg@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:iNgoM3AI0uaPS3DbhY3EaQ7zC5Yqk9ZO5jb8aEJoyDGFjx8EzH/ 8E1GtH54r94XHOwyWjkRNF/AHux2cbUB6HHXgFOrEZwgql+g0pc3ZsCrDH2wUZZXXzeCEQM naRkSTfRqLZuS0aq3SbcjekXV/t0Z0Ucx0rfwMVl95NEy440l/yXwWTCniQc/ZtsYiswgIt 8+DQbHDYJA0QqAv3TRIBA== X-UI-Out-Filterresults: notjunk:1;V03:K0:jEG8615K8GU=:pCmaywdqiMRHSEK4a0wl0a WFhfA0kozwU1I5qIrectKp0aiH/MHBRn67F25re2ANaYhvBQ2kQy8H8K93IaUs8ZlakFJmXjy o3rghdhLB5SLl5S8LQqaCU/ROSN5gx9erdXnwlZoL5EPhgiwcq68N9tgJ16zCrGbiFmZdqGbw +aDTmuqT6Og/g3AEE3oQQ20TiNlS/W9jAQvzXx6TAug9PHkI5nolhPRgMbLcGd5HpInfeS/WE T9+gvJ072V6OWNPtxJSNYrxkhwI0ApLwE6wCcjPzKNa/a7Lcxnka9o/JgYTI7dPCG34F9cWsA CEOHaNG95K1Lonic8565lReZCJDAQBsYZUJ7BqYPDs+6QGdh9wO5L9ngRKP+eXEH+A8oqqU8r bcdMUPAnW3Z+PS8vGWbfyR35AGkawcsxwEONNSX1FHM4Ag16knAKN9+2YEeG1CNTJ2ZcoL9I6 dj49jp/SvkHvA9wK3M2GEn/8QYWQJ/ikszvtbbwPqnAECbIx7/8cFvDhhYbjRpfCAqOHL0MD3 8oxmlX633nlVNlaUnlh+OE86XBQEf5k5qD1wj7Lbx+TuEwwCa7wuQsdowFsE0SaasgAj4C14c J3k4gk+dJjAiaAiDM4U1kWZUoGrL6bD1sAx/Hvscmf2A4As5BpcQVz7fVC5rCAZo504CJo+Ku zAgQsEN+i/8HD35mxCZEQ6D8f9aN6Mhbm9wuPhP1KnufDqilvkjfXJtRkdJVasA9O4aqVkqOO gap8z2EV8uSoLeo7LA7q0T6mEYdeVPG5vhF0jfkmwFbjPsTX+qf2xcSvjREVCsRqkom/BbQQ5 Ypux4gmSqw69XsgNVnftP0mthuh2e8JVTfLzI63R1g6oQf23PkBtbbcnZMFjMyWtlXx1JRr3G ZYNfLgCC4fRCKd70E1jUzsxkBLPMYQn9VVCqfTwALekl6Qwwd9kQGCKVBLraYz0n5FZyZ8Pm0 zRFKxqBgGevaNBWgHjJGVIR68PyZi5lHXRLcFHBl4Xsfa7zlAdkPYZcltou4JJTcmguJ6AN8a SsApdfLiUhZVjXF+0rGBRSJP3sFTJ8RD1dq5ADMFSBcoX1SUYaYuNXpZYqD6Bn6c1OGe5Aa9l dryZQN2NHZwM+p7bEO90DjUEdBNt8G7//CiqnD2NH2Oee2WiNb+seHCqg== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 8/27/22 17:14, Simon Glass wrote: > These comments are bit of a mess. Tidy them up to match the correct codi= ng > style. > > Signed-off-by: Simon Glass It would be preferable to use Sphinx style comments as you already did in include/asm-generic/global_data.h. Best regards Heinrich > --- > > include/scsi.h | 34 +++++++++++++++++----------------- > 1 file changed, 17 insertions(+), 17 deletions(-) > > diff --git a/include/scsi.h b/include/scsi.h > index b47c7463c1d..e5d75b0cdca 100644 > --- a/include/scsi.h > +++ b/include/scsi.h > @@ -16,26 +16,26 @@ > struct udevice; > > struct scsi_cmd { > - unsigned char cmd[16]; /* command */ > + unsigned char cmd[16]; /* command */ > /* for request sense */ > - unsigned char sense_buf[64] > + unsigned char sense_buf[64] > __attribute__((aligned(ARCH_DMA_MINALIGN))); > - unsigned char status; /* SCSI Status */ > - unsigned char target; /* Target ID */ > - unsigned char lun; /* Target LUN */ > - unsigned char cmdlen; /* command len */ > - unsigned long datalen; /* Total data length */ > - unsigned char * pdata; /* pointer to data */ > - unsigned char msgout[12]; /* Messge out buffer (NOT USED) */ > - unsigned char msgin[12]; /* Message in buffer */ > - unsigned char sensecmdlen; /* Sense command len */ > - unsigned long sensedatalen; /* Sense data len */ > - unsigned char sensecmd[6]; /* Sense command */ > - unsigned long contr_stat; /* Controller Status */ > - unsigned long trans_bytes; /* tranfered bytes */ > + unsigned char status; /* SCSI Status */ > + unsigned char target; /* Target ID */ > + unsigned char lun; /* Target LUN */ > + unsigned char cmdlen; /* command len */ > + unsigned long datalen; /* Total data length */ > + unsigned char *pdata; /* pointer to data */ > + unsigned char msgout[12]; /* Messge out buffer (NOT USED) */ > + unsigned char msgin[12]; /* Message in buffer */ > + unsigned char sensecmdlen; /* Sense command len */ > + unsigned long sensedatalen; /* Sense data len */ > + unsigned char sensecmd[6]; /* Sense command */ > + unsigned long contr_stat; /* Controller Status */ > + unsigned long trans_bytes; /* tranfered bytes */ > > - unsigned int priv; > - enum dma_data_direction dma_dir; > + unsigned int priv; > + enum dma_data_direction dma_dir; > }; > > /*-----------------------------------------------------------