From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier-oss@weidmueller.com>
To: Michal Simek <monstr@monstr.eu>
Cc: U-Boot <u-boot@lists.denx.de>,
Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>,
Michal Simek <michal.simek@amd.com>
Subject: Re: [PATCH v2] xilinx: zynqmp: Do not use 0 as spl bss start address
Date: Fri, 10 Jun 2022 16:42:55 +0200 [thread overview]
Message-ID: <25751198-541e-9fa0-a23a-db0069eb9327@weidmueller.com> (raw)
In-Reply-To: <CAHTX3dLPTPSGOQHxLr+bjLHSdVzw4R=sgdtARmX0T3bq5VVgzg@mail.gmail.com>
Hi Michal,
what is the default entry address for the aft / bl31.bin?
I have a bl31.bin with an entry address of 0x1000 and this is inside the
BSS.
Regards
Stefan
Am 07.06.2022 um 10:13 schrieb Michal Simek:
> út 7. 6. 2022 v 9:44 odesílatel Stefan Herbrechtsmeier
> <stefan.herbrechtsmeier-oss@weidmueller.com> napsal:
>>
>> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>>
>> Do not use 0 as address for memory because of the special meaning for
>> pointers (null pointer). Change the spl bss start address to the second
>> page.
>>
>> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>>
>> ---
>> The problem was discovered with a static array initialized with zero.
>> The compiler placed the array at address 0 and thereby a pointer to the
>> array was interpreted as null pointer.
>>
>> Changes in v2:
>> - Rework commit message and replace address null by 0
>>
>> include/configs/xilinx_zynqmp.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/configs/xilinx_zynqmp.h b/include/configs/xilinx_zynqmp.h
>> index f25d796a1e..21a5cf1617 100644
>> --- a/include/configs/xilinx_zynqmp.h
>> +++ b/include/configs/xilinx_zynqmp.h
>> @@ -209,7 +209,7 @@
>> #define CONFIG_SPL_MAX_SIZE 0x40000
>>
>> /* Just random location in OCM */
>> -#define CONFIG_SPL_BSS_START_ADDR 0x0
>> +#define CONFIG_SPL_BSS_START_ADDR 0x1000
>> #define CONFIG_SPL_BSS_MAX_SIZE 0x80000
>>
>> #if defined(CONFIG_SPL_SPI_FLASH_SUPPORT)
>> --
>> 2.30.2
>>
>
> Applied.
> M
>
next prev parent reply other threads:[~2022-06-10 14:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 7:43 [PATCH v2] xilinx: zynqmp: Do not use 0 as spl bss start address Stefan Herbrechtsmeier
2022-06-07 8:13 ` Michal Simek
2022-06-10 14:42 ` Stefan Herbrechtsmeier [this message]
2022-06-10 16:48 ` [SPAM] " Xavier Drudis Ferran
2022-06-13 7:20 ` Michal Simek
2022-06-13 8:21 ` Stefan Herbrechtsmeier
2022-06-13 9:02 ` Stefan Herbrechtsmeier
2022-06-14 13:03 ` Michal Simek
2022-06-14 15:34 ` Stefan Herbrechtsmeier
2022-06-14 15:49 ` Michal Simek
2022-06-14 16:24 ` Stefan Herbrechtsmeier
2022-07-14 12:22 ` Stefan Herbrechtsmeier
2022-07-14 12:26 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25751198-541e-9fa0-a23a-db0069eb9327@weidmueller.com \
--to=stefan.herbrechtsmeier-oss@weidmueller.com \
--cc=michal.simek@amd.com \
--cc=monstr@monstr.eu \
--cc=stefan.herbrechtsmeier@weidmueller.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).