Re: [PATCH 2/3] buildman: Detect Kconfig loops

[Stefano Babic <sbabic@denx.de>]

Hi Simon,

On 21.10.21 18:15, Tom Rini wrote:
> On Thu, Oct 21, 2021 at 10:09:56AM -0600, Simon Glass wrote:
>> Hi Tom,
>>
>> On Thu, 21 Oct 2021 at 06:13, Tom Rini <trini@konsulko.com> wrote:
>>>
>>> On Tue, Oct 19, 2021 at 09:43:24PM -0600, Simon Glass wrote:
>>>
>>>> Hex and int Kconfig options are supposed to have defaults. This is so we
>>>> can configure U-Boot without having to enter particular values for the
>>>> items that don't have specific values in the board's defconfig file.
>>>
>>> That's not true.  All symbols that we can make reasonable defaults for
>>> get them.  It's just that for boolean n is a reasonable default.
>>> int/hex often just need to be entered, period.
>>>
>>> Everything else is fine however, thanks for digging in to this.
>>
>> I got that from there and it made sense as to why we have this problem:
>>
>> https://docs.zephyrproject.org/2.4.0/guides/kconfig/tips.html#redundant-defaults
> 
> Yeah, we're just in the bad spot because of things not being fully
> migrated.
> 
>> But I think you are right if we should update the commit message here
>> to avoid confusion. Shall I send v2?
> 
> Yes please.

As delta...

I applied 1-2 to u-boot-imx (else I was stuck), and they are already 
merged as part of my PR. Your patches are already on -master.

Regards,
Stefano



-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================