u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Hannes Schmelzer <hannes@schmelzer.or.at>
To: u-boot@lists.denx.de
Subject: Re: [PATCH v1] drivers/gpio: add support for MAX7320 i2c i/o expander
Date: Fri, 1 Oct 2021 21:15:16 +0200	[thread overview]
Message-ID: <39cefd86-1e7f-87f2-f6a2-dea9e14fdd05@schmelzer.or.at> (raw)
In-Reply-To: <20211001135225.GA6121@bill-the-cat>

Am 01.10.2021 um 15:52 schrieb Tom Rini:
> On Fri, Oct 01, 2021 at 01:37:57PM +0200, Hannes Schmelzer wrote:
>
>> This commit adds support for the MAX7320 (and clones) gpio expander.
>>
>> Signed-off-by: Hannes Schmelzer <hannes.schmelzer@br-automation.com>
>> ---
>>
>>   doc/device-tree-bindings/gpio/gpio-max7320.txt |  36 ++++++++
>>   drivers/gpio/Kconfig                           |   8 ++
>>   drivers/gpio/Makefile                          |   1 +
>>   drivers/gpio/max7320_gpio.c                    | 113 +++++++++++++++++++++++++
>>   4 files changed, 158 insertions(+)
>>   create mode 100644 doc/device-tree-bindings/gpio/gpio-max7320.txt
>>   create mode 100644 drivers/gpio/max7320_gpio.c
>>
>> diff --git a/doc/device-tree-bindings/gpio/gpio-max7320.txt b/doc/device-tree-bindings/gpio/gpio-max7320.txt
>> new file mode 100644
>> index 0000000..87b703b
>> --- /dev/null
>> +++ b/doc/device-tree-bindings/gpio/gpio-max7320.txt
>> @@ -0,0 +1,36 @@
>> +* MAX7320 I/O expanders
>> +
>> +The original maxim 7320 i/o expander offers 8 bit push/pull outputs.
>> +There exists some clones which offers 16 bit.
>> +
>> +Required Properties:
>> +
>> +  - compatible: should be one of the following.
>> +    - "maxim,max7320"
>> +
>> +  - reg: I2C slave address.
>> +
>> +  - gpio-controller: Marks the device node as a gpio controller.
>> +  - #gpio-cells: Should be 2. The first cell is the GPIO number and the second
>> +    cell specifies GPIO flags, as defined in <dt-bindings/gpio/gpio.h>. Only the
>> +    GPIO_ACTIVE_HIGH and GPIO_ACTIVE_LOW flags are supported.
>> +
>> +Optional Properties:
>> +
>> +   - ngpios: tell the driver how many gpios the device offers.
>> +     if the property is omitted, 8bit (original maxim) is assumed.
>> +
>> +Please refer to gpio.txt in this directory for details of the common GPIO
>> +bindings used by client devices.
>> +
>> +Example: MAX7320 I/O expander node
>> +
>> +	ledgpio: max7320@5d {
>> +		status = "okay";
>> +		compatible = "maxim,max7320";
>> +		reg = <0x5d>;
>> +		#gpio-cells = <2>;
>> +		gpio-controller;
>> +		ngpios = <16>;
>> +	};
>> +
> Where does this binding come from?  Thanks!
>
Hi Tom,

i took it from 'doc/device-tree-bindings/gpio/gpio-pcf857x.txt'  and 
adapted it for my needs.

cheers,
Hannes


  reply	other threads:[~2021-10-01 19:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-01 11:37 [PATCH v1] drivers/gpio: add support for MAX7320 i2c i/o expander Hannes Schmelzer
2021-10-01 13:52 ` Tom Rini
2021-10-01 19:15   ` Hannes Schmelzer [this message]
2021-10-20  0:46 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39cefd86-1e7f-87f2-f6a2-dea9e14fdd05@schmelzer.or.at \
    --to=hannes@schmelzer.or.at \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).