From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B38C1C28D13 for ; Thu, 25 Aug 2022 14:33:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 49C1E8484C; Thu, 25 Aug 2022 16:33:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=quicinc.com header.i=@quicinc.com header.b="UeK0vWl9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E130B8487B; Thu, 25 Aug 2022 16:33:47 +0200 (CEST) Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 25F2B845E9 for ; Thu, 25 Aug 2022 16:33:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=quic_jaehyoo@quicinc.com Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27PBLnN6011874; Thu, 25 Aug 2022 14:33:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=VDQ9CpEXE6GmeFXeu61a3LTWmf6dLuCytn0W4nl7eBY=; b=UeK0vWl9yNaLBVxw88COt3Pr9EicR/STWf6QhvHBLV/D9C5NUH449cxzjFxZHcrX+c3r +iksEQppbcFmfOa/ZJxmzaz+vb9BLleP/GnlRBDj27C4+tQxH7NovZxyJWZ6sxNxfzjV t0PUoCtJjFjVZ15zo1GaNYiUlBVM+V0rqU6CCNpbvuVw+MZifEzEsB07E/fjCB/Qw6Zz oB2p6zW1dxVVVyRb5xPRcsNzYuCXnHvh3wO1/crXUYve3JTgATGYMlQgDlhpHcbdZlGU rCsJ9gRsoOeHmppJzKpvZxe9WAThwKdhK9/ZSYNnziHyMVec3ySiDmWCqQ88257g70rn 0g== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3j60ett298-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Aug 2022 14:33:13 +0000 Received: from pps.filterd (NALASPPMTA03.qualcomm.com [127.0.0.1]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 27PEXCRB006022; Thu, 25 Aug 2022 14:33:13 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NALASPPMTA03.qualcomm.com (PPS) with ESMTPS id 3j47bn6n26-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Aug 2022 14:33:12 +0000 Received: from NALASPPMTA03.qualcomm.com (NALASPPMTA03.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 27PEUWwK002971; Thu, 25 Aug 2022 14:33:12 GMT Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (PPS) with ESMTPS id 27PEXCn9006013 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Aug 2022 14:33:12 +0000 Received: from [10.110.24.229] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Thu, 25 Aug 2022 07:33:10 -0700 Message-ID: <3a05f78d-895a-86c8-d1a2-1aff752054e4@quicinc.com> Date: Thu, 25 Aug 2022 07:33:05 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 4/7] cmd: fru: add product info area parsing support Content-Language: en-US To: Simon Glass CC: Michal Simek , Ovidiu Panait , Mario Six , "Masahisa Kojima" , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Heinrich Schuchardt , Ashok Reddy Soma , Thomas Huth , Huang Jianan , Chris Morgan , Roland Gaudig , Patrick Delaunay , Alexandru Gagniuc , Jamie Iles , Graeme Gregory , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , U-Boot Mailing List References: <20220823215300.1485789-1-quic_jaehyoo@quicinc.com> <20220823215300.1485789-5-quic_jaehyoo@quicinc.com> From: Jae Hyun Yoo In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: HtIyHagPd89gW7Mm1KlMEaNETKKffC1R X-Proofpoint-ORIG-GUID: HtIyHagPd89gW7Mm1KlMEaNETKKffC1R X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-25_05,2022-08-25_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 mlxscore=0 clxscore=1015 impostorscore=0 mlxlogscore=999 priorityscore=1501 bulkscore=0 adultscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208250054 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On 8/24/2022 6:25 PM, Simon Glass wrote: > Hi Jae, > > On Tue, 23 Aug 2022 at 14:53, Jae Hyun Yoo wrote: >> >> Add product info area parsing support. Custom board fields can be >> added dynamically using linked list so that each board support can >> utilize them in their own custom way. >> >> Signed-off-by: Jae Hyun Yoo >> --- >> Changes from v2: >> * Changed 'struct fru_board_info_member' to 'struct fru_common_info_member'. >> >> Changes from v1: >> * Refactored using linked list instead of calling a custom parsing callback. >> >> Changes from RFC: >> * Added manufacturer custom product info fields parsing flow. >> >> cmd/fru.c | 28 ++++-- >> include/fru.h | 34 ++++++- >> lib/fru_ops.c | 244 +++++++++++++++++++++++++++++++++++++++++++++++--- >> 3 files changed, 286 insertions(+), 20 deletions(-) >> > > Please add tests for this code. I already added c and python version unit test scripts in this series. Thanks, Jae