Re: [PATCH] mmc: zynq_sdhci: Add xilinx_pm_request weak function

From: Michal Simek <michal.simek@xilinx.com>
To: T Karthik Reddy <t.karthik.reddy@xilinx.com>, <u-boot@lists.denx.de>
Cc: <michal.simek@xilinx.com>, <peng.fan@nxp.com>,
	<jh80.chung@samsung.com>,
	Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
Subject: Re: [PATCH] mmc: zynq_sdhci: Add xilinx_pm_request weak function
Date: Mon, 4 Oct 2021 16:16:06 +0200	[thread overview]
Message-ID: <3da4ae71-5880-9b1a-dc5b-1e3ebd6b8273@xilinx.com> (raw)
In-Reply-To: <1633086518-32636-1-git-send-email-t.karthik.reddy@xilinx.com>

On 10/1/21 1:08 PM, T Karthik Reddy wrote:
> Mini emmc does not use any pmufw and ZYNQMP_FIRMWARE is disabled.
> xilinx_pm_request() will not be compiled and causes undefined reference to
> `xilinx_pm_request' error. So add a weak function in zynq_sdhci.c file.
> 
> Signed-off-by: T Karthik Reddy <t.karthik.reddy@xilinx.com>
> Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
> ---
> 
>  drivers/mmc/zynq_sdhci.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/mmc/zynq_sdhci.c b/drivers/mmc/zynq_sdhci.c
> index c94825dceb..5cea4c695e 100644
> --- a/drivers/mmc/zynq_sdhci.c
> +++ b/drivers/mmc/zynq_sdhci.c
> @@ -69,6 +69,12 @@ __weak int zynqmp_mmio_write(const u32 address, const u32 mask, const u32 value)
>  	return 0;
>  }
>  
> +__weak int xilinx_pm_request(u32 api_id, u32 arg0, u32 arg1, u32 arg2,
> +			     u32 arg3, u32 *ret_payload)
> +{
> +	return 0;
> +}
> +
>  #if defined(CONFIG_ARCH_ZYNQMP) || defined(CONFIG_ARCH_VERSAL)
>  /* Default settings for ZynqMP Clock Phases */
>  static const u32 zynqmp_iclk_phases[] = {0, 63, 63, 0, 63,  0,
> 

Applied.
M