From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E257ECAAD2 for ; Mon, 29 Aug 2022 14:51:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CDAA18458A; Mon, 29 Aug 2022 16:51:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="inRZaaT9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C52908493F; Mon, 29 Aug 2022 16:51:43 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A9798805DA for ; Mon, 29 Aug 2022 16:51:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1661784698; bh=RQ6mM3LxW8iGyaUFa3gsBqkG00LBzK1iXjmWrRGb8ho=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=inRZaaT9eyUaL0VVDvmv5WfJ/CiUuvcu2VlC3WFrFQp7zhbft0RC1xU94PunK6drk aSmgxslLn7jJA+K8UrJxk6hd11sBfoXJXt5yk06eiSlFLsoSJOYFeH9Cyw4znNBvHd IgEr8gF0pyn9Y2plssHOd2svelZrByvL8aEPrhQM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.67] ([84.118.157.2]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N6bjy-1pTkJD3XEk-0185sK; Mon, 29 Aug 2022 16:51:37 +0200 Message-ID: <441979b4-10b0-d4ed-b878-960c02339113@gmx.de> Date: Mon, 29 Aug 2022 16:51:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH 11/15] sandbox: scsi: Move structs to header file Content-Language: en-US To: Simon Glass Cc: Andrew Scull , Marek Vasut , Rob Herring , Sean Anderson , Stefan Roese , U-Boot Mailing List References: <20220827151513.736395-1-sjg@chromium.org> <20220827151513.736395-12-sjg@chromium.org> From: Heinrich Schuchardt In-Reply-To: <20220827151513.736395-12-sjg@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:5MIV5dP5RSfTHjxLFoey8NYUsdijc/hof+NedYHFYSFtE8XYrMO YwfgEEK7+lKJH/dRHEGCm6lcOjiH4esoW12bfG+AzhJm1cSixZgRlfal7M/VPt3UXKlPQTp QW9109hTSYmnAQfrKQOAYpwbXRWnra4ewIiDXsE61UhOV5u9aFekFoqySFQuCdepAR6smYP mnIXaLV12U4UdbbAvsXmA== X-UI-Out-Filterresults: notjunk:1;V03:K0:DgK23p3YHQE=:+gBkarKlhyXnRIOtDqaIg3 Qor/PsOR5ms/mrxl6LJztc+H315TFUaiD+tzYv/t39Pady0gpNFgD+27XWuz1bnzhLiecBXV6 p0pLXavstWHA063Mh+c2hO2tx3+QUTdydFGHik1CJykug4i2N1fXieK0+FKJVaKe8e5kR6Onj YJkqCcznwn9p9BjD2pE3XY/CcHgPBodm2rff4zWSNMgd/gsAwl4TOrPMzyMCaX0NN7GzkVt/E yDKHWT4pwtlbXyEJ9VWkSufYGX52JryDhzKo4NbA/KFgxMrcG6Z1buDU+ZXtFATJbeMZvaxaS h/SUHXMX1/cuSpez4QqBdijzVNMgzy/YdluTYMCK59QT9lEv8GRb27QtLXqwPxVmE4CzrB3ox v6PCWa96OUnRJ0XDd25m6CYxhUZ3hNo2CH5260MUMKrabitUuzFW5pFFpp2iAB1FTekoJ+WwM 6pSjdXUvkoRFVXk6eE8+k1Sw+PqyAvdvgK9oQ6JuYv0KGr0ETSj168Evem1GA5bFfRrTZLY6A pHGDa32crtvrTO2c1xZTZ2+b3UDHWHvDTBwAVG05OdTcqJp25JSM9hgZYI2qhYhtHLZ27U3NX 90l7m/4Lw0xrqRvQXockEEy3w1RsPHmJdYLDHij7OwVJpsP6GqhxB9gofWcaL+FpqHhymk0Yy PEgk7LaTQm8KasfDZoPvc2PmhqsFBXGMxWrea+6KOjL3PTzX1ZM5tISmQD8wN72gy/hvtgS9g NIsZTVIjCItG0wlilAnNuY+0OvnRa/iIn/zk3wuDSgV2aGE0IzrqEm3YwXboGe5FohLf7eVrP 7JWcnXao2iyhoOiitvK5sGD3qROlie/4PcQSUYOQGUham39KalhD2GihrVQ7hRhyqLmVmF/zH rhI6SZ0axiVZ1RUjQ16IV03sG3ShXfeEQBfN12wG6TKNbgifesqCnl6dcSJ654npJJ6Vs5Yao bs24gPF5bkgeN06o13SoCNw4TTYSghSCPRtTJ+y4ITZwvmttHj2B1ZHz5xf0HMYVo11ojg7/9 QaUvY5rOlEpfSDWY0TGlj8S/ccJNqS0AHyhzXTE/YwAjxQdAdvLqm5S6KB42LqKkWtBVgVt6u v50BRdD/GJNU+TmTHWaLyX2j8p97pTQ56eli5kNFDpnFN1otF/Oy/8gSg== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 8/27/22 17:15, Simon Glass wrote: > Move these to the SCSI header file so we can access them from multiple > emulators. > > Signed-off-by: Simon Glass > --- > > drivers/usb/emul/sandbox_flash.c | 26 -------------------------- > include/scsi.h | 26 ++++++++++++++++++++++++++ > 2 files changed, 26 insertions(+), 26 deletions(-) > > diff --git a/drivers/usb/emul/sandbox_flash.c b/drivers/usb/emul/sandbox= _flash.c > index 7b9a99c1a38..2059fc7fe42 100644 > --- a/drivers/usb/emul/sandbox_flash.c > +++ b/drivers/usb/emul/sandbox_flash.c > @@ -57,32 +57,6 @@ struct sandbox_flash_plat { > struct usb_string flash_strings[STRINGID_COUNT]; > }; > > -struct scsi_inquiry_resp { > - u8 type; > - u8 flags; > - u8 version; > - u8 data_format; > - u8 additional_len; > - u8 spare[3]; > - char vendor[8]; > - char product[16]; > - char revision[4]; > -}; > - > -struct scsi_read_capacity_resp { > - u32 last_block_addr; > - u32 block_len; > -}; > - > -struct __packed scsi_read10_req { > - u8 cmd; > - u8 lun_flags; > - u32 lba; > - u8 spare; > - u16 xfer_len; > - u8 spare2[3]; > -}; > - > static struct usb_device_descriptor flash_device_desc =3D { > .bLength =3D sizeof(flash_device_desc), > .bDescriptorType =3D USB_DT_DEVICE, > diff --git a/include/scsi.h b/include/scsi.h > index 5d63963bed0..d8f0d9c7dcd 100644 > --- a/include/scsi.h > +++ b/include/scsi.h > @@ -173,6 +173,32 @@ enum scsi_cmd_phase { > SCSIPH_STATUS, > }; > > +struct scsi_inquiry_resp { Where is the (Sphinx style) description? Best regards Heinrich > + u8 type; > + u8 flags; > + u8 version; > + u8 data_format; > + u8 additional_len; > + u8 spare[3]; > + char vendor[8]; > + char product[16]; > + char revision[4]; > +}; > + > +struct scsi_read_capacity_resp { > + u32 last_block_addr; > + u32 block_len; > +}; > + > +struct __packed scsi_read10_req { > + u8 cmd; > + u8 lun_flags; > + u32 lba; > + u8 spare; > + u16 xfer_len; > + u8 spare2[3]; > +}; > + > /** > * struct scsi_plat - stores information about SCSI controller > *