From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8700EC4332F for ; Fri, 14 Oct 2022 15:27:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4114884AF8; Fri, 14 Oct 2022 17:27:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=siemens.com header.i=@siemens.com header.b="Rto9Kydk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DFAC484B67; Fri, 14 Oct 2022 17:27:45 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060.outbound.protection.outlook.com [40.107.21.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4B5AB8456E for ; Fri, 14 Oct 2022 17:27:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jan.kiszka@siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=irdr+VlNYkAcCYt31Zth+f3eG9MUm/rIjs2J9dxz+O03OgkxQuU2B3ow1npwx74H4XNuuWbQ0laA7LepD6CzMdcwZF9sQ7WEmKeS0Nx0Fee1R7BaGonvlvwsKv5byfoOKbjBOhyIHjMAWvJuq9DATPLsqH8yVBG9TxRS3TWcb/jvIAwnCGhd+JVV5UUPIRuhabz9F6FJFe/0bfFJIjgZTShEqQO/mN4QnE5pX7tvZUH4c30wkfc49j/BvGxhWw5Ef4e8kiDlFhUIUgjFphPHIhGaNmtdU6mw4H0czTUG+yUHzyfP7qW0eO8TKEsL5upeGwnanl8qNWBFQwjDlTL/AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oM1Jqjhnq7SFrgZOuctw0rnrcysn7ZoYQqhYPRus4ao=; b=W6IrAxdz05tQDa7RJwsW43npiuUr7T7gNbDvTWSogG9tNuDxtCLyQ4RW27y1R6fwuLpfFjvqKbhfQAAv19wyG1XzcRgUv+mHJOQdsvIYup1g1ldeVL0VQauhZz+WRBnE6tBifIMM0/FodaPyEtpIqUValU5vFpYJz5IbmPQotfofEZVH3q+rMRJlHNgvxv+T/mrzVeIS2k4+H2UKnqXK5952bQWCe1xAozrelFxlY5efOOmz2lR5no1g7rdtPuZakzEtPuhxeKrSdGhSKfIfusUsGJ8sZH8gTo/s6AFLKqEFMQq6Rgz3jX1JU4RqaABKX2t1PX6t994Rcko/eZWGCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.75) smtp.rcpttodomain=konsulko.com smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oM1Jqjhnq7SFrgZOuctw0rnrcysn7ZoYQqhYPRus4ao=; b=Rto9KydkU+9HisPkskB6BfmRBkyDJ59PROj3IfhF8lpF5cIxqVG8Qj2MYx7dO9pjnjhxj5n7TmH+waELo2plCERfqHhaFBRAkmMwRDbtJYvMxr/3at3JT9s7irX8CVpE4/OQN0du+8v04sN2puQ52nwECxjGwgR1FsVAJg0J/6AzBOk1Z/S183ZmOqS7bSALpSXQVxC5QsqKua03eR+tzvjv7XnlSa4AgGOsFPomdiSm+nP2pZVkkneKrWBBGTt3WAeevAnB3Aw9t8FMbZUEQxGfDWrV/4+8o/swuz3u3hujjmjQq+H7TxrmzUjhRNOms1A6i/mSGCzG4AcrpGFpmg== Received: from AS9PR06CA0490.eurprd06.prod.outlook.com (2603:10a6:20b:49b::16) by AS2PR10MB7525.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:592::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct 2022 15:27:42 +0000 Received: from VE1EUR01FT081.eop-EUR01.prod.protection.outlook.com (2603:10a6:20b:49b:cafe::5f) by AS9PR06CA0490.outlook.office365.com (2603:10a6:20b:49b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend Transport; Fri, 14 Oct 2022 15:27:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.75) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.75 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.75; helo=hybrid.siemens.com; pr=C Received: from hybrid.siemens.com (194.138.21.75) by VE1EUR01FT081.mail.protection.outlook.com (10.152.3.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.20 via Frontend Transport; Fri, 14 Oct 2022 15:27:41 +0000 Received: from DEMCHDC89XA.ad011.siemens.net (139.25.226.103) by DEMCHDC8VRA.ad011.siemens.net (194.138.21.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.12; Fri, 14 Oct 2022 17:27:40 +0200 Received: from [139.21.18.154] (139.21.18.154) by DEMCHDC89XA.ad011.siemens.net (139.25.226.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.12; Fri, 14 Oct 2022 17:27:40 +0200 Message-ID: <45c70284-f293-3e00-4281-e46ca04b849d@siemens.com> Date: Fri, 14 Oct 2022 17:27:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model Content-Language: en-US To: Tom Rini , Heinrich Schuchardt CC: Bin Meng , Christian Melki , Ilias Apalodimas , U-Boot Mailing List , Alexander Graf , Simon Glass References: <20210925003055.759305-1-sjg@chromium.org> <20210924183029.v2.1.Id572ddf5eb457096b95d30ae2d8675f539367fe8@changeid> <5e4facbe-c78b-c3a6-2fb6-b268e8761d66@gmx.de> <87380b1a-5011-1e75-a02c-2508227e9818@siemens.com> <20221014152029.GT2020586@bill-the-cat> From: Jan Kiszka In-Reply-To: <20221014152029.GT2020586@bill-the-cat> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [139.21.18.154] X-ClientProxiedBy: DEMCHDC8WAA.ad011.siemens.net (139.25.226.104) To DEMCHDC89XA.ad011.siemens.net (139.25.226.103) X-TM-AS-Product-Ver: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-AS-Result: No-10--15.494900-8.000000 X-TMASE-MatchedRID: 0lZ3oI+t/5o5QaOxwNGfvo9bHfxDWoibW6eKzKKCgnPBjbyj5wYDmv6l pfpte41hWAuSz3ewb220QygafZjV1RvER19e8+LDuWcLt7UQTIALyuqgPh8WPp3bt4XlQMWjecm 5MLY/474da1Vk3RqxOIgnLdHU7oiOHPbzAuybsHyFvwEmnsW3vcHVNeDWrWSGdhnFihmbnwVp4x orO9dSmdzONa1Rspx34rl+FHG3VoDu6gyVCKrNt/5nI8KIHQ65Xnan/9QqlwtfvuAR8NI0nClay zmQ9QV0o1NatSknW0o/PJ8p+RzsAaZQJOJiUzzRnKmf6d82B1mj9HPhXvu25ArgwFF/sjumIiTd 2l7lf6HDshTlues35G2HWvR90BF16NIZ/ft6soBRHkbwQy5W80fX0Ayg3UN3JKe4kl4op4SU2cl PVGqDdioBmWjkLcuLKlYwxaYDzXfwSXucicbP9C8cRwTHQ3O6Mu8LwvFHOh2eAiCmPx4NwFkMvW Auahr8+gD2vYtOFhgqtq5d3cxkNfAxRSAc0OEN9v+NNOVSdf8zp/CX+cOsQa/Zsi13oOvqqnh9o ps4J5evwoWYOdsrp18c0Hckeg4M X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--15.494900-8.000000 X-TMASE-Version: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-SNTS-SMTP: 3A7412F2ACA9B3ADA38E6EE220D202054261DDA76E71CE21BA2188C9D6EF1E002000:8 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1EUR01FT081:EE_|AS2PR10MB7525:EE_ X-MS-Office365-Filtering-Correlation-Id: ed4fd5e3-d161-4f60-e83d-08daadf8a2ad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B3GF3qYek1fIGQihKKeeShMpEnVhrLlMZX+gYbwQyZu6Li66/VbZ1O5M/rtDmjiN2EZzaPrstnFNfPSuR664ZvN9mdxdnqs0CUsBuRznZPec7i2umlpUDMhEFceoJ6uyfNB58MkgsqZ2SteJ6quNmp3LJ3G7WR8ibfgE/hvp84IlX/gQQEItWb/NT+ia9TpqhpwblCeyhtgBPjwpewUltw8Yb5D731ue/9H4h4CiQUKjJumwxbJYp/92VZg0aLrIRJTWGmWXZq/6Oxnfk2jub3WFuVJbt4eaenohSsXwxHadUvRUbt/fUWXKaDmluU8qDlGzS+iHpZlbeR1CPxGZL1MLyM4KkhLwrfrUsMwe3RBoZVQwmhHmN5lI5AAstvFAgrL1h1Z+GxeCGbeWSUgWevFOzCCkBWQz4T4WNKO8svWe6q1eimhtSOjQ0UmlwBR+je7IRgpmw5f/6pGa3SEUnA33GG4SLWicblBY5VuSHjxJPcnkWNKpUYW2YxCMIQi6BWEzrBmvyJFyLH29ztaZgrSqSBdiH8if9dYC4AR6ibFpxPA9YGRB0XnsjQAaLWATdojo66hFQiN/L1IPBPlbGYrLsBrsSMVD0jAhimFD+N1XOAbn5cpHJ3KCRC9YjZy6oY9OOocr8Zw/ndNMdlJVvu+jlC7y2oaLKWtd1f6EGAVjVxSK0brlHq70xVIwueRuCUB8Iag659HJ0cZ2sy9QspwHQsq8jCRUcKG7U73Iejg48pHqonOMwlAYajtbtViyXJhNQZvcRvPQ6oH2XgpdVdtazpo7MGuLsKj/l+YNCPqlVF/6QFIi650q0IedD3YBPOUHAkc/Xk267rQD2s+H0lbVpVwr2omDY04Mh7zWDZRarxmK5di9Lt3R0RkmJLtsBUVxQf0MfUHIbrEFpKw04A== X-Forefront-Antispam-Report: CIP:194.138.21.75; CTRY:DE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:hybrid.siemens.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(346002)(396003)(376002)(39860400002)(136003)(451199015)(40470700004)(36840700001)(46966006)(31696002)(86362001)(4326008)(81166007)(82960400001)(8676002)(956004)(2616005)(82740400003)(40460700003)(70586007)(26005)(41300700001)(16576012)(356005)(478600001)(6706004)(47076005)(110136005)(53546011)(54906003)(186003)(83380400001)(2906002)(34070700002)(5660300002)(70206006)(8936002)(316002)(16526019)(36860700001)(336012)(44832011)(31686004)(66899015)(82310400005)(36756003)(40480700001)(3940600001)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 15:27:41.8568 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ed4fd5e3-d161-4f60-e83d-08daadf8a2ad X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; Ip=[194.138.21.75]; Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR01FT081.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR10MB7525 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 14.10.22 17:20, Tom Rini wrote: > On Fri, Oct 14, 2022 at 05:10:55PM +0200, Heinrich Schuchardt wrote: >> On 10/14/22 13:51, Jan Kiszka wrote: >>> On 21.10.21 01:34, Heinrich Schuchardt wrote: >>>> On 9/25/21 2:30 AM, Simon Glass wrote: >>>>> This code should never have been added as it builds a new feature on top >>>>> of legacy code. This has already been improved with the dependency on >>>>> BLK. >>>>> >>>>> Add a dependency on DM_ETH also, to avoid needing to deal with this old >>>>> code. >>>>> >>>>> Boards which want EFI_LOADER should migrate to driver model first. >>>>> >>>>> Note this patch is included to resolve the following build error: >>>>> >>>>> lib/efi_loader/efi_runtime.c:680:16: error: ‘CONFIG_SYS_TEXT_BASE’ >>>>>     undeclared (first use in this function); did you mean >>>>>     ‘CONFIG_SYS_SRAM_BASE’? >>>>>    680 |   ulong base = CONFIG_SYS_TEXT_BASE; >>>>>        |                ^~~~~~~~~~~~~~~~~~~~ >>>>>        |                CONFIG_SYS_SRAM_BASE >>>>> >>>>> Signed-off-by: Simon Glass >>>> >>>> Reviewed-by: Heinrich Schuchardt >>>> >>> >>> How to deal with boards that need CONFIG_NET but do not actually >>> implement any driver (yet)? This now broke UEFI for the IOT2050 which >>> needs NET for network-related device tree setup (see also [1]) and >>> enforces a local hack for us. >> >> UEFI will not provide network without a DM driver. >> The migration period ended 2020.07. >> >> make iot2050_defconfig set EFI_LOADER=y. >> What does not work in UEFI? >> >> Are you missing a way to call eth_get_dev() to trigger aforementioned >> devicetree setup? >> >> Adding 'net list' to CONFIG_PREBOOT might do the trick. > > I think, and this is why I suggested NETDEVICES, the issue is that there > is no network driver in U-Boot, but we need to have networking support > enabled in general, in order to perform device tree fixups for Linux > where there is the network driver. > Exactly. Unfortunately, NETDEVICES does not do the trick because it selects DM_ETH anyway, thus you don't detect legacy network drivers this way. Jan -- Siemens AG, Technology Competence Center Embedded Linux