[U-Boot] [PATCH] display_buffer: fix misaligned buffer

From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] display_buffer: fix misaligned buffer
Date: Mon, 30 Aug 2010 12:46:02 +0200	[thread overview]
Message-ID: <4C7B8BEA.9080605@free.fr> (raw)
In-Reply-To: <4C7B889B.305@denx.de>

Le 30/08/2010 12:31, Stefano Babic a ?crit :
> Detlev Zundel wrote:
>> Hi Reinhard,
>>
> Hi Reinhard, hi Detlev,
>
>>> should make the buffer an union:
>>>
>>> union {
>>> 	uint32_t ui[MAX.../4+1];
>>> 	uint16_t us[MAX.../2+1];
>>> 	uint8_t  uc[MAX...+1];
>>> } linebuf;
>>
>> That also sounds good indeed - it even better documents the intention of
>> the code so by my own arguments I'd vote for it.  I presume you will
>> follow up with such a patch once you tested it?
>
> I agree this is a better solution as adding a simple comment. Some time
> a comment is valid only at the time of the writing, and further patches
> could drop its meaning if the comment is not updated, too.

Do we have to pick one? I say the code should use union *and* a one-line 
comment should mention how the union enforces the alignment requirement.

Amicalement,
-- 
Albert.