From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>,
Simon Glass <sjg@chromium.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Tom Rini <trini@konsulko.com>,
U-Boot Mailing List <u-boot@lists.denx.de>,
Alex Graf <agraf@csgraf.de>
Subject: Re: [RFC 07/22] dm: blk: add UCLASS_PARTITION
Date: Fri, 3 Dec 2021 17:06:56 +0100 [thread overview]
Message-ID: <4cbf0892-761a-7cfa-b810-d0c1234e5b76@gmx.de> (raw)
In-Reply-To: <20211203071657.GD17147@laputa>
On 12/3/21 08:16, AKASHI Takahiro wrote:
> Heinrich,
>
> On Tue, Nov 16, 2021 at 12:01:27PM +0900, AKASHI Takahiro wrote:
>> On Tue, Nov 16, 2021 at 01:02:55AM +0100, Heinrich Schuchardt wrote:
>>> On 11/16/21 00:51, AKASHI Takahiro wrote:
>>>>>> Is the patch good enough to include in the series?
>>>>>>
>>>>>> If not, you could reply to it with what needs doing.
>>>> ? I have already replied to your patch:)
>>>> Basically, it seems to be fine to me.
>>>>
>>>>>> Regards,
>>>>>> Simon
>>>>>>
>>>>> The patch is not usable as is. It assumes only GPT partioning is used.
>>>> @Heinrich
>>>> I don't get your point. Either my patch or Simon's is not specific
>>>> to GPT at all.
>>>>
>>>> So I'm going to start respinning my patch for a next round of discussion.
>>>
>>> A field name gpt_part_info obviously relates to GPT?
>>
>> No.
>>
>> IICU, the structure, disk_partition, is not particularly GPT-specific
>> as such type of data are used over various partition drivers.
>> In my patch series, I simply reuse "struct disk_part" as a structure
>> holding a partition number and partition information (= disk_partition).
>
> So do you agree that we won't have "partition-table" devices for now?
>
> -Takahiro Akashi
We don't need the partition-table to be a udevice now. We still can
later convert the partition drivers to a uclass if we deem it helpful.
Best regards
Heinrich
>
>
>> -Takahiro Akashi
>>
>>> Up to now this string exists only in cmd/gpt.c.
>>>
>>> Best regards
>>>
>>> Heinrich
>>>
>>>>
>>>> -Takahiro Akashi
>>>>
>>>>> Instead all partition table drivers need to be converted to drivers for
>>>>> the new uclass.
>>>>>
>>>>> Best regards
>>>>>
>>>>> Heinrich
>>>
next prev parent reply other threads:[~2021-12-03 16:07 UTC|newest]
Thread overview: 157+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 5:01 [RFC 00/22] efi_loader: more tightly integrate UEFI disks to device model AKASHI Takahiro
2021-10-01 5:01 ` [RFC 01/22] part: call part_init() in blk_get_device_by_str() only for MMC AKASHI Takahiro
2021-10-01 6:41 ` Heinrich Schuchardt
2021-10-01 7:56 ` Heinrich Schuchardt
2021-10-04 3:13 ` AKASHI Takahiro
2021-10-01 11:48 ` Peter Robinson
2021-10-04 3:26 ` AKASHI Takahiro
2021-10-11 10:07 ` Heinrich Schuchardt
2021-10-11 14:32 ` Simon Glass
2021-10-11 15:08 ` Heinrich Schuchardt
2021-10-11 16:14 ` Simon Glass
2021-10-12 3:26 ` AKASHI Takahiro
2021-10-12 13:30 ` Heinrich Schuchardt
2021-10-13 1:50 ` AKASHI Takahiro
2021-10-12 20:31 ` Simon Glass
2021-10-10 14:14 ` Simon Glass
2021-10-01 5:01 ` [RFC 01/22] scsi: call device_probe() after scanning AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-01 5:01 ` [RFC 02/22] " AKASHI Takahiro
2021-10-01 5:01 ` [RFC 02/22] usb: storage: " AKASHI Takahiro
2021-10-01 5:01 ` [RFC 03/22] mmc: " AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-11 1:10 ` AKASHI Takahiro
2021-10-01 5:01 ` [RFC 03/22] usb: storage: " AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-01 5:01 ` [RFC 04/22] mmc: " AKASHI Takahiro
2021-10-01 5:01 ` [RFC 04/22] nvme: " AKASHI Takahiro
2021-10-01 5:01 ` [RFC 05/22] " AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-01 5:01 ` [RFC 05/22] sata: " AKASHI Takahiro
2021-10-01 5:01 ` [RFC 06/22] block: ide: " AKASHI Takahiro
2021-10-01 5:01 ` [RFC 06/22] sata: " AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-11 1:11 ` AKASHI Takahiro
2021-10-01 5:01 ` [RFC 07/22] block: ide: " AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-11 1:43 ` AKASHI Takahiro
2021-10-11 14:54 ` Simon Glass
2021-10-12 5:53 ` Ilias Apalodimas
2021-10-13 0:35 ` AKASHI Takahiro
2021-10-01 5:01 ` [RFC 07/22] dm: blk: add UCLASS_PARTITION AKASHI Takahiro
2021-10-01 9:30 ` Heinrich Schuchardt
2021-10-04 3:27 ` AKASHI Takahiro
2021-10-08 0:51 ` AKASHI Takahiro
2021-10-08 8:23 ` Heinrich Schuchardt
2021-10-11 2:29 ` AKASHI Takahiro
2021-10-11 14:54 ` Simon Glass
2021-10-11 15:02 ` Heinrich Schuchardt
2021-10-11 16:14 ` Simon Glass
2021-10-11 16:48 ` Heinrich Schuchardt
2021-10-11 17:41 ` Simon Glass
2021-10-12 5:12 ` AKASHI Takahiro
2021-10-12 6:42 ` Heinrich Schuchardt
2021-10-12 15:14 ` Tom Rini
2021-10-13 1:32 ` AKASHI Takahiro
2021-10-13 18:05 ` Simon Glass
2021-10-14 8:03 ` AKASHI Takahiro
2021-10-14 20:55 ` Simon Glass
2021-10-28 8:52 ` AKASHI Takahiro
2021-10-28 10:42 ` Heinrich Schuchardt
2021-10-29 1:45 ` Simon Glass
2021-10-29 4:57 ` Heinrich Schuchardt
2021-10-29 6:15 ` AKASHI Takahiro
2021-10-29 19:21 ` Heinrich Schuchardt
2021-10-29 21:17 ` Simon Glass
2021-10-30 5:45 ` Heinrich Schuchardt
2021-11-01 0:36 ` AKASHI Takahiro
2021-11-01 1:15 ` Simon Glass
2021-11-01 1:51 ` AKASHI Takahiro
2021-11-01 2:14 ` Simon Glass
2021-11-02 1:42 ` AKASHI Takahiro
2021-11-02 7:38 ` Heinrich Schuchardt
2021-11-05 2:02 ` Simon Glass
2021-11-05 2:49 ` AKASHI Takahiro
2021-11-05 16:12 ` Simon Glass
2021-11-08 4:46 ` AKASHI Takahiro
2021-11-08 18:44 ` Ilias Apalodimas
2021-11-09 0:09 ` Simon Glass
2021-11-13 18:14 ` Simon Glass
2021-11-13 18:37 ` Heinrich Schuchardt
2021-11-13 21:32 ` Simon Glass
2021-11-15 1:43 ` AKASHI Takahiro
2021-11-15 19:05 ` Simon Glass
2021-11-15 19:16 ` Heinrich Schuchardt
2021-11-15 23:51 ` AKASHI Takahiro
2021-11-16 0:02 ` Heinrich Schuchardt
2021-11-16 3:01 ` AKASHI Takahiro
2021-12-03 7:16 ` AKASHI Takahiro
2021-12-03 16:06 ` Heinrich Schuchardt [this message]
2021-12-06 4:18 ` AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-12 3:53 ` AKASHI Takahiro
2021-10-01 5:01 ` [RFC 08/22] " AKASHI Takahiro
2021-10-01 9:32 ` Heinrich Schuchardt
2021-10-01 5:02 ` [RFC 08/22] dm: blk: add a device-probe hook for scanning disk partitions AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-01 5:02 ` [RFC 09/22] " AKASHI Takahiro
2021-10-01 5:02 ` [RFC 09/22] dm: blk: add read/write interfaces with udevice AKASHI Takahiro
2021-10-01 5:02 ` [RFC 10/22] " AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-01 5:02 ` [RFC 10/22] efi_loader: disk: use udevice instead of blk_desc AKASHI Takahiro
2021-10-01 5:02 ` [RFC 11/22] dm: add a hidden link to efi object AKASHI Takahiro
2021-10-01 5:02 ` [RFC 11/22] efi_loader: disk: use udevice instead of blk_desc AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-01 5:02 ` [RFC 12/22] dm: add a hidden link to efi object AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-11 6:43 ` AKASHI Takahiro
2021-10-11 14:54 ` Simon Glass
2021-10-11 15:26 ` Heinrich Schuchardt
2021-10-11 16:09 ` Simon Glass
2021-10-12 2:09 ` AKASHI Takahiro
2021-10-12 20:31 ` Simon Glass
2021-10-01 5:02 ` [RFC 12/22] efi_loader: remove !CONFIG_BLK code from efi_disk AKASHI Takahiro
2021-10-01 5:02 ` [RFC 13/22] efi_loader: disk: a helper function to create efi_disk objects from udevice AKASHI Takahiro
2021-10-01 5:02 ` [RFC 13/22] efi_loader: remove !CONFIG_BLK code from efi_disk AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-01 5:02 ` [RFC 14/22] dm: blk: call efi's device-probe hook AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-11 3:15 ` AKASHI Takahiro
2021-10-11 14:54 ` Simon Glass
2021-11-01 3:03 ` Simon Glass
2021-10-01 5:02 ` [RFC 14/22] efi_loader: disk: a helper function to create efi_disk objects from udevice AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-11 6:52 ` AKASHI Takahiro
2021-10-11 14:54 ` Simon Glass
2021-10-12 1:09 ` AKASHI Takahiro
2021-10-12 14:08 ` Simon Glass
2021-10-01 5:02 ` [RFC 15/22] dm: blk: call efi's device-probe hook AKASHI Takahiro
2021-10-01 5:02 ` [RFC 15/22] efi_loader: cleanup after efi_disk-dm integration AKASHI Takahiro
2021-10-01 5:02 ` [RFC 16/22] efi_loader: add efi_remove_handle() AKASHI Takahiro
2021-10-01 5:02 ` [RFC 16/22] efi_loader: cleanup after efi_disk-dm integration AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-01 5:02 ` [RFC 17/22] efi_loader: add efi_remove_handle() AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-01 5:02 ` [RFC 17/22] efi_loader: efi_disk: a helper function to delete efi_disk objects AKASHI Takahiro
2021-10-01 5:02 ` [RFC 18/22] dm: blk: call efi's device-removal hook AKASHI Takahiro
2021-10-01 5:02 ` [RFC 18/22] efi_loader: efi_disk: a helper function to delete efi_disk objects AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-01 5:02 ` [RFC 19/22] dm: blk: call efi's device-removal hook AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-01 5:02 ` [RFC 19/22] efi_driver: align with efi_disk-dm integration AKASHI Takahiro
2021-10-01 5:02 ` [RFC 20/22] " AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-11 7:41 ` AKASHI Takahiro
2021-10-01 5:02 ` [RFC 20/22] efi_driver: cleanup after " AKASHI Takahiro
2021-10-01 5:02 ` [RFC 21/22] " AKASHI Takahiro
2021-10-10 14:14 ` Simon Glass
2021-10-01 5:02 ` [RFC 21/22] efi_selftest: block device: adjust dp for a test disk AKASHI Takahiro
2021-10-01 5:02 ` [RFC 22/22] (TEST) let dm-tree unchanged after block_io testing is done AKASHI Takahiro
2021-10-01 5:02 ` [RFC 22/22] efi_selftest: block device: adjust dp for a test disk AKASHI Takahiro
2021-10-02 14:17 ` Heinrich Schuchardt
2021-10-10 14:14 ` [RFC 00/22] efi_loader: more tightly integrate UEFI disks to device model Simon Glass
2021-10-12 15:00 ` Tom Rini
2021-10-12 20:31 ` Simon Glass
2021-10-12 21:13 ` Tom Rini
2021-10-12 23:37 ` Simon Glass
2021-10-12 23:40 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cbf0892-761a-7cfa-b810-d0c1234e5b76@gmx.de \
--to=xypron.glpk@gmx.de \
--cc=agraf@csgraf.de \
--cc=ilias.apalodimas@linaro.org \
--cc=sjg@chromium.org \
--cc=takahiro.akashi@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).