From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16B5DC48BE0 for ; Fri, 11 Jun 2021 13:43:38 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2026C613C3 for ; Fri, 11 Jun 2021 13:43:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2026C613C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D2E6580488; Fri, 11 Jun 2021 15:43:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="xh6YHJE0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0A2A8803B9; Fri, 11 Jun 2021 15:43:33 +0200 (CEST) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D29CB803B9 for ; Fri, 11 Jun 2021 15:43:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=lokeshvutla@ti.com Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 15BDhQjd059753; Fri, 11 Jun 2021 08:43:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1623419006; bh=MYmdBGVulYN2x/htK/0YblehUV4kwCx9PJ5Blm3nvw0=; h=Subject:To:References:From:Date:In-Reply-To; b=xh6YHJE0wjpoRsdvj1xH85ZXXPiPcjuXZdIxSUdI/gWnHo8tYsuuaszU8nH9ax//+ AzPJ6Rukx+oqnijJBOYHInh4PJWXUn+oc2EoYaqRSmpoRmYUKrVglqDzHKnmxvy9xf d+nqAkGryjyNtbcJ+wtpRxGxgvSMr9AeY8Ude/GU= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 15BDhQSr022663 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 11 Jun 2021 08:43:26 -0500 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 11 Jun 2021 08:43:25 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Fri, 11 Jun 2021 08:43:25 -0500 Received: from [10.24.69.20] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 15BDhJFb055662; Fri, 11 Jun 2021 08:43:24 -0500 Subject: Re: [PATCHv6 00/26] HSM rearch series for TI K3 devices To: Tero Kristo , , References: <20210611084527.7048-1-kristo@kernel.org> <2a06a7d2-8101-91e9-3813-ce9d4f327d84@ti.com> <22da4ad1-8a11-50fb-7e97-2caa0ee187dc@kernel.org> From: Lokesh Vutla Message-ID: <4d3f8b0d-0ad1-6d39-65b2-6a0599916667@ti.com> Date: Fri, 11 Jun 2021 19:13:19 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <22da4ad1-8a11-50fb-7e97-2caa0ee187dc@kernel.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Tom, On 11/06/21 4:48 pm, Tero Kristo wrote: > On 11/06/2021 14:08, Lokesh Vutla wrote: >> Hi Tero, >> >> On 11/06/21 2:15 pm, Tero Kristo wrote: >>> Hello, >>> >>> One more post, this time with the #ifdef hackery converted to use the >>> IS_ENABLED / CONFIG_IS_ENABLED macros, and also removed the "common.h" >>> include from k3-clk.h header. This version also contains fixes to any >>> build issues reported by Lokesh, and these are squashed in to relevant >>> patches. >> >> Can you see if the below warnings can be fixed? >> >> hsm/0018-arm-mach-k3-add-support-for-detecting-firmware-image.patch >> ------------------------------------------------------------------- >> WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where >> possible >> #26: FILE: arch/arm/mach-k3/common.c:31: >> +#if IS_ENABLED(CONFIG_SYS_K3_SPL_ATF) > > This is static data, can't be fixed. Unless we want to compile it in always? > >> >> WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where >> possible >> #35: FILE: arch/arm/mach-k3/common.c:40: >> +#if CONFIG_IS_ENABLED(FIT_IMAGE_POST_PROCESS) > > Same, static data. > >> >> WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where >> possible >> #55: FILE: arch/arm/mach-k3/common.c:131: >> +#if IS_ENABLED(CONFIG_SYS_K3_SPL_ATF) > > This is actually just an old macro I changed from #ifdef to IS_ENABLED. Fixing > the whole file from the existing #ifdef:s should be outside the scope of this > series. > >> >> WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where >> possible >> #124: FILE: arch/arm/mach-k3/common.c:264: >> +#if CONFIG_IS_ENABLED(FIT_IMAGE_POST_PROCESS) > > This code addresses the static data defined before, changing this will break > compilation; unless we compile the data always in. > >> >> WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where >> possible >> #128: FILE: arch/arm/mach-k3/common.c:268: >> +#if IS_ENABLED(CONFIG_SYS_K3_SPL_ATF) > > Same as above. > >> WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where >> possible >> #150: FILE: arch/arm/mach-k3/common.c:290: >> +#if IS_ENABLED(CONFIG_TI_SECURE_DEVICE) > > This can't be changed, the code it addresses is only linked in with the config, > causing a linker time failure if this is fixed. > > Imho, I am not too convinced about the checkpatch tool complaining about these > issues. :) > > -Tero > >> >> total: 0 errors, 6 warnings, 0 checks, 144 lines checked >> >> NOTE: For some of the reported defects, checkpatch may be able to >>        mechanically convert to the typical style using --fix or --fix-inplace. >> >> hsm/0018-arm-mach-k3-add-support-for-detecting-firmware-image.patch has style >> problems, please review. >> ------------------------------------------------------------------- >> hsm/0019-arm-mach-k3-do-board-config-for-PM-only-if-supported.patch >> ------------------------------------------------------------------- >> WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where >> possible >> #24: FILE: arch/arm/mach-k3/sysfw-loader.c:162: >> +#if !CONFIG_IS_ENABLED(K3_DM_FW) >> >> total: 0 errors, 1 warnings, 0 checks, 13 lines checked >> >> NOTE: For some of the reported defects, checkpatch may be able to >>        mechanically convert to the typical style using --fix or --fix-inplace. I assume you are okay with this? Thanks and regards, Lokesh >> >> >> Thanks and regards, >> Lokesh >> >