From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5721FC433F5 for ; Thu, 13 Jan 2022 17:03:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4637B83264; Thu, 13 Jan 2022 18:03:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=akkea.ca header.i=@akkea.ca header.b="bh8r9Nnh"; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="syj6wvot"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 31957831CA; Thu, 13 Jan 2022 18:03:32 +0100 (CET) Received: from node.akkea.ca (li1434-30.members.linode.com [45.33.107.30]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 46A14831CA for ; Thu, 13 Jan 2022 18:03:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=angus@akkea.ca Received: from localhost (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id 79B914E2006; Thu, 13 Jan 2022 17:03:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1642093407; bh=CQVt0dqgFU9V/SlxxKe69tPQX87WYVkicuaB68dsXNo=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=bh8r9NnhmIO2GpUNv/JXimmIa4M0KAKDXf2ulYGXEbmrnTCYT5XeDExHnXlW34MA3 AbZQuI5uhkSkKO6HKUh2082ZEHAbqmkQvLFLiM/y4Yvvle078zUQbgXj0GR0h7/CDF PXydSKDPhILoMlW49XAGUWNSQvauX5Fgl8JtC8l4= Received: from node.akkea.ca ([127.0.0.1]) by localhost (mail.akkea.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TMlGPTS0X4LE; Thu, 13 Jan 2022 17:03:26 +0000 (UTC) Received: from www.akkea.ca (li1434-30.members.linode.com [45.33.107.30]) by node.akkea.ca (Postfix) with ESMTPSA id 948164E2003; Thu, 13 Jan 2022 17:03:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1642093406; bh=CQVt0dqgFU9V/SlxxKe69tPQX87WYVkicuaB68dsXNo=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=syj6wvotAuNFfBFm0r06bUW9cni3NTl3+j2BlK02fvNioev8oYMRqB5UjMaLBeTFy pZUwRKfCNOYtHd+UDhiVhvz5LCNqPUz/3j6pVt+RdPH2kNrW4CsetRyDIPJ7yTQtAW 6hpmpXB2dsvwU1u4bW2y+gXC+64JKJXSkdv/CSdg= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 13 Jan 2022 09:03:26 -0800 From: Angus Ainslie To: Jagan Teki Cc: Vignesh R , u-boot@lists.denx.de, kernel@puri.sm Subject: Re: [PATCH] drivers: spi-nor: Add JEDEC id for W25Q16JV In-Reply-To: References: <20211128150907.1443035-1-angus@akkea.ca> Message-ID: <5ad991ea3f7d64c8482e7b3887b12867@akkea.ca> X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.3.6 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Jagan, On 2021-12-01 21:59, Jagan Teki wrote: > On Sun, Nov 28, 2021 at 8:39 PM Angus Ainslie wrote: >> >> Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory >> with >> DUAL/QUAD SPI >> >> Signed-off-by: Angus Ainslie >> --- >> drivers/mtd/spi/spi-nor-ids.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/mtd/spi/spi-nor-ids.c >> b/drivers/mtd/spi/spi-nor-ids.c >> index 3ae7bb1ed7e..f20b21e0d06 100644 >> --- a/drivers/mtd/spi/spi-nor-ids.c >> +++ b/drivers/mtd/spi/spi-nor-ids.c >> @@ -314,6 +314,11 @@ const struct flash_info spi_nor_ids[] = { >> SECT_4K | SPI_NOR_DUAL_READ | >> SPI_NOR_QUAD_READ | >> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) >> }, >> + { >> + INFO("w25q16jv", 0xef7015, 0, 64 * 1024, 32, >> + SECT_4K | SPI_NOR_DUAL_READ | >> SPI_NOR_QUAD_READ | >> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) > > Look like this part is same for im/jm suffix parts. would you update > the name to use that - "w25q16jv-im/jm" > Sorry I missed this email I'll send an update. Angus > Jagan.