From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9BBEC433F5 for ; Fri, 8 Oct 2021 06:20:57 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 246EB60F6E for ; Fri, 8 Oct 2021 06:20:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 246EB60F6E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 671E4835A0; Fri, 8 Oct 2021 08:20:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1633674055; bh=ZtumpQoSdB6XPmlKh1u/oJ0ovsYpRjSOmwlc9SKTgMs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nV538a2VrP0wAKAJp9gsinwtp54jTjDSK3jYHySoCDBDwQlniokfwCGqCLTSABEpM f/fXJeirKRGZDoPiZHEOKaV68ACLVsUyRDjMtoAWuJKScVMks3XFaTURGVlDvpm0XC +Bmy0RF4UWwuE6+cr0BzjVpmpN+i73NkyMIelDR6M9MXHGmBT+AjX7bi/epPNKAeqC 5LLO6GyGB6IYglrT93dMp6EAn+jR167GsD/D2tfKBIveiujcOf/RA8ddZ4mpOG2mFi cMVA/OyxGjHsIbTycDism8gTxzndaBmoo/Hh7WnLrXG/vbeDhSNm0mxPkevHPg+7Z1 peQK+Nwq4yyDA== Received: by phobos.denx.de (Postfix, from userid 109) id 86F38835A4; Fri, 8 Oct 2021 08:20:54 +0200 (CEST) Received: from mout-u-205.mailbox.org (mout-u-205.mailbox.org [IPv6:2001:67c:2050:1::465:205]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AB360834EB for ; Fri, 8 Oct 2021 08:20:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:105:465:1:4:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-205.mailbox.org (Postfix) with ESMTPS id 4HQdNg4QbwzQl54; Fri, 8 Oct 2021 08:20:51 +0200 (CEST) Subject: Re: [PATCH u-boot-marvell v2 1/6] arm: a37xx: pci: Fix pcie_advk_link_up() To: =?UTF-8?Q?Marek_Beh=c3=ban?= Cc: u-boot@lists.denx.de, pali@kernel.org, =?UTF-8?Q?Marek_Beh=c3=ban?= References: <20210925225446.1872-1-kabel@kernel.org> <20210925225446.1872-2-kabel@kernel.org> From: Stefan Roese Message-ID: <5bd3ed43-7a73-8f89-62e8-28aac5375b72@denx.de> Date: Fri, 8 Oct 2021 08:20:47 +0200 MIME-Version: 1.0 In-Reply-To: <20210925225446.1872-2-kabel@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 54D6126A X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 26.09.21 00:54, Marek Behún wrote: > From: Pali Rohár > > Aardvark reports Disabled and Hot Reset LTSSM states as values >= 0x20. > Link is not up in these states, so fix pcie_advk_link_up() function. > > Signed-off-by: Pali Rohár > Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan > --- > drivers/pci/pci-aardvark.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/pci-aardvark.c b/drivers/pci/pci-aardvark.c > index cf6e30f936..741e0431e1 100644 > --- a/drivers/pci/pci-aardvark.c > +++ b/drivers/pci/pci-aardvark.c > @@ -145,6 +145,7 @@ > #define LTSSM_SHIFT 24 > #define LTSSM_MASK 0x3f > #define LTSSM_L0 0x10 > +#define LTSSM_DISABLED 0x20 > #define VENDOR_ID_REG (LMI_BASE_ADDR + 0x44) > > /* PCIe core controller registers */ > @@ -569,7 +570,7 @@ static int pcie_advk_link_up(struct pcie_advk *pcie) > > val = advk_readl(pcie, CFG_REG); > ltssm_state = (val >> LTSSM_SHIFT) & LTSSM_MASK; > - return ltssm_state >= LTSSM_L0; > + return ltssm_state >= LTSSM_L0 && ltssm_state < LTSSM_DISABLED; > } > > /** > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de