From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8675EC433F5 for ; Thu, 7 Oct 2021 19:32:55 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D9F761029 for ; Thu, 7 Oct 2021 19:32:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9D9F761029 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1B25A834C7; Thu, 7 Oct 2021 21:32:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ULOwQF09"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D2B5D834EB; Thu, 7 Oct 2021 21:32:50 +0200 (CEST) Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CC518833F0 for ; Thu, 7 Oct 2021 21:32:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mr.nuke.me@gmail.com Received: by mail-oi1-x235.google.com with SMTP id v10so10429210oic.12 for ; Thu, 07 Oct 2021 12:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YwGGsDVrA4zeXRA8XeQ85XfmMdFbRsbR0aSvmM6D6OU=; b=ULOwQF09fBrf/5fDcn8sCT6BEJkcK0iCBhISVrNPgl67nPS6ZqYDXcCjcuX+a9ycWZ ghZKwnm2p5Fmz/k/PkVBJRyLsOwQt7d116Wj4LnXf6ezFnRFjc7B6I3fgDGiLnJ80nFj mwXoddC+S5ha0lBn49VS0FSAFiAzdqaPhH3ssUNV/6cbFSY/+HpIhutVoOAEUH0GIGBe 7g5TaiK5VvSHJykzuCjZm5EHxh0/wXpRPra4z7fjCLJdik7DOWP6qogqobxAiA0LZD5Y fQuS4/+6wmYa1nPSqfc0KhBRphNBNeUBC8MHGnJqjqWBF2VxRnwEnmsQv+XcpYp6hFFl MteQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YwGGsDVrA4zeXRA8XeQ85XfmMdFbRsbR0aSvmM6D6OU=; b=xLikEXQHlpQbFDTHfdtlLTxasKGqNjBYsWcX+6M+L7VtNaOw2+BpZUSYTCvCxdqJaV /PwTKQWxuiYB27eZxDoKFY3aoUPOTggqqtOk5vJ3TRLY95OH+I6ExLC8Z9xvw46qQxpi xm3ZLscn3EERFn2meS/rRbALUES3xKPEIp0jht2DM2GNnhOr8fGK0HeATX3tNZeFhSJj hLwfmVp1SLbfWspmBQyCt049ho6JREJ8XSMfM1Ef9oKKH7H3hAHLNix0rrTa5zUVmKAu f07pUqma4wtkddgOmdkbCpPYR8fy9ri8Ne0/zV1z4a2ItWIiG2WL3sRw5G6ohnfPLJXG vnQw== X-Gm-Message-State: AOAM531xUe8MkL605cp3dMU3incdOQypXFRh0MectucXr8MfnrCpyZUm WZ07i40jCaGqWmQXBhh1bDU= X-Google-Smtp-Source: ABdhPJyqsnc5mQE6OKxFiUzbWaUUse8zM8wfY+5LuQwTms1BgcH4NVgZondFvur81OrBWbsbulME9A== X-Received: by 2002:aca:b3c3:: with SMTP id c186mr9824494oif.100.1633635165372; Thu, 07 Oct 2021 12:32:45 -0700 (PDT) Received: from nuclearis3.gtech (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id u12sm60962otq.20.2021.10.07.12.32.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Oct 2021 12:32:43 -0700 (PDT) Subject: Re: [PATCH v5 02/29] kconfig: Add tools support to CONFIG_IS_ENABLED() To: Simon Glass , Tom Rini Cc: U-Boot Mailing List , Andre Przywara , Rasmus Villemoes , Robert Marko , Masahiro Yamada , Masahiro Yamada References: <20210926014342.127913-1-sjg@chromium.org> <20210926014342.127913-3-sjg@chromium.org> <20211007002647.GA11424@bill-the-cat> <20211007025226.GQ31748@bill-the-cat> <20211007134209.GS31748@bill-the-cat> <20211007183045.GV31748@bill-the-cat> From: "Alex G." Message-ID: <5cb30240-b726-72be-fa68-05ce174218a3@gmail.com> Date: Thu, 7 Oct 2021 14:32:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 10/7/21 1:50 PM, Simon Glass wrote: > Hi Tom, > > On Thu, 7 Oct 2021 at 12:30, Tom Rini wrote: >> >> On Thu, Oct 07, 2021 at 12:02:24PM -0600, Simon Glass wrote: >>> Hi Tom, >>> >>> On Thu, 7 Oct 2021 at 07:42, Tom Rini wrote: >>>> >>>> On Thu, Oct 07, 2021 at 07:32:04AM -0600, Simon Glass wrote: >>>>> Hi Tom, >>>>> >>>>> On Wed, 6 Oct 2021 at 20:52, Tom Rini wrote: >>>>>> >>>>>> On Wed, Oct 06, 2021 at 08:49:13PM -0600, Simon Glass wrote: >>>>>>> Hi Tom, >>>>>>> >>>>>>> On Wed, 6 Oct 2021 at 18:26, Tom Rini wrote: >>>>>>>> >>>>>>>> On Sat, Sep 25, 2021 at 07:43:15PM -0600, Simon Glass wrote: >>>>>>>> >>>>>>>>> At present we must separately test for the host build for many options, >>>>>>>>> since we force them to be enabled. For example, CONFIG_FIT is always >>>>>>>>> enabled in the host tools, even if CONFIG_FIT is not enabled by the >>>>>>>>> board itself. >>>>>>>>> >>>>>>>>> It would be more convenient if we could use, for example, >>>>>>>>> CONFIG_IS_ENABLED(FIT) and get CONFIG_HOST_FIT, when building for the >>>>>>>>> host. Add support for this. >>>>>>>>> >>>>>>>>> With this and the tools_build() function, we should be able to remove all >>>>>>>>> the #ifdefs currently needed in code that is build by tools and targets. >>>>>>>>> >>>>>>>>> This will be even nicer when we move to using CONFIG(xxx) everywhere, >>>>>>>>> since all the #ifdef and IS_ENABLED/CONFIG_IS_ENABLED stuff will go away. >>>>>>>>> >>>>>>>>> Signed-off-by: Simon Glass >>>>>>>>> Suggested-by: Rasmus Villemoes # b4f73886 >>>>>>>>> Reviewed-by: Alexandru Gagniuc >>>>>>>> >>>>>>>> The problem here is we don't include automatically >>>>>>>> when building host stuff, I believe. This is why doing this breaks >>>>>>>> test_mkimage_hashes for me on am335x_evm with: >>>>>>>> /tmp/.bm-work/am335x_evm/tools/mkimage -D -I dts -O dtb -i /tmp/.bm-work/am335x_evm -f /home/trini/work/u-boot/u-boot/test/py/tests/vboot//hash-images.its /tmp/.bm-work/am335x_evm/test.fit >>>>>>>> *** stack smashing detected ***: terminated >>>>>>> >>>>>>> Oh dear, and no CI coverage. >>>>>>> >>>>>>> I was reluctant to include kconfig.h everywhere but perhaps that is >>>>>>> the best approach. Will take a look ASAP. >>>>>> >>>>>> Maybe we need to think a bit harder too about how we structure >>>>>> intentionally shared code. >>>>>> >>>>>> Why not, for example, for these common algorithms, rely on typical >>>>>> system headers/libraries in the tooling, which means we validated U-Boot >>>>>> vs common reference, rather than just our implementations? >>>>> >>>>> Do you mean we use openssl for sha1, for example? >>>> >>>> I guess, yes. Just flat out saying we require openssl for tools, and >>>> doing our best to not make compatibility with libressl difficult, seems >>>> likely to cause less headaches for people than what we already require >>>> in terms of Python. >>> >>> I'm OK with that, although I do think the problem identified here >>> (CONFIG_SHA256 not enabled) is somewhat sideways from that. We already >> >> OK, I've taken what you posted on IRC and folded that in, continuing >> tests now. >> >>> use separate code paths to run hashing. Perhaps we could make it >>> optional? >>> >>> What about those people that complain about crypto libraries on their systems? >> >> I'm not sure how big a problem that really is, currently. I guess one >> thing would be to make a separate thread on it, and put it in the next >> -rc email as well, for people to explain why it would be a hardship. >> That in turn, I think, is coming down to modern vs very old openssl >> support, rather than having any at all. > > OK I'll take a look at some point. > > Or perhaps Alex might like to? We just got a complain about OpenSSL yesterday [1] Alex [1] https://lists.denx.de/pipermail/u-boot/2021-October/462728.html