From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 801E8ECAAD3 for ; Thu, 1 Sep 2022 12:06:03 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D625B849EE; Thu, 1 Sep 2022 14:06:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id A02F084A15; Thu, 1 Sep 2022 14:05:58 +0200 (CEST) Received: from mail-m11876.qiye.163.com (mail-m11876.qiye.163.com [115.236.118.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AFA67849EE for ; Thu, 1 Sep 2022 14:05:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [172.16.12.93] (unknown [58.22.7.114]) by mail-m11876.qiye.163.com (Hmail) with ESMTPA id 9701C3C030B; Thu, 1 Sep 2022 20:05:42 +0800 (CST) Message-ID: <5cb62b87-122d-42f8-9f05-ff3cc053f815@rock-chips.com> Date: Thu, 1 Sep 2022 20:05:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v5 5/8] rockchip: generate u-boot-rockchip.bin with binman for ARM64 boards Content-Language: en-US To: Quentin Schulz Cc: bharat.gooty@broadcom.com, rayagonda.kokatanur@broadcom.com, sjg@chromium.org, philipp.tomsich@vrull.eu, jagan@amarulasolutions.com, alpernebiyasak@gmail.com, xypron.glpk@gmx.de, heiko.thiery@gmail.com, u-boot@lists.denx.de, Quentin Schulz References: <20220826153634.3086393-1-foss+uboot@0leil.net> <20220826153634.3086393-6-foss+uboot@0leil.net> From: Kever Yang In-Reply-To: <20220826153634.3086393-6-foss+uboot@0leil.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFJSktLSjdXWS1ZQUlXWQ8JGhUIEh9ZQVlDTkgaVklNGkhCTEsfGU8aGVUTARMWGhIXJB QOD1lXWRgSC1lBWU5DVUlJVUxVSkpPWVdZFhoPEhUdFFlBWU9LSFVKSktISkxVSktLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PTI6ATo*Mz0xAUMJKU0DEBMS CzkKChZVSlVKTU1JS0hIQk9ISEhMVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFOS0lDNwY+ X-HM-Tid: 0a82f8f1597b2eb2kusn9701c3c030b X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 2022/8/26 23:36, Quentin Schulz wrote: > From: Quentin Schulz > > This allows to build u-boot-rockchip.bin binary with binman for Rockchip > ARM64 boards instead of the legacy Makefile way. > > Cc: Quentin Schulz > Reviewed-by: Simon Glass > Signed-off-by: Quentin Schulz The Reviewed-by Tag usually should be after the Signed-off-by. Reviewed-by: Kever Yang Thanks, - Kever > --- > > v4: > - added Reviewed-by, > > Makefile | 26 +------------------------- > arch/arm/Kconfig | 2 +- > arch/arm/dts/rockchip-u-boot.dtsi | 5 +++++ > 3 files changed, 7 insertions(+), 26 deletions(-) > > diff --git a/Makefile b/Makefile > index dbe1aa254a..1dee09eb36 100644 > --- a/Makefile > +++ b/Makefile > @@ -1005,8 +1005,7 @@ ifeq ($(CONFIG_ARCH_ROCKCHIP),y) > # On ARM64 this target is produced by binman so we don't need this dep > ifeq ($(CONFIG_ARM64),y) > ifeq ($(CONFIG_SPL),y) > -# TODO: Get binman to generate this too > -INPUTS-y += u-boot-rockchip.bin > +INPUTS-y += u-boot.itb > endif > else > ifeq ($(CONFIG_SPL),y) > @@ -1498,29 +1497,6 @@ OBJCOPYFLAGS_u-boot-with-spl.bin = -I binary -O binary \ > u-boot-with-spl.bin: $(SPL_IMAGE) $(SPL_PAYLOAD) FORCE > $(call if_changed,pad_cat) > > -ifeq ($(CONFIG_ARCH_ROCKCHIP),y) > - > -# TPL + SPL > -ifeq ($(CONFIG_SPL)$(CONFIG_TPL),yy) > -MKIMAGEFLAGS_u-boot-tpl-rockchip.bin = -n $(CONFIG_SYS_SOC) -T rksd > -tpl/u-boot-tpl-rockchip.bin: tpl/u-boot-tpl.bin FORCE > - $(call if_changed,mkimage) > -idbloader.img: tpl/u-boot-tpl-rockchip.bin spl/u-boot-spl.bin FORCE > - $(call if_changed,cat) > -else > -MKIMAGEFLAGS_idbloader.img = -n $(CONFIG_SYS_SOC) -T rksd > -idbloader.img: spl/u-boot-spl.bin FORCE > - $(call if_changed,mkimage) > -endif > - > -ifeq ($(CONFIG_ARM64),y) > -OBJCOPYFLAGS_u-boot-rockchip.bin = -I binary -O binary \ > - --pad-to=$(CONFIG_SPL_PAD_TO) --gap-fill=0xff > -u-boot-rockchip.bin: idbloader.img u-boot.itb FORCE > - $(call if_changed,pad_cat) > -endif # CONFIG_ARM64 > - > -endif # CONFIG_ARCH_ROCKCHIP > > ifeq ($(CONFIG_ARCH_LPC32XX)$(CONFIG_SPL),yy) > MKIMAGEFLAGS_lpc32xx-spl.img = -T lpc32xximage -a $(CONFIG_SPL_TEXT_BASE) > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 0b72e4f650..82cd456f51 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1974,7 +1974,7 @@ config ARCH_STM32MP > config ARCH_ROCKCHIP > bool "Support Rockchip SoCs" > select BLK > - select BINMAN if SPL_OPTEE || (SPL && !ARM64) > + select BINMAN if SPL_OPTEE || SPL > select DM > select DM_GPIO > select DM_I2C > diff --git a/arch/arm/dts/rockchip-u-boot.dtsi b/arch/arm/dts/rockchip-u-boot.dtsi > index ad72ca9700..f90a8bf085 100644 > --- a/arch/arm/dts/rockchip-u-boot.dtsi > +++ b/arch/arm/dts/rockchip-u-boot.dtsi > @@ -30,7 +30,12 @@ > }; > }; > > +#ifdef CONFIG_ARM64 > + blob { > + filename = "u-boot.itb"; > +#else > u-boot-img { > +#endif > offset = ; > }; > };