From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DECE9C07E96 for ; Thu, 15 Jul 2021 06:35:44 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3189D6100A for ; Thu, 15 Jul 2021 06:35:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3189D6100A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B327382005; Thu, 15 Jul 2021 08:35:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="QHs+PDi1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EF03D82916; Thu, 15 Jul 2021 08:35:39 +0200 (CEST) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C121981FA1 for ; Thu, 15 Jul 2021 08:35:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=lokeshvutla@ti.com Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 16F6ZYBV060223; Thu, 15 Jul 2021 01:35:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1626330934; bh=soNPHokq5PSHdVLiAWbNWGe23upHNTDzRmKveQ79XkU=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=QHs+PDi15VwG5a4VHoknzHXZ96uHM1Wb4LD+Ey/hD+AoVKGE5sJkJHn4R2im8LPyq 51N7oIKxlV5xrfoMuVyt0vVKRidfNKYa8WzknB+FdhbiXXGTi3V5qCEvQLMBUS150M TfrlVG2yjH2TI8KcoSQI9dfto8HiQiiWn0WIlRLE= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 16F6ZY2Z021476 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 15 Jul 2021 01:35:34 -0500 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 15 Jul 2021 01:35:33 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Thu, 15 Jul 2021 01:35:33 -0500 Received: from [10.24.69.20] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 16F6ZVo4018033; Thu, 15 Jul 2021 01:35:32 -0500 Subject: Re: [PATCH v3 0/5] Add SIMATIC IOT2050 board support To: Jan Kiszka , U-Boot Mailing List CC: Le Jin , Bao Cheng Su , Nian Gao , Chao Zeng References: From: Lokesh Vutla Message-ID: <5d99f5f4-0ce3-feaa-0b42-564fe067cbde@ti.com> Date: Thu, 15 Jul 2021 12:05:30 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Jan, On 14/07/21 3:09 pm, Jan Kiszka wrote: > On 14.07.21 11:29, Lokesh Vutla wrote: >> Hi Jan, >> >> On 12/06/21 1:12 am, Jan Kiszka wrote: >>> This is the baseline support for the SIMATIC IOT2050 devices. >>> >>> Changes in v3: >>> - rebased >>> - addressed several checkpatch warnings >>> - a few #ifdef -> IS_ENABLED conversions >>> - comment marker for SPDK identifier in .S file >>> - trailing whitespaces >>> - factored out rti_wdt_load_fw (less #ifdef) >> >> I see that there is no conclusion yet for the Watchdog firmware support. But >> that can be split out from this series IMO. Can you repost with basic support so >> that I can merge the series. Watchdog support can be dealt separately. > > I will eventually look again into that loading topic, but I would also > consider that non-critical to merge it this way first and cleanup later > if it actually turns out to be solvable in an equivalent way (result is > part of u-boot proper image) via binman. Even the configuration > interface may stay the same. > > If you still have concerns, skip patch 4 and 5 - though that would > affect an increasing demand of our users for this important feature. First 3 patches of the series throws a build error for me: https://source.denx.de/u-boot/custodians/u-boot-ti/-/jobs/292183 Can you take a look? Thanks and regards, Lokesh > > Jan >