u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: michael@walle.cc
To: Peng Fan <peng.fan@oss.nxp.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH v2 0/5] board: sl28: various updates
Date: Tue, 23 Aug 2022 09:48:38 +0200	[thread overview]
Message-ID: <633a31899b181481fe83b88f627df3fe@walle.cc> (raw)
In-Reply-To: <32e97e56-92c0-d918-d6a5-09b06c75e209@oss.nxp.com>

Hi Peng,

Am 2022-08-23 01:42, schrieb Peng Fan:
> On 7/14/2022 9:05 PM, Michael Walle wrote:
>> This is a resend of the original v1 series. It was just rebased.
>> Apparently not all patches made it into u-boot. Unfortunately,
>> there was no feedback at all.
>> 
>> This is an update for the sl28 board which adds support for
>>   - 8 GiB memory variant
>>   - different boot sources, like eMMC, SD-card
>>   - dynamic prompts
>>   - various cleanups
>> 
>> changes since v1:
>>   - rebased onto the latest master
>> 
>> Michael Walle (5):
>>    armv8: layerscape: spl: mark OCRAM as non-secure
>>    board: sl28: implement additional bootsources
>>    board: sl28: add user friendly names for the boot sources
>>    board: sl28: support dynamic prompts
>>    board: sl28: remove COUNTER_FREQUENCY_REAL
>> 
>>   arch/arm/cpu/armv8/fsl-layerscape/spl.c | 11 +++++
>>   board/kontron/sl28/common.c             | 22 ++++++++++
>>   board/kontron/sl28/sl28.c               | 43 ++++++++++++++++++++
>>   board/kontron/sl28/sl28.h               | 16 ++++++++
>>   board/kontron/sl28/spl.c                | 54 
>> ++++++++++++++++++++++++-
>>   configs/kontron_sl28_defconfig          |  6 ++-
>>   include/configs/kontron_sl28.h          |  2 -
>>   7 files changed, 150 insertions(+), 4 deletions(-)
>>   create mode 100644 board/kontron/sl28/sl28.h
>> 
> Build failure.

Which board has this build failure? I guess it is one of
the layerscape based on an older chassis?

-michael

> +arch/arm/cpu/armv8/fsl-layerscape/spl.c: In function 'tzpc_init':
> +arch/arm/cpu/armv8/fsl-layerscape/spl.c:76:18: error:
> 'TZPCR0SIZE_BASE' undeclared (first use in this function)
> +   76 |         out_le32(TZPCR0SIZE_BASE, 0);
> +      |                  ^~~~~~~~~~~~~~~
> +arch/arm/include/asm/io.h:31:69: note: in definition of macro 
> '__arch_putl'
> +   31 | #define __arch_putl(v,a)                (*(volatile unsigned
> int *)(a) = (v))
> +      |     ^
> +arch/arm/include/asm/io.h:153:41: note: in expansion of macro 
> '__raw_writel'
> +  153 | #define out_arch(type,endian,a,v)
> __raw_write##type(cpu_to_##endian(v),a)
> +      |                                         ^~~~~~~~~~~
> +arch/arm/include/asm/io.h:157:25: note: in expansion of macro 
> 'out_arch'
> +  157 | #define out_le32(a,v)   out_arch(l,le32,a,v)
> +      |                         ^~~~~~~~
> +arch/arm/cpu/armv8/fsl-layerscape/spl.c:76:9: note: in expansion of
> macro 'out_le32'
> +      |         ^~~~~~~~
> +arch/arm/cpu/armv8/fsl-layerscape/spl.c:76:18: note: each undeclared
> identifier is reported only once for each function it appears in
> 
> Please give a look.
> 
> Thanks,
> Peng.

      reply	other threads:[~2022-08-23  7:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-14 13:05 [PATCH v2 0/5] board: sl28: various updates Michael Walle
2022-07-14 13:05 ` [PATCH v2 1/5] armv8: layerscape: spl: mark OCRAM as non-secure Michael Walle
2022-07-14 13:05 ` [PATCH v2 2/5] board: sl28: implement additional bootsources Michael Walle
2022-07-14 13:05 ` [PATCH v2 3/5] board: sl28: add user friendly names for the boot sources Michael Walle
2022-07-14 13:05 ` [PATCH v2 4/5] board: sl28: support dynamic prompts Michael Walle
2022-07-14 13:05 ` [PATCH v2 5/5] board: sl28: remove COUNTER_FREQUENCY_REAL Michael Walle
2022-08-22  8:57 ` [PATCH v2 0/5] board: sl28: various updates Peng Fan
2022-08-22 23:42 ` Peng Fan
2022-08-23  7:48   ` michael [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=633a31899b181481fe83b88f627df3fe@walle.cc \
    --to=michael@walle.cc \
    --cc=peng.fan@oss.nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).