From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CBDDC76196 for ; Mon, 3 Apr 2023 06:48:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1F86385C5F; Mon, 3 Apr 2023 08:48:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="BjyMQYg0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B08CA85C5F; Mon, 3 Apr 2023 08:48:22 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20608.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eab::608]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5F66185C61 for ; Mon, 3 Apr 2023 08:48:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SXW/lkN6RTF0c72vRsXad+3KuckOe1Z0iByx9/AKgDeS4S5Xeq59NoTsoEpRUtdoXiB/6D+8DzowoLMuU0F1EqZl2icCwKK7S/Smk6wW5Zb+0oJm3b5r+4d6D+/LJKqbrIW/uAp4qpz2z9LDO3aJbn6esrl3xRxdbgFu42+Vt2iUwLb6V6aPZ+ETjJQkw24pkT/H+8wB+FMEomYGrxL3Qb2xkKtXiKiUvNOPh8/sqL5iQN8PmkOdZSd0pS9dT7iXTtRzC4XDX7Y80Nw6PnokZFoUIcFHlyEH7UidWy42vI7XUY4MqJIDJ71SYTWY75e+mnXsNlaHi3p/Rm25hscVtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yhf+y+bRQru/WsMgAHYXn+sLkD8Ld0ngBDfYScdrQaM=; b=oJYxGvBFQWMm59U9VcX253ip09+R5kbXf3636qcAAAJ4sVHgFj7tIV5/DJVqlSr0R+HzB3ej7Oi++LNZKSjXmEBEmf9wtMdp3VEmZSD11/j+gFAFkg5d25VJN1vNPCww1JE6QJxebhbVi7DAoDozCeiqYZXQbcL6s64lSKMOQv8BOzCdBoWi2BDR4JdvsH0AXed4LeZXTjebG3It6UI0wI4+5v1Ksnh1IN6mCi8anpYiEWpLn7qGJUopIqHcz+3JCEYFpj6KtVq5pPik5d9CSuYrUQpiB155WbTg2hpEEL1fgKG43ZTwBETfuPFcMjlpvlvfz5tERKblnuOGBueIPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yhf+y+bRQru/WsMgAHYXn+sLkD8Ld0ngBDfYScdrQaM=; b=BjyMQYg0EGPhIxrNESUvg1VXQ0lC7AAULUxi17Szt4D6j/3QshsueQTg+eUGtKlvLkuz2So+3gYMORK4zgFvfWOwJulxjqpvNeDR6G+/S4+StDtLPp2UNpNvYJyDRMQNa1aEHfxLq2macEEXER5ai0rjSLhYvbRa7FB46/WpNXM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BYAPR12MB4758.namprd12.prod.outlook.com (2603:10b6:a03:a5::28) by SA0PR12MB4432.namprd12.prod.outlook.com (2603:10b6:806:98::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 06:48:12 +0000 Received: from BYAPR12MB4758.namprd12.prod.outlook.com ([fe80::4d07:7f52:c833:9603]) by BYAPR12MB4758.namprd12.prod.outlook.com ([fe80::4d07:7f52:c833:9603%6]) with mapi id 15.20.6254.029; Mon, 3 Apr 2023 06:48:12 +0000 Message-ID: <658179fc-c59f-efd1-cfff-5dda13ff8da2@amd.com> Date: Mon, 3 Apr 2023 08:47:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v6 09/11] xilinx: Disable CONFIG_BOOTSTD_DEFAULTS for some xilinx boards To: Simon Glass , Tom Rini Cc: Mark Kettenis , U-Boot Mailing List , Lin Huang , Jeffy Chen , Kever Yang , Philipp Tomsich , Vagrant Cascadian References: <20230402094532.v6.1.Id5a4b4ee7b653591dfb25e75204c17215521164b@changeid> <20230402094532.v6.9.Icff8ccb474b62940b44121eca53b0c4a8bb00866@changeid> <87wn2vb5fk.fsf@bloch.sibelius.xs4all.nl> <20230402144200.GE19998@bill-the-cat> Content-Language: en-US From: Michal Simek In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1PR06CA0213.eurprd06.prod.outlook.com (2603:10a6:802:2c::34) To BYAPR12MB4758.namprd12.prod.outlook.com (2603:10b6:a03:a5::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR12MB4758:EE_|SA0PR12MB4432:EE_ X-MS-Office365-Filtering-Correlation-Id: c5d9b6d4-a53c-44ea-ec27-08db340f6474 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yErzSM970kP1/Fkyzl3eiUj0A44qlZurYrN9TPGTalvG3pa/vyw+WOIYWDpsOJGH6zINAYVEq6evYf4owLxEiEc/MXASIZF/vbhU6FMMjYLHQ1zVrwSm+Kt7569Rw6aSBDUWY0+kpm7XtmS5/aI4HQxbO5K3p8PMPFXAZoZAei76+helJgmxpZnbAbp5fhV2/S4yPpih78uV6Sbh9IqQXvFi+q9Jc4aQNQ5LyQIAW9OJJKywpg0yDPMhimA90zPnXk+M+zV86d48G4eAj6sPRjYHVTGH7J2wPRi0C03KzhUGGMxRKHf+Z7O6hejA+SL6DedOJ2WYauX5xgA6nSXauB9sM5C6GLbsC3qEcBBKGtEXMlHDuVxhr/oiM6WVC8felhRuw3L0mu2sjS9F4eJ+52VUar5yG/O3HIhAkpCgHzj+BgSKOpxVltWcyV7+YyUT/7Iu0T4thsTu+0M/Yb3/f4pH1h8tUd03BxI1XpPR7eNg+ro46IMSPiN9XINEuX5O8ILFiZAD5NZQc2ZqEzX6/mVuvQEQscgE9txgh8rKBzXzIDzblPeV1onWnN+kmjO+7D1amwYwwiL7H15ujqtke8QcImmvLSigRvWCjQ16UG1zpDw3F7W54PqHTa09Vo6Lqx0CKCEM+8xuTQX7vEhAag== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB4758.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(376002)(136003)(396003)(39860400002)(366004)(451199021)(38100700002)(5660300002)(44832011)(83380400001)(2616005)(31696002)(110136005)(54906003)(316002)(6486002)(478600001)(186003)(53546011)(86362001)(6666004)(6512007)(6506007)(26005)(41300700001)(36756003)(4326008)(8676002)(66476007)(66556008)(66946007)(8936002)(31686004)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGE5TzZVd28wcUxzVTYzeHc3T3RwYnFPTUFpYXhycVF6ZTVmMHp2WjRLRWkw?= =?utf-8?B?WmgxYXlPSlJrR2hNREQ2RVpZMEEwNlQ5bURKOW5tWnY1WVZaL3NoTnVEMkFq?= =?utf-8?B?cjZQeHM3MTZHcXRKcVVzdFRKWmorT0JveXZFaU5HOHoxWU1iUjJsaXU0dFFD?= =?utf-8?B?TzRNdUMwdkdqM0ZzYS9Ob2lJZWJCMjdKZERxeFhkZkVkM0F2dTdKbVk3VC81?= =?utf-8?B?OHNWdit6dTBCUFVnaktFRjN6eXQxTW95NlppV0ltMzJYWWNIRkcreHpCNmd2?= =?utf-8?B?dVV3MytnU2tlYzJlQ3pRTHpzSEtWZG8wNWFiQnM3Z2xmVHZHbDZIeFExZ2Jt?= =?utf-8?B?WXhSL3BZenFrTXphQ0xtY0VEays3OFhmUWtUWkQ2WE1yS3hhY050andZaWht?= =?utf-8?B?eGJML1p0STFaV0dmSEdZMjExbWJEa3lTdjZEOXNCVFZOeFhSZEFNYTkrRm16?= =?utf-8?B?N2V6RVdWOHc2S3Z3KzA0Y3YwZkdEYXJkZFJSK0M0R2k0TUZkZHdLQUl5c1dU?= =?utf-8?B?cVMwRUYrYThPamU1am1OVnlkTUdOam5rK29ucUlla2N2VmpURG5POHZmYUE3?= =?utf-8?B?NkpYdUtRc1phWVZrSzcweVJLYm9EOTIyeW1iQ0dESE9pZzdqSWFrREhVWDVS?= =?utf-8?B?bXo5TEUyMEpXdmo1RW1ITDlXT1pNWXBIbWtoWXQrRkFJVW9XcDhRazIwZ2NL?= =?utf-8?B?YlJQOGptWGpGZGJqZDloNkJwWjBuaWVXT3VxWEQ1clROWFBOeEdGeTU5VitI?= =?utf-8?B?aDdQNW9lb3orMGM0M1hGN2k5UVNycHZGWFR5UnVyV3ZuT3FTMzVSVHIvLzk4?= =?utf-8?B?dlJjRXpYdVkvTityelhjWjl4Y2xUZXZ4dkMrTFV1M3ZKTnNnbm9mcFhzSGJB?= =?utf-8?B?NjArMjMzYU1oWHRFcTZEZWcrMitwTHJQZ0tXZ2NHQ0lqcnJZWTR0RE9vUm5o?= =?utf-8?B?RElZMXpNeElxamdBMHFiMkRreGtkQ0YxNFdYYkdVbzFjL0FHcFVXSGVWSGxa?= =?utf-8?B?eUx3d1hIUWtJYXUwcXZUdVpyQVN2eWNvYk5qbG9oOGtMaG5HNGx0S09RaHda?= =?utf-8?B?WWF5dXpHMS9NZ3NFdVVjVzRtQjI5K0R2RXhDSGtYQnVPcmo0NFNUQ1h0U2ov?= =?utf-8?B?bzdCb281RlRhUWpCdEVCRUNaajd4eTlNKzI0bXQ5enFLdFc5cVgzN2kvRTll?= =?utf-8?B?cE16SFdMblc0c0phRVZwVzBFaWp4MnFJc2kyYVhMWG5GYngzSENqYyt1ODJx?= =?utf-8?B?bGNuZTJIN0xlZzVkZlo2czcwVWF5R2JRUlF5R3RxTFp6YWJXbDV5YUtZdVUr?= =?utf-8?B?L2tDUi9YVzkranJiUkh2cldMOGJHWjVlVjlGcHd2VmxDZEZ6YytFQkNBNi84?= =?utf-8?B?U295RDJMNUVYZy9ZL2c5VUFSZGVhcU5LVHZuUllTMnlIUnhCUXp5dE45Zm1o?= =?utf-8?B?RnlYdkFHblROcDR5WEF4cldvYTU3NUwvN2xMT2o1ZnNPV25BT05yZ29RMCsx?= =?utf-8?B?Rk1qUDBNV0plb0pYUkQ5eTREL3dVMHAyR0p3WkdqM1VwcGdIcDkxVHl2SVhw?= =?utf-8?B?RnJ6NFN4T2FUZDJ2UThTWk5iRUVRM3pzVlpqNy9WRkt1SEE5bmlOUEhkSVY1?= =?utf-8?B?dkFPM0x4dWNxNS9PQnR5Mk5Cd3lHblhoL2dCT1g4MXFHeGNBejlzM3AzTlBD?= =?utf-8?B?MDFyditCQ0Q1OHo2RHc5OW5lM1pldk5qZ1d5eXM5NjlLOVlDd0xPakRYc05Q?= =?utf-8?B?L0psY2g0akFWQkhoVFQzRFgxMDhHanRxcHpVSHNRMUNGT0pCNGlUZmtVU0tN?= =?utf-8?B?b1FtSm9nWDArUnVHS0RDUEV6TzZybHp2TjhraGRvR2YvWDNzVHhCbCsxK3Zw?= =?utf-8?B?SGlPWE9rNWxGQjk1T3JIVC94cld4TmhGK0dneTZuYzUxYmZ5bjIrWnlLdnFR?= =?utf-8?B?Q3JhY3c5ZHNZWVczV2NZbEJiMmUyNFVvaFJJTTkrRkRGVXppYTZVb3h1cWtH?= =?utf-8?B?OXpsdHRnOTlqUEhzQmhBM0ZjMnF3bUJTRVE0OFhSWFZ1NkRZakdBVy9qU0d5?= =?utf-8?B?ODZoUjViQ3lXdW1YaUR5TFNDZ0hhVXh3RjNtOVlKMDJmdVJna2NoVTFjSUJG?= =?utf-8?Q?BGgayGxRDF112knpCvjacWTR8?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5d9b6d4-a53c-44ea-ec27-08db340f6474 X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 06:48:12.2015 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: un5zBjYad2nI45ZuB/OTncUK3cd1pZlCmle/uIo030+JwFSgKrew0CU46+44kysQ X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4432 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi, On 4/2/23 21:16, Simon Glass wrote: > Hi Tom, > > On Mon, 3 Apr 2023 at 02:42, Tom Rini wrote: >> >> On Sun, Apr 02, 2023 at 02:41:46PM +1200, Simon Glass wrote: >>> Hi Mark, >>> >>> On Sun, 2 Apr 2023 at 10:31, Mark Kettenis wrote: >>>> >>>>> From: Simon Glass >>>>> Date: Sun, 2 Apr 2023 09:45:33 +1200 >>>>> >>>>> Since CONFIG_BOOTSTD_DEFAULTS now selects ENV_VARS_UBOOT_CONFIG we >>> cannot >>>>> enable it for some Xilinx boards which have a very small environment. >>>>> >>>>> Disable it. >>>> >>>> Does that mean these configs lose distroboot support? That would be a >>>> shame! >>> >>> We use 'select' to enable things, so we don't have the ability to enable >>> just some of the defaults. So unfortunately this board needs to have >>> BOOTSTD_DEFAULTS disabled. >>> >>> It certainly doesn't have anywhere near enough env space for distroboot, >>> although I'm not sure why it is so limited. >> >> Distroboot seems to work historically on this platform, so you need to >> ensure it still works afterwards. These platforms just don't enable the >> "enable all the options" option because they're intentionally limited >> (the "mini" in the name). > > It looks like they set the bootcommand to 'run distro_bootcmd' rather > than enabling DISTRO_DEFAULTS. > > But I just don't understand how it can work. The env size is 0x80 > bytes and it doesn't include the config_distro_bootcmd.h file. > > Mark, maybe I just totally lost, but I just cannot see how this can > work. Please take a look. > > Tom, do you have a board to test with? > > Anyway, as should be clear from my commit message, this is about > BOOTSTD_DEFAULTS so it does not affect DISTRO_DEFAULTS. mini configuration are used for non volatile memories programming. They are only designed for it. They are running out of OCM without any intention to boot any other SW. That's why disabling any configuration related to distro boot is the right way to go. Acked-by: Michal Simek Thanks, Michal