From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0ED26C433FE for ; Mon, 7 Nov 2022 14:32:43 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AC4A58070B; Mon, 7 Nov 2022 15:32:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=theobroma-systems.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=theobroma-systems.com header.i=@theobroma-systems.com header.b="JlMyHpMH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 08DFE806C6; Mon, 7 Nov 2022 15:32:40 +0100 (CET) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2065.outbound.protection.outlook.com [40.107.105.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1F1D3806C6 for ; Mon, 7 Nov 2022 15:32:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=theobroma-systems.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=quentin.schulz@theobroma-systems.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CjlOiuZOIPZMNWULNUAVGfUGS/daZuV7t26Sva3fSs/1qqrgnvc+mnOWQxXkm/IoU9m0xM27E5vjL/ZdooKh7wOeZ5YdH9zfoNd+VJpzO0IlA/vTk/Nc6dhme0NPNoGF59fYW0CnialQc3RdhPg27ErxdK2GYadvfuBzoM2CFnRfDUxisPgrB5D76NKfRccGGSjIyb+/r8NtXmB9aRwNSqL86Wu7yHZS+p/rnH4ZIoppYZJbKZ8b57nAP7KxBOidBNn/T7E74SGtrTFDwjpcgHrqVvvffkO617hRWd94SWFb+OuPUKhB6eVgdE4zpaFVUoXG8qqejIX6K3YfaNtNeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NOqfGfe6BzRzQq5Ui6+ylJIaYCc2PizBgv52yMrqO3g=; b=hK4WFXRxGZhZCGGDcUllPeAxglI3djYGmTiC+ngM/4V/iaDxopHVx40A0CS4evzF2FSg+9OtSsXk5lUz7HQ5bZ89xHpGWZ6ge17dQ1f3acffrM1AmeotAWrbwDXYZa9haklAGQ1fFPrqrr5rAt2p5Ql1XFejp17xwfI9qqwjJzxVDACuA3HeHA1jdCSfXAxq9L3x/tcgki3Flya6j+lIF7ZVVKEGQb23tYt0JXNNUJJP5GiFCh8BzoRDuI/KcnXi1hLRvJ52a6pxOvah54dSCCNbQS5vdQ+WH+Ej6l8OyQ4wOP1JpY/04hq79X1XjFjtFSsK8FtnQ3dFZ3utmxEV1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=theobroma-systems.com; dmarc=pass action=none header.from=theobroma-systems.com; dkim=pass header.d=theobroma-systems.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=theobroma-systems.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NOqfGfe6BzRzQq5Ui6+ylJIaYCc2PizBgv52yMrqO3g=; b=JlMyHpMHoNUInh1G7VHgJIoRV2gf29tpgNr+/PySQ/kz8XlhpBWR0ySOOT+F3tiTKmjNGkWm3d/Qs1kZLCbIrm98dFW93CTkm2bcNXRV6p7W1qyDbgTJQ/hn1sMynZsy9/BMmfChl/reR4DK8+8fzLSpMMWJAaH6kjAvjP/afr7H0M1HdKCSFwCKfs8qpouj39nRS2GcPpSGPKRTlEG8nEpHTyXJ4KlxBrcV9WIMJOHhiS+0OY/50557kQJd/3XGtRA/o6J/9UYnrDzojJv68cKucluhtRzVGNsYcyNCeNHsst1h2zJeNKMT2nWcIpYZeUwvQOs0Bgzr4JT20qWW3w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=theobroma-systems.com; Received: from DU2PR04MB8536.eurprd04.prod.outlook.com (2603:10a6:10:2d7::10) by AM8PR04MB7940.eurprd04.prod.outlook.com (2603:10a6:20b:240::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Mon, 7 Nov 2022 14:32:32 +0000 Received: from DU2PR04MB8536.eurprd04.prod.outlook.com ([fe80::5e5e:1989:e5ec:c833]) by DU2PR04MB8536.eurprd04.prod.outlook.com ([fe80::5e5e:1989:e5ec:c833%3]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 14:32:32 +0000 Message-ID: <67717a66-13d5-a72c-a34c-fac191a238ad@theobroma-systems.com> Date: Mon, 7 Nov 2022 15:32:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v4 3/7] rockchip: Include binman script in 64-bit boards Content-Language: en-US To: Simon Glass , U-Boot Mailing List Cc: Alper Nebi Yasak , Peter Geis , Philippe Reynes , Ivan Mikhaylov , Tom Rini , huang lin , Jeffy Chen , Kever Yang , Jagan Teki , Philipp Tomsich References: <20221106224011.606743-1-sjg@chromium.org> <20221106224011.606743-4-sjg@chromium.org> From: Quentin Schulz In-Reply-To: <20221106224011.606743-4-sjg@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0141.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::12) To DU2PR04MB8536.eurprd04.prod.outlook.com (2603:10a6:10:2d7::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8536:EE_|AM8PR04MB7940:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b4a14cc-a82f-4bd6-0047-08dac0cce7e8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +7o35X8muSDuq8oTVYYIZOC9gqNCxXiPUXD5bALhjmCFUmJG8U9g1i2TYbysCJNcv63Tmt7KlwNWCl1orV2/UEBSEzdlok2pDF7OFx1EsavN9Z16yatRe7ddYsJWrfhUB0cHQ8/rgbXlcw4HuzcmKHwL3l+lf8r2VD+hGWwgL3yYrEGy4/PrErOWGyC1/RSE5ezLpqR43r0kpoEtb43fVjc7UwkJ7NLBnsD+9m+KMFAM4zXdqX++P/zTX4PGTFGjCtHNMg0kMqglALMKduexwGICn5LIzAgbupA4q5i7dMO+WT0humQ/J6pRO9pJbB5dWsMWGnl38sv2IB2WE63Xp2Ht534TwxEi0jrmD0zzCI6Bro45qLCl/YhEdfBe2M27Mhh/mXkNt4WwH4snh8YEUjLVAxKQs5h3xB5XrUee0JmIusudP2r9ux+ihmwZ64GgiZQ8S4+whXH9t/Dy/6Zg9azN7qUHU5+NTNlgyVvQYNz+aHvLl8McUzYy9gY7go0o9U80Hn7qjIxkUgFq15YghFMrGdWO6DMGG7tWtSh4+fi+t58EHnC88p5eYX0KJPBdMfki9enz8VVzb3pB+vGj7j6ggxUf8Y/MiV7kOR4h1Ujj97jBflIxh+U9EmoGAy3IZvE0XeQTYmwVtskRqn9i1VKoz9Ih2O25Upg/ZUDYKKmHEVaF/K5rvm1YuhPmOkML+wirAxQtAiXQEqB9E+GtzQ8Y5xTbqrNKODw047DWX0zjx6w2qiw1AGiO6tHbxQbFTnWwWcjAHSK49pFgkqgV40W5HsyX2U8cQKyEYTwSUCE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8536.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39850400004)(396003)(366004)(136003)(346002)(376002)(451199015)(36756003)(41300700001)(54906003)(110136005)(8936002)(6486002)(7416002)(5660300002)(83380400001)(2906002)(478600001)(44832011)(66946007)(4326008)(8676002)(66476007)(66556008)(316002)(53546011)(26005)(6512007)(2616005)(186003)(38100700002)(31686004)(86362001)(31696002)(6506007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjhjdHR5UlE1VThLazI4YXQxNUhRbzVxZCtIRitVbnEzVkYyVmswczhYLzZL?= =?utf-8?B?aFNBY0cyOGtvRUhmOE1hKzVBbFd2NE94dlk3QWlhaWY3MlBvOUIzdkwvbU12?= =?utf-8?B?T0hOTVh6T2lNVVhWZU0wdFpwRjltajhMV3RMSDhCSHFQY0VvYWQ0RCtoSXBl?= =?utf-8?B?K2pqZkZEdndzZkYyOEN4K20xOG5iZEhYajRkWGthOXY5Q1pKTWhxdkxuaU9j?= =?utf-8?B?MWpTb01mWFg0VGNYeDhFNmp2cWFOUndyNG5VcUV2NU9hY09DU2NXbnVjbTh5?= =?utf-8?B?Rjd0NXRmS1paVHRQTFRwSE1CU1Y4NWw5U0thejhIMXBubzNPRFpHbGgwQWVz?= =?utf-8?B?QktMOHhmeDlPcUU4VnZxUE0xWTBxZkVTcWJBcGhjMlRYbm9tS3AzbWE3Y1hH?= =?utf-8?B?WHlsR1h2YVpkZ2NxL2J2Rzd2VHFyTEJIMHE5Rk5GWitia0hIMmFQNkRBNTN2?= =?utf-8?B?OTJuWmFGWnVGMFE4Q2QvdUVJaVBNTjlvV1ZLYS9ZaUg5QmVLOUpCeTRoUVZn?= =?utf-8?B?VDNYZDIvLzZ3Z3llTUtYakUwR3NrWHI3YmxxUm54eVNHT0UyTVZiNDRxbUxL?= =?utf-8?B?bG1ldStmMXRHVjNmelZqUDg5aTdiaXhCdVJIVUNlNitTNDQ2RDI0RjFMVTlt?= =?utf-8?B?cWd4bm84dXorNlVOakdPNmZXOWJmd1ZNSTBqMVppMDl4cG9JWnBMTnowcEJ6?= =?utf-8?B?OVVLc25XdjluZ3dDOEhzVkFSS0E1UFV1RGNuTVRvTGVsWUMyb1BPa2JoTTFm?= =?utf-8?B?VUtZTWI3K1V2eC94dld0Y2tYME9iWnV2bTI4UzdCbG16WS9JeEI2bzdCSjRo?= =?utf-8?B?ejBvRC9NNko4cWhNTW9RYzRvdGp5WHEwSHdOTllHTWpBMGcvRThSajdTMDJI?= =?utf-8?B?WjMwZzdmd2tocDZISEdMbDJzUDA2VUkyam1kaEVtdXpHY1ZndGJ3cTdEOGRW?= =?utf-8?B?dDhDVm40YXNtdXd6QjBCUXZ2ZERPWmtSdlZVdXc3REx2cjZEdW90TVloQldT?= =?utf-8?B?Z1VEYWVrR3ZDTVpSbks0M3A4Sk5JQkVhVCtuYmJEc2IrSHdnOGlGdktydnpR?= =?utf-8?B?VjRHRUJzN2xhQjRpSzBtSnlWNlRmK3FsNWw0UVdKaWFCR2R3a3RPV2JGMHo4?= =?utf-8?B?SHAwbmI5WkMvdU1FNlB1T1dMOGJSMFdQK2xJaEJMb3Y2enhpcUtsdWQ1R09v?= =?utf-8?B?TEltN00xTSt3STdtVlRUK0lHK0JDQTlvdHRpM0NiMm9KSVl3dHdKRysrMU8y?= =?utf-8?B?YWppMmpnWUZEL0pUTzNENS9LZFFzM29laFFPQno3d21ha0FTdkdzMUJMZnQ3?= =?utf-8?B?bzBjaUF2dFdPNEFjYmVGNkxWUlhTeDN1eUVuL1RkM21zOWpvanNpZStocVhN?= =?utf-8?B?WTRUcmVIRGpENWNPTXJkTXdSMHR4RU5YcXV2TmJlK1BtYmVvTklqVUgySndv?= =?utf-8?B?eDU1SjdQTVY0KzlzMHhUTGtzTHZxMndnRDRZWTlmS0lrN3kvSThUQktRbnZS?= =?utf-8?B?UE5DUXpQZ3ZWY3VUK2NIZ1RZaXQrb1FXUjQ1SldBK3B5OCtlWmFVNkdxTzE1?= =?utf-8?B?OEt6S1o3YjBRbFpqMlgvM1JxVW9SeVVYNnE0ZWhNQ1BQNDRYdW1vMzYra0F0?= =?utf-8?B?UUlaeFZuM3RsZEY2RnEyOURPM3RwcVlMWkRlWGx3eGVFWUJyR3EzUjB0bHF6?= =?utf-8?B?bUcvb0ZZQksvVjRLdkp5RXpGazJnbDJpOG4wa3NOeGR1SS9jaWNMQUF0QjJI?= =?utf-8?B?RnVVUy9iWWlEMzJSbHJuVEVocEtTekQ3RVFSQkE4MC9paEJCR0JNL3crSXlI?= =?utf-8?B?WlREc1R2K0U5TkwzT05uc0RWNHRsdi9NOXVKTHZDK25IUEE0TjdEUWRwS2Js?= =?utf-8?B?cmJudkNkSk1nNGk1RUdIekJxOGdISUpETFJXNzlsaTZaamZRYVJEUWFyTGxl?= =?utf-8?B?ZlczZUxuOTdIOGp4MUJYYlVsRjE2MnlNaXRFcUU3TUtpK2dxZzJITTY0Nlg0?= =?utf-8?B?eHlzYzlmbWxNRzlrRUdLYzE4ODBuUXFHeGE3RnpBaXA5NEdVb214WlpHSkhN?= =?utf-8?B?bGZNQXBGTkNHWEFyY2ZVbHhWOEd3dEZkM3poQVVLQjZyaTRJa2lubkdQQU51?= =?utf-8?B?OGdGWkNBUWswVGFuSHNzeFowdVFsNWdQRm1EcVU2azRpMjhtblMvNzF5M2Fh?= =?utf-8?Q?BBeKXebhexK+8aGuqaX6FaA=3D?= X-OriginatorOrg: theobroma-systems.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b4a14cc-a82f-4bd6-0047-08dac0cce7e8 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8536.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 14:32:32.3730 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kcRQV7A1aV+nuTcx+3gNViEBYm28aUKadq0NQnpShI5RkRAiHV+4hz6DE0t7qR/MlSmyeCMcH1KjH6ulzwXwgLv+PKkVTI8OBeGoDBpJg4FCHnje3rRQLnEhv4tiwvOU X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7940 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On 11/6/22 23:40, Simon Glass wrote: > Include the rockchip-u-boot.dtsi file with 64-bit boards and enable binman > so that these boards can also use it, rather than using special Makefile > rules and scripts. > > This does not change the Makefile nor remove any scripts, but sets it up > so that this is possible. > > Signed-off-by: Simon Glass > Reviewed-by: Alper Nebi Yasak > --- > > (no changes since v1) > > arch/arm/dts/rk3368-u-boot.dtsi | 1 + > arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi | 2 +- > arch/arm/dts/rk3399-u-boot.dtsi | 3 +++ > arch/arm/mach-rockchip/Kconfig | 6 ++++++ > 4 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/dts/rk3368-u-boot.dtsi b/arch/arm/dts/rk3368-u-boot.dtsi > index 811d59ac346..4c0a6ff1561 100644 > --- a/arch/arm/dts/rk3368-u-boot.dtsi > +++ b/arch/arm/dts/rk3368-u-boot.dtsi > @@ -3,6 +3,7 @@ > * Copyright (c) 2020 Theobroma Systems Design und Consulting GmbH > */ > > +#include "rockchip-u-boot.dtsi" > #include > #include "rockchip-u-boot.dtsi" > Already included here^ > diff --git a/arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi b/arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi > index f8335c74a74..1af3bbfb3d3 100644 > --- a/arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi > +++ b/arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi > @@ -46,7 +46,7 @@ > > &binman { > simple-bin { > - blob { > + fit { NACK. It is still blob and not fit until a later patch :) > offset = <((CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR - 64) * 512)>; > }; > }; > diff --git a/arch/arm/dts/rk3399-u-boot.dtsi b/arch/arm/dts/rk3399-u-boot.dtsi > index 3c1a15fe51b..63da02489d3 100644 > --- a/arch/arm/dts/rk3399-u-boot.dtsi > +++ b/arch/arm/dts/rk3399-u-boot.dtsi > @@ -62,6 +62,8 @@ > > #if defined(CONFIG_ROCKCHIP_SPI_IMAGE) && defined(CONFIG_HAS_ROM) > &binman { > + multiple-images; > +#ifdef CONFIG_ROCKCHIP_SPI_IMAGE that's redundant, it's already checked three lines above. > rom { > filename = "u-boot.rom"; > size = <0x400000>; > @@ -81,6 +83,7 @@ > fdtmap { > }; > }; > +#endif /* CONFIG_ROCKCHIP_SPI_IMAGE */ > }; > #endif > > diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig > index 69d51ff3789..90d42650211 100644 > --- a/arch/arm/mach-rockchip/Kconfig > +++ b/arch/arm/mach-rockchip/Kconfig > @@ -15,6 +15,7 @@ config ROCKCHIP_PX30 > select DEBUG_UART_BOARD_INIT > imply ROCKCHIP_COMMON_BOARD > imply SPL_ROCKCHIP_COMMON_BOARD > + imply BINMAN arch/arm/Kconfig has ARCH_ROCKCHIP select BINMAN if SPL_OPTEE || SPL, is this not enough? Cheers, Quentin