From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E818C433EF for ; Tue, 5 Oct 2021 18:36:21 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A81F9613AC for ; Tue, 5 Oct 2021 18:36:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A81F9613AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0FD9482FC5; Tue, 5 Oct 2021 20:36:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="E3u+BIpq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D1B7F8319C; Tue, 5 Oct 2021 20:36:16 +0200 (CEST) Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4CC60820E3 for ; Tue, 5 Oct 2021 20:36:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mr.nuke.me@gmail.com Received: by mail-ot1-x32c.google.com with SMTP id x33-20020a9d37a4000000b0054733a85462so9976otb.10 for ; Tue, 05 Oct 2021 11:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ncIGaVRue7kDLpOmIXBoKV/Dzz7zpg1V+X/czjtc3FI=; b=E3u+BIpqzc7BIbqgoMxKQ1A76v7wMGEsPEftojDwoaS4EDy8fQULCxYpLCl2jpV8/x yhuCTkacTX6SvJC9Q2KvihQ/ncZHFcSMVukVhb4bkLk3mqm+3ldpluTJoO+yBvfzxgg5 fBWhUUGzmUeNQaI7MkH2SRM2uci5oae7QycLtF7m3AYfb8qujbaVfg2PdQ/hA8GVaBAw Lm8jMn6SPsXyy0puGHMLGtd+XoU/jC/WskcQ4WjrxQgG6QIPtFHoOrQ0FKOeFTK+G2Fl BEVeicuVTIbv/k0qI3iDeq62t3oARl08a0x4hlhWAaU5fIykehJjNa2KISL1BcRHtMkR OH0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ncIGaVRue7kDLpOmIXBoKV/Dzz7zpg1V+X/czjtc3FI=; b=P5tLVDAtT5M4+cKRERDu+0VYQDHoPtdUqgAhqNlaI5Cf5P7R75z5XULrWawPQsErqb ATJxTa28BQIpZ58jVDLusaFPDpaWGIC/Iv4EYo/ibf5lPGbRfrIqsdxCx4Ze93jxQs1L wTZZ6os1hZ5rh59qoBWNPNNBvWFNZun6RXwLKD0fHWdKXoL9+W1bEy045TuzkVcKJ/D4 EAdloYI10PZTzD81XrTwaYI8szLxcH7yA+1I6wpY1Ic/CgsyF+mZnQc+C8A77FaMEIkW T8pm+ApOIRb4kr8c01KO/T6l1p2EuK5jh8kQr28Fz2jP99FAn9Cb9gD7Kg0tqyiabCW+ 2hfA== X-Gm-Message-State: AOAM530C8XxANFdqEdKllEgSXt6cDsm7wevDRfqoziZB1sneWf5ZUMt+ plOV5OXdvdNbNx5JlOAb3ebeymQLGrU= X-Google-Smtp-Source: ABdhPJw9+X/qW79egS3UkvHS7jQHKsLZ2ihd1ivwFZhmSadOnTt11OklYcWd1xAiWg+358TGka27vg== X-Received: by 2002:a9d:410f:: with SMTP id o15mr11865600ote.72.1633458972060; Tue, 05 Oct 2021 11:36:12 -0700 (PDT) Received: from nuclearis3.gtech (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id l19sm3679023ota.17.2021.10.05.11.36.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Oct 2021 11:36:11 -0700 (PDT) Subject: Re: [PATCH v5 12/29] image: Drop IMAGE_BOOT_GET_CMDLINE To: Simon Glass , U-Boot Mailing List Cc: Andre Przywara , Rasmus Villemoes , Robert Marko , Masahiro Yamada , Tom Rini , Joe Hershberger , Marek Vasut References: <20210926014342.127913-1-sjg@chromium.org> <20210926014342.127913-6-sjg@chromium.org> From: "Alex G." Message-ID: <71f69a71-e2b4-e7d3-99a1-9d5026406fe4@gmail.com> Date: Tue, 5 Oct 2021 13:36:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210926014342.127913-6-sjg@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 9/25/21 8:43 PM, Simon Glass wrote: > This is not needed with Kconfig, since we can use IS_ENABLED() easily > enough and the board code is now in a separate file. Update the only place > where this is used and drop it. > > Signed-off-by: Simon Glass Reviewed-by: Alexandru Gagniuc > --- > > Changes in v5: > - Update commit message to indicate that the code is in a separate file > > common/image-board.c | 2 +- > include/image.h | 6 ------ > 2 files changed, 1 insertion(+), 7 deletions(-) > > diff --git a/common/image-board.c b/common/image-board.c > index a9a6011ce02..599d6779df5 100644 > --- a/common/image-board.c > +++ b/common/image-board.c > @@ -898,7 +898,7 @@ int image_setup_linux(bootm_headers_t *images) > if (CONFIG_IS_ENABLED(OF_LIBFDT)) > boot_fdt_add_mem_rsv_regions(lmb, *of_flat_tree); > > - if (IMAGE_BOOT_GET_CMDLINE) { > + if (IS_ENABLED(CONFIG_SYS_BOOT_GET_CMDLINE)) { This would return 0 on a tools build, right? > ret = boot_get_cmdline(lmb, &images->cmdline_start, > &images->cmdline_end); > if (ret) { > diff --git a/include/image.h b/include/image.h > index dc872ef5b24..00a80999584 100644 > --- a/include/image.h > +++ b/include/image.h > @@ -49,12 +49,6 @@ struct fdt_region; > #include > #endif /* FIT */ > > -#ifdef CONFIG_SYS_BOOT_GET_CMDLINE > -# define IMAGE_BOOT_GET_CMDLINE 1 > -#else > -# define IMAGE_BOOT_GET_CMDLINE 0 > -#endif > - > #ifdef CONFIG_OF_BOARD_SETUP > # define IMAGE_OF_BOARD_SETUP 1 > #else >