From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77814ECAAD8 for ; Tue, 20 Sep 2022 14:03:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B218884C79; Tue, 20 Sep 2022 16:02:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=theobroma-systems.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=theobroma-systems.com header.i=@theobroma-systems.com header.b="RUh2f32E"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3F54E84C7B; Tue, 20 Sep 2022 16:02:58 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2065.outbound.protection.outlook.com [40.107.22.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 81BDA84C6B for ; Tue, 20 Sep 2022 16:02:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=theobroma-systems.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=quentin.schulz@theobroma-systems.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nm9zxGV9eqo2+aO6tm6txa4Vunjdcxkm1Uc8wez78KBav1rmTpGY2OLDOqN262jblpGfUGZObC1gQuK8+T37e1gpBzSAKK8IvOzMPkTHNxKTEYUwXWdl9q0j9rTGMMzWqEW5eRZbHikR4ktWzeQSnYM+Tg5TN86RYyBUMUN9aJqLlKhWOPIwjtqsWdEBnmQRVRYpoPvpPWFtmlixig+ZAn5A3ufEypNFeFY/O8Qg+PqEvzpYgLTcV9GldGjVCsPa/UIIHYFr0eC2LQp0jTAVJSUVyqv11euGi1LfKBJ4Ad0h0Fg5oahvpYnkFLOUg2xbY842z1z3c3xN+pE8Tn3iBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cp9H+jQyMs8wjgslR6/gFKrlLZ7ODU0YlFZFJe8QhmE=; b=BrJ57KOZm+BtRvPB/NETY3QIwDfDwsVnJY+5RqL4n/X2wMqjCqeWv1J4OO36e3Wc++KMeC5y1AufUVQzY+OOh3bAYyWHIJmKPTsd57GSqZe9ae4qIdHpLsN0s5ADV1T4Obl9a6iBmnGX3TgN2GcIfkq4vE9o8BGTGZaKzSWfKpEJPUABZnONANvUSZ4dbCNYQpcMHP5nqG/wHTtFE4BclD0yzF2Sn5ztLmhAE33NDy13KjwDHpxynT0wadbSFJ0HEAZ2yS9qyO9ops45RmGw4k5v0i7VytgCLTzIXIZJ1bpDDUhJM+g9MNFTshg/khEr0j2W6Y8czoSkJWqOZqHt5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=theobroma-systems.com; dmarc=pass action=none header.from=theobroma-systems.com; dkim=pass header.d=theobroma-systems.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=theobroma-systems.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cp9H+jQyMs8wjgslR6/gFKrlLZ7ODU0YlFZFJe8QhmE=; b=RUh2f32E67yfqkwxgDjZYR8SqxKZaOtqlboAzL+szylGWhBcuzhYGSbkXqe31mTNdKJ60RQg2tXwItpZCoh+IZUVkT6wtxbGIIGsYUk6x7CuO4Il0Mo3mp4KYSzrhlibdTefrwzoIBnru0SkFDUmyDuNKEzIvYALdrwpIRShtUP177AvrvtrdmkxDGRTnz5D3aW+dbUU4kvQU3n77lOt9FijGf0ODGYhtd0BT+pDx3HO+CMz0utTTIL65xeo3l8vCg9Esw7sHo+R4hMeb6bL4XQ2eCN/TZChkCG4uUcWfViM2MTvSXBI7mViKACuqXl6tdyni95eJlIEydKQMKmN+Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=theobroma-systems.com; Received: from DU2PR04MB8536.eurprd04.prod.outlook.com (2603:10a6:10:2d7::10) by AS8PR04MB8136.eurprd04.prod.outlook.com (2603:10a6:20b:3f7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 14:02:53 +0000 Received: from DU2PR04MB8536.eurprd04.prod.outlook.com ([fe80::5e5e:1989:e5ec:c833]) by DU2PR04MB8536.eurprd04.prod.outlook.com ([fe80::5e5e:1989:e5ec:c833%3]) with mapi id 15.20.5632.021; Tue, 20 Sep 2022 14:02:53 +0000 Message-ID: <73ab0f88-9c60-f19b-0698-7552992b6908@theobroma-systems.com> Date: Tue, 20 Sep 2022 16:02:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 07/12] rockchip: puma-rk3399: load environment from same medium as one used to load U-Boot proper Content-Language: en-US To: Kever Yang , patrick.delaunay@foss.st.com, 'Quentin Schulz' Cc: sjg@chromium.org, philipp.tomsich@vrull.eu, klaus.goger@theobroma-systems.com, knaerzche@gmail.com, u-boot@lists.denx.de References: <20220722160655.3904213-1-foss+uboot@0leil.net> <20220722160655.3904213-8-foss+uboot@0leil.net> <252a1ebe-ba21-adca-bdb7-9aff5560db7f@rock-chips.com> <1804479d-02ef-ee05-1d4b-f56eac6a1250@theobroma-systems.com> <873d5eaa-b0ee-ae55-143b-8ddb340b2fbf@rock-chips.com> <4feb827e-3932-c8d6-120e-5465ad92eac2@theobroma-systems.com> <000f01d8c81a$cecb1430$6c613c90$@foss.st.com> <41cccf8a-499e-b700-d3d4-307a13f4ae7b@rock-chips.com> From: Quentin Schulz In-Reply-To: <41cccf8a-499e-b700-d3d4-307a13f4ae7b@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: CWLP123CA0084.GBRP123.PROD.OUTLOOK.COM (2603:10a6:401:5b::24) To DU2PR04MB8536.eurprd04.prod.outlook.com (2603:10a6:10:2d7::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8536:EE_|AS8PR04MB8136:EE_ X-MS-Office365-Filtering-Correlation-Id: eddbc29a-ee70-4b4c-deda-08da9b10cf92 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HyfnNzXuFcmaIjVrmmMJmOVSPtV0yyUpbVnFD7Vl+DPUPfagB893VUdlb3SJCymvY7GSiZT7526gWRPwyknYTGXtqAD4QQroSvFAiM2L3eN/eDt0y3jHhd+7fwbCwGYgfY5+i7RitxCmva3/vGt0eEwJ36XRZCtIK7YwvpBH+07TtWhNiAj9SHzOzmKWdUFlhHrhjwW/nCdMkVcJcW2+7TICMPgxe3nI0n1SCGZ/TNnOaUqXwlJb7HUNNSULJTq2kbnm/05qgRopG3yUHgz9ofF54/nznhCFhIHPTVmQ5FwkbYuXP/gTEuOeWfHu60kQrD20JLhch9mDZJbWMSebWHRJd4zqy4L5A43WD7xxjFInr5vh8qPzoaT6Eo8xuLgwZ6/53+eW6lnpBC0LLSxU5jDbvxio0fA+HcmSMjFegsCtvNMquTBBzgLXdopJcOAqJ+ZQNVTdnnbsT+GtjRi3R32eTYm6kG0+Ep7RwunbxlPQvGO5q9UKpwIxHhkzaNOsUd4DDhzuKhzkKFqTvuDZI19kqXxUDzMVms+vyi3RhmO/8kUBgvVBGokEsJXGYDZuUtOzO73XMeA0ccJelR+5b4vblB8e8n+0PEZh8ZJ4OuNKpcICjK7S6ek0tmy9YLJEn4pyZqvdhUYPVubitzBopnxH1gj7vHNs8+Vn39JBev7G5vBYjb6QTFCXZFaLATl5JE8rWGV9B87sLNO1Gj7/J0caeFeXzOdZJvive/Tt8Nr8NJsd3ZSHjqUeWzSWl+6UQ74jkhPkDkSPJtE4N+JWb1WvZjzsvagMwkD+dDxse8I= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8536.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(366004)(39850400004)(396003)(136003)(346002)(451199015)(38100700002)(2906002)(86362001)(316002)(31696002)(26005)(6512007)(6506007)(53546011)(4326008)(66556008)(66946007)(8676002)(478600001)(41300700001)(66476007)(6486002)(83380400001)(44832011)(110136005)(2616005)(8936002)(186003)(5660300002)(36756003)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azFaU3oxSE1vSzJ2Qzh3ak9aR1FFR0oxRTVPZzd6UHI1QUl3enBRa2tWdGlW?= =?utf-8?B?ald3OXJnVUxMRnYxbTZwK0lPcXRXNlp5dmZEendLK082NDFZenoweDJZSVBE?= =?utf-8?B?RUtCMERxblJpVUNvMVh5VTc2ZzRlbERRM2dVTUlDSG9Xb1FIZFR2a01xbjhx?= =?utf-8?B?YWxteldDL3NWblhLVFlLVkdYZDNpc2FlOG1uK3FGaWUreVlrbGNNVTBuWkRT?= =?utf-8?B?TDBDNkxJdzdhOWl3YzFKazhJc0FCU1FTV294ZWovWVVlVThMSDh3WGJJZWV2?= =?utf-8?B?anlCTUxFQ095STdTb0swOGFVZTJsTnQ0dHFCaFJGMFc5aTNlem5iQldmMG04?= =?utf-8?B?Sk5RQVE3aDAzaU1hV3VDclhzb08xWUJ4Vy9Yd2U0SWV1OWZ4d1g4RWttdVVT?= =?utf-8?B?Zy8xS3dVRVV5eEUzalRIdjZsUWw5RHZKS2ZNQTdIVS9JTEZjVzI5SXdiOHpM?= =?utf-8?B?MmVnZnRvQWpaczJqMGdZME80K2tndTFLZWZ4Q3pLRVVKWUsxUEdDTURzajFM?= =?utf-8?B?Z3B0OVNCdUhZTnZxTjhYTHNkZnY1dGMyYlVodTh1VWNvVGRTREVHVEs4eVR4?= =?utf-8?B?d0VvbEFRR3Nyejh5KytMN3BUZnJVNDdnL00wNTl1T2ZZcWRrM3hCZENUQThp?= =?utf-8?B?UzErcmxvR1l4U0IzRFBLRm9FOGVSZGpKVTlET0Q2czJQRXdUODdJbGw2VWRq?= =?utf-8?B?TEE5MlNickFSVk1tY3FRajNDK2ZNdG5oUDBXMW5wODdYSytmNlNkN1dhQk16?= =?utf-8?B?VnlkVEdFK0txc0xpK2JURUJIS1pXTklYMFFJMFpPMHMrRUNwc29LY3IzOENL?= =?utf-8?B?aTUvamdkem5hWHExcmFNTklITGFTQWdrMThTMTQyeFltbWIvT1dIRlljVm9G?= =?utf-8?B?SE9XTDFqcUN3TnBCUTdRR0liMWhGRlkvS2U4TXVHeXFhMnJWYUdneXpzTWdT?= =?utf-8?B?MEhKSEV3SzdKdFFDWlJlbmVwZzFxdzAyRW9mN2s2S2lHbXZ5Wm9aUC9YblZM?= =?utf-8?B?UVRVSUN0UlBmK25DWGZ4MGxYQzFrTWZLbkh0SExZV21LWWJtUXVYdlU4cGZP?= =?utf-8?B?NGgvbU9VSDI3RjNwQU85S1Y2bkZ4YkQzZkZaL2NFcXJYemdwZU1WTkZOVlVF?= =?utf-8?B?K293Zkl5c2Nla2loV2laWjdHL0VWTCtxeTFyb2VsWlVJVnFueitUYXExem5V?= =?utf-8?B?Y0huTy9NY3VXeUNpcUpxVTNtZU0remNNbVVQWU40SzhFQVA5UEwvZ3pTV0tE?= =?utf-8?B?R3YzY1lLbEIyZEVYUlZUYVlCbjNJUTYvQUxMbWxRSGpnNGU5d1JSY01YT2tS?= =?utf-8?B?VjhIeTI4TFBZdjExa29rYWhjVEZ0WEVCYjVJaHg4bXNkWXpzOERPUnVEQ21V?= =?utf-8?B?dktuZE5TNXlGWm9sbk9aRS83bWwyQ2RVUVpVMlBRR1ZYZ3d6MTc5K1hHMHJ5?= =?utf-8?B?MTlQMUtIMXl1VU9rbEZhRHNFb1VEQVRiaDRWMk5RekREQWx2ZFZTblM3Rjhv?= =?utf-8?B?N3JidHJOSWRUVmthTHEyVUJWNDFnc096czZlOTVka3NjZFg3ZVl5N1hBOThP?= =?utf-8?B?WmFPUU9qc1RONUJzbGNTRkRqYUtlaXhBN2tCK0FmOGxJU3VIRlZ3YW1pK0Uy?= =?utf-8?B?bVJRK0lndFNrNFlKK04vcEJtMXk4QjVPYWQ0VVdqdDk4V1ZzMmVWNXFZWE15?= =?utf-8?B?YVZGa0JtSDM3dHFHZm16VnRGYkVzSktVdkZUTHdsOHQ5NVo3eDNwdHNnTmR2?= =?utf-8?B?VjZ4TVpKWWtIbVlqbTFpSUJmeHRhajhkakdMd3B3Y2hkSjF6Yldxak9aNmtN?= =?utf-8?B?dGRpdnVRMlZlWGt1eTIwVUszOFduMWZJL3V4L1FOc1A0cnd0cGhMQWpTaGg5?= =?utf-8?B?UEJ4L1QyaUsvcnFqWHA2aUdhWjhlVlJ5S2NJOE9wb2EydTFxNWlGM2RpVWd5?= =?utf-8?B?NFpCWG1mVDB3OS9jU0pEY3BVTy9jdng2MHNaY1UxdWFVQlRQZGhKQWZTWGhD?= =?utf-8?B?Ty9KcXlMSk1tSmgxNndUYkJtY0g2VmRWM2RSSnFpZzJmdGRoSy9vNEdrZ1hk?= =?utf-8?B?QUxHdEluVm5JcEZSZjlqQ3kxVm16Q0pOQXNDemtQWnJPeEhXQ2E1MVd1NFdn?= =?utf-8?B?Z1VWcnZDUGxNYkJ1TWlac3RvVXhsV01kWXQzUlRva1NyZ0p3bzRyK1lXWFRi?= =?utf-8?Q?tmt+hQQ7Rhi/jV/3wArVQyw=3D?= X-OriginatorOrg: theobroma-systems.com X-MS-Exchange-CrossTenant-Network-Message-Id: eddbc29a-ee70-4b4c-deda-08da9b10cf92 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8536.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 14:02:53.2199 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l6GpXdGo/IAWFg+QuQrM7UEoNUh+e9cEvDUujEcpAB8NO6xbmVDxFTlZUHQto2M48725f5VIm3nCzW1/igErJkIZ+7Aot5+6CwvLPJvo1kOwKgVElVIDI7lXzHpWcuVR X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8136 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Kever, On 9/20/22 14:28, Kever Yang wrote: > Hi Patrick, Quentin, > > > Here is the definition about the ENV_IS_NOWHERE: > > config ENV_IS_NOWHERE >         bool "Environment is not stored" > help >           Define this if you don't want to or can't have an environment > stored >           on a storage medium. In this case the environemnt will still > exist >           while U-Boot is running, but once U-Boot exits it will not be >           stored. U-Boot will therefore always start up with a default >           environment. > > > Which means ENV_IS_NOWHERE is ALWAYS use default environment, > > but not stored on a storage medium. > > I think what you want is a new ENV_IS_ANYWHERE which not able to > > decide when the firmware is build but must be some where when the boot > > device is decided. > I do not share the same understanding. For me, ENV_IS_NOWHERE means the environment is stored in RAM, once you exit U-Boot or reset the board, it's gone. That's my understanding of the code, I can concede that the help message of the Kconfig option is confusing. It's just another "kind" of environment to me. If the point was to ALWAYS use the default environment, one wouldn't be able to enable the option while other ENV_IS_IN_* are enabled. It is however possible. ENV_IS_ANYWHERE is not a correct name for what I want, because I specifically do NOT want to load from anywhere. I want to load from a specific medium, and if not possible have a fallback to avoid U-Boot cryptically crashing. Maybe we should rename ENV_IS_NOWHERE to ENV_IS_IN_RAM, maybe we could also stop crashing if there's no medium to load the environment from that is available, maybe we could rephrase the help text of the Kconfig option, but this is unrelated to this patch series. Finally, STM32, some i.MX and a couple of Xilinx based boards actually have ENV_IS_NOWHERE enabled at the same time as other ENV_IS_IN_* options, so I'm clearly not the first one to use it this way. Also, see arch/arm/mach-imx/imx8m/soc.c for an implementation of arch_env_get_location that requires ENV_IS_NOWHERE to work and has almost the same logic as I'm trying to implement. I'm trying to fix a non-booting board. This patch series is also only impacting the board I'm maintaining and nothing else. If merging the v2 of this patch series is really asking you something unimaginable, just drop this patch from the series, merge the rest and we'll continue arguing on a resend. Quentin