[PATCH] hush: Fix assignments being misinterpreted as commands

[Wolfgang Denk <wd@denx.de>]

Dear Tom,

In message <20210302133435.GZ10169@bill-the-cat> you wrote:
> 
> > Only the third example is affected by this patch.
>
> OK.  But to what end?  Historically we have a buggy but mostly
> compatible "hush" that acts like "sh" does.  A more flexible shell could
> solve a lot of different use cases including making boot scripts that
> people end up writing being clearer and easier to write/debug/maintain.
> What I worry about here is making our shell not act like any regular
> shell people use.

I am always surprised why people try to add minor fixes (and
sometimes bells and whistles) to ancient versions of the software
without checking recent code first.

The shell in busybox v1.32 shows this behaviour:

	$ foo=bar echo $foo

	$ echo $foo

	$ baz=bar echo qux
	qux
	$

So the specific problem has (long) been fixed in upstream, and
instead of adding a patch to our old version, thus cementing the
broken behaviour, we should upgrade hush to recent upstream code.

Yes, I am aware that this is a lot more effort that this little
patch, but if we could combine the efforts that have already been
wasted over the years for such little fixes here and there wew could
have upgraded long ago.

Grooming a dead horse makes little sense to me.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What is research but a blind date with knowledge?      -- Will Harvey