From: Sean Anderson <seanga2@gmail.com>
To: Weijie Gao <weijie.gao@mediatek.com>, u-boot@lists.denx.de
Cc: GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>,
Lukasz Majewski <lukma@denx.de>
Subject: Re: [PATCH v2 03/14] clk: mtmips: add clock driver for MediaTek MT7621 SoC
Date: Thu, 30 Dec 2021 21:30:36 -0500 [thread overview]
Message-ID: <8ba36ca0-0087-1914-bf1d-9c0c6abacb62@gmail.com> (raw)
In-Reply-To: <e56d02e3bace61bf5de71d3e2989c95b61b1607c.camel@mediatek.com>
On 12/27/21 3:06 AM, Weijie Gao wrote:
> On Wed, 2021-12-15 at 11:11 -0500, Sean Anderson wrote:
>> It is fine to implement only the necessary functionality, but it
>> should
>> be done in a way which is easy to extend in the future, and which
>> won't
>> cause us compatibility problems.
>>
>> Generally, I would like to preserve both source and binary
>> compatibility
>> with Linux where possible. I am not sure whether they are hard
>> requirements, so I made a post regarding that question [1]. For now,
>> addressing my above comments will be fine.
>
> I agreed.
> But now I decide to write a simple driver which provides only the bus
> clock. It seems that I don't have much time for rewrite the full clock
> driver at present.
Well, all you have to do is something like
switch (clk->id) {
case MT7621_CLK_TIMER:
mask = CLKCFG1_TIMER;
break;
/* etc */
}
or use an array if you like that style better.
--Sean
next prev parent reply other threads:[~2021-12-31 2:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 1:35 [PATCH v2 00/14] Add support for MediaTek MT7621 SoC Weijie Gao
2021-11-19 1:35 ` [PATCH v2 01/14] mips: mtmips: add " Weijie Gao
2021-11-19 1:35 ` [PATCH v2 02/14] mips: mtmips: add two reference boards for mt7621 Weijie Gao
2021-11-19 1:35 ` [PATCH v2 03/14] clk: mtmips: add clock driver for MediaTek MT7621 SoC Weijie Gao
2021-11-26 17:44 ` Sean Anderson
2021-12-03 10:06 ` Weijie Gao
2021-12-15 16:11 ` Sean Anderson
2021-12-27 8:06 ` Weijie Gao
2021-12-31 2:30 ` Sean Anderson [this message]
2021-11-19 1:36 ` [PATCH v2 04/14] reset: mtmips: add reset controller support " Weijie Gao
2021-11-19 1:36 ` [PATCH v2 05/14] pinctrl: mtmips: add " Weijie Gao
2021-11-19 1:36 ` [PATCH v2 06/14] nand: raw: " Weijie Gao
2021-11-19 1:36 ` [PATCH v2 07/14] usb: xhci-mtk: " Weijie Gao
2021-11-19 1:36 ` [PATCH v2 08/14] phy: mtk-tphy: " Weijie Gao
2021-11-19 1:36 ` [PATCH v2 09/14] spi: " Weijie Gao
2021-11-19 1:36 ` [PATCH v2 10/14] gpio: " Weijie Gao
2021-11-19 1:36 ` [PATCH v2 11/14] watchdog: " Weijie Gao
2021-11-19 1:37 ` [PATCH v2 12/14] mmc: mediatek: " Weijie Gao
2021-11-22 23:41 ` Jaehoon Chung
2021-11-19 1:37 ` [PATCH v2 13/14] net: " Weijie Gao
2021-11-21 19:14 ` Ramon Fried
2021-11-22 8:09 ` Weijie Gao
2021-11-19 1:37 ` [PATCH v2 14/14] MAINTAINERS: update maintainer for MediaTek MIPS platform Weijie Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ba36ca0-0087-1914-bf1d-9c0c6abacb62@gmail.com \
--to=seanga2@gmail.com \
--cc=GSS_MTK_Uboot_upstream@mediatek.com \
--cc=lukma@denx.de \
--cc=u-boot@lists.denx.de \
--cc=weijie.gao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).