From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4652ECAAD2 for ; Mon, 29 Aug 2022 15:01:30 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A65158458A; Mon, 29 Aug 2022 17:01:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="L3vX+cdo"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 96167845F8; Mon, 29 Aug 2022 17:01:27 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3945C83D01 for ; Mon, 29 Aug 2022 17:01:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1661785269; bh=a2xrAMlAGxzbwOSqNpah4wGPZpU+wsBYivYPmBQMoOc=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=L3vX+cdo+oLJP7Xpj8VOkRTRY+f4dO/kwzK22TnIWBVcuRdpKv6Xi6R3Tys7p4EQd sLX2DZZmpf8g+ZSLUT/XDwZZCX1rlNO2C1y76yUREVRz5pCxCN0flYLdPRQO++ISJ9 HDACucp06Ca0POYuYvGkhcTahUtAH4mKtPbndQBA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.67] ([84.118.157.2]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MTRQq-1opkVt2suK-00Tp95; Mon, 29 Aug 2022 17:01:09 +0200 Message-ID: <8ecf5a5c-39fb-79ce-4d5b-8c24da958751@gmx.de> Date: Mon, 29 Aug 2022 17:01:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH] disk: part: remove dependency to ubifs for spl Content-Language: en-US To: Stefan Herbrechtsmeier Cc: Stefan Herbrechtsmeier , AKASHI Takahiro , Oleksii Bidnichenko , Sean Anderson , Simon Glass , schspa , u-boot@lists.denx.de References: <20220808144517.22967-1-stefan.herbrechtsmeier-oss@weidmueller.com> From: Heinrich Schuchardt In-Reply-To: <20220808144517.22967-1-stefan.herbrechtsmeier-oss@weidmueller.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:8ErenC1mTaiWqxiyMUhQ5Mk0MD/anN9PlELTTcxFBAXYOdlhPZx +P7mVFT/+Yavmwlgs67iH6mTHLrsRkLkhjpWpVojlKUUSOlRtqFPpj8WY3JhMWGBhpYOUL/ oeAVIArgmnfyxhPrq8PmF2bbX/uhNSnFDNOCr5xLIeX3Rqr0D0K4w2sfh0rxQOmd9pWVh0A WGKpZhaPmRJBgxI8Y+aVw== X-UI-Out-Filterresults: notjunk:1;V03:K0:MHR3mxMj9hs=:g0y5BscY6edSLepcnVIDDP dIDE+O4bCRKeKG8pxCFzXVrDQtngjZSCtUCvWNEDsjDiXZNjxAOAYsxzVEfb0uyYqBiqFWqEe pcMwMfZTHBbNiAvEnM+9Z4ePtQps2zhdzCRvO7BEqCr1Ttb8UCdbz+xBoQwgrFUtyMMD5Oxjc 2syXkUAjmba7eC8RVEMWugCUWTbDocjUQP7qPvmfrCk6ipqpHKOJOHQ1K6rUQFyKiTU8H2Qwh Ul81U5JsAM7nR/HuD69XxqZjn7OxijgjnrSd4Yh83w98aaTxzq6WXVSTid/87mQfA+J3TDUK9 eq19Hw55sZiSFaxPVI3l9wkeYs/nItA1GwPSZRRrXrtIc8dxMoWZOh3Hz/9FRi+G+ab0KdLbF +ZBk7khuA1Pm1d/Ef5o3h8jRhtRJIhjtPANFKOP98l98CjkUD2E2FJAA+/No1JkQYZkaoUBEv wvmqZizNf/hWkWqf5atHjOBPDpxGfbQH+oWxX+Sy4rhsdDf6u4NBEfpyu7n06GKemJp5bR963 1dXi8PIzlviVo4tSz0plI1jY7TLz/U07R3LkaChZ+58o9D4WZ2LgXMbTYodf45vJb2gz/3HqM H1mqWe4rUG69oq4fkCv+Ttv386q/yJuRx3QGgNoiXucaFV8SxbOA5WpRr014apg0FDxrovxQh q+ZXYoh2lEAs7GsbvyhPT4lI0oY7j2g8dUmyL9yXmV2xlfM/NmzHixUeEZyE410AxvXYy0qDW cTZr4dZP5uqWPPG49v7003jdykYgTuhcUVQ9AlYuXNAPcjxziGC1FVv2z19pIQy3Xfj3EZs76 KeRSJUPwGG8c8dceogfHHi1+svIfrFSXnpLEOhOghYqA72bc3wX6cCRiGgKh0TSERytSEdElc E46Ffotc/SOrnMxYJ9dZ99D0L/1/Uszjq/tjAw7NbWtYX29FIy6k8nuY5PofBofwgUqBq/Ctk UIF5e2xMmWFyL73FiZoxjUnXlXK0lzm4A+SVWhAqGA3nKCCvthsL00UyKCym8jeIKpxPCxZKU G3tllgBY7vLBhRZMhXu7omxQA10Mt3j00c7vsl32I6J+FcW9CQGL2MVM0MNa4D2WI+1Bxt6j7 Wik+GyuHJm+cd3Q8EJLlfOygf5FcOascliq1pvqNU2o0ZJu3KC6y0bvjw== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 8/8/22 16:45, Stefan Herbrechtsmeier wrote: > From: Stefan Herbrechtsmeier > > The spl doesn't support ubifs and thereby doesn't provide the > ubifs_is_mounted function. Remove the dependency to ubifs for the spl. > > Signed-off-by: Stefan Herbrechtsmeier > > --- > > disk/part.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/disk/part.c b/disk/part.c > index 79955c7fb0..de1b917e84 100644 > --- a/disk/part.c > +++ b/disk/part.c > @@ -479,7 +479,7 @@ int blk_get_device_part_str(const char *ifname, cons= t char *dev_part_str, > } > #endif > > -#ifdef CONFIG_CMD_UBIFS > +#if IS_ENABLED(CONFIG_CMD_UBIFS) && !IS_ENABLED(CONFIG_SPL_BUILD) This configuration seems strange. The support for a file system should not depend on a command. I think a CONFIG_UBIFS is missing. Best regards Heinrich > /* > * Special-case ubi, ubi goes through a mtd, rather than through > * a regular block device.