From mboxrd@z Thu Jan 1 00:00:00 1970 From: Giulio Benetti Date: Sat, 13 Feb 2021 09:47:52 +0100 Subject: [PATCH] clk: fix clk_get_rate() documentation In-Reply-To: References: Message-ID: <923AE82E-B5EF-4247-A439-E3B782CDFCD3@benettiengineering.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, Sean, > Il giorno 13 feb 2021, alle ore 05:17, Simon Glass ha scritto: > > ?On Fri, 12 Feb 2021 at 18:17, Giulio Benetti > wrote: >> >>> On 2/13/21 12:25 AM, Sean Anderson wrote: >>> On 2/10/21 12:37 PM, Giulio Benetti wrote: >>>> clk_get_rate() can't and doesn't return -ve on error, it actually returns 0 >>>> on error or a value greater than 0 on success. So let's fix its >>>> documentation. >>>> >>>> Signed-off-by: Giulio Benetti >>>> --- >>>> include/clk.h | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Simon Glass Sean has already given me a NAK because this function actually return negative values through a ulong return types. I didn?t check into clk-uclass.c and there if get_rate() pointer is not found then it returns a negative value. Since it?s a bit ambiguous I?ve tried to find a different approach but nothing that easy came into my mind. Best regards Giulio Benetti