From: Patrice CHOTARD <patrice.chotard@foss.st.com>
To: Patrick Delaunay <patrick.delaunay@foss.st.com>, <u-boot@lists.denx.de>
Cc: U-Boot STM32 <uboot-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH] board: stm32mp1: remove test on CONFIG_DM_REGULATOR
Date: Thu, 7 Jul 2022 08:51:13 +0200 [thread overview]
Message-ID: <99f655f4-6e7a-c0d5-6b23-4ef26dda8b22@foss.st.com> (raw)
In-Reply-To: <20220620123605.1.If8c377a910cabf108ec14bc570c381126e1531e9@changeid>
Hi Patrick
On 6/20/22 12:36, Patrick Delaunay wrote:
> The tests on CONFIG_DM_REGULATOR, added to avoid compilation issues, can
> now be removed, they are no more needed since the commit 16cc5ad0b439
> ("power: regulator: add dummy helper").
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
>
> board/st/stm32mp1/stm32mp1.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c
> index 9496890d164..8c162b42a59 100644
> --- a/board/st/stm32mp1/stm32mp1.c
> +++ b/board/st/stm32mp1/stm32mp1.c
> @@ -494,7 +494,7 @@ static void sysconf_init(void)
> ret = uclass_get_device_by_driver(UCLASS_PMIC,
> DM_DRIVER_GET(stm32mp_pwr_pmic),
> &pwr_dev);
> - if (!ret && IS_ENABLED(CONFIG_DM_REGULATOR)) {
> + if (!ret) {
> ret = uclass_get_device_by_driver(UCLASS_MISC,
> DM_DRIVER_GET(stm32mp_bsec),
> &dev);
> @@ -555,9 +555,6 @@ static int board_stm32mp15x_dk2_init(void)
> struct gpio_desc hdmi, audio;
> int ret = 0;
>
> - if (!IS_ENABLED(CONFIG_DM_REGULATOR))
> - return -ENODEV;
> -
> /* Fix to make I2C1 usable on DK2 for touchscreen usage in kernel */
> node = ofnode_path("/soc/i2c@40012000/hdmi-transmitter@39");
> if (!ofnode_valid(node)) {
> @@ -658,8 +655,7 @@ int board_init(void)
> if (board_is_stm32mp15x_dk2())
> board_stm32mp15x_dk2_init();
>
> - if (IS_ENABLED(CONFIG_DM_REGULATOR))
> - regulators_enable_boot_on(_DEBUG);
> + regulators_enable_boot_on(_DEBUG);
>
> /*
> * sysconf initialisation done only when U-Boot is running in secure
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
next prev parent reply other threads:[~2022-07-07 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 10:36 [PATCH] board: stm32mp1: remove test on CONFIG_DM_REGULATOR Patrick Delaunay
2022-07-07 6:51 ` Patrice CHOTARD [this message]
2022-09-07 13:30 ` Patrick DELAUNAY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99f655f4-6e7a-c0d5-6b23-4ef26dda8b22@foss.st.com \
--to=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).