From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99F18C6FD1D for ; Fri, 31 Mar 2023 00:00:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9574185858; Fri, 31 Mar 2023 02:00:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=gmx.de header.i=xypron.glpk@gmx.de header.b="nLMTyt3m"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D1CAA85EB6; Fri, 31 Mar 2023 02:00:42 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 860E0857F0 for ; Fri, 31 Mar 2023 02:00:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1680220837; i=xypron.glpk@gmx.de; bh=k+rp/lyYTCkn0OrzbS/vaZ/2Rqo/KXuoH7wspBMBozA=; h=X-UI-Sender-Class:Date:From:To:CC:Subject:In-Reply-To:References; b=nLMTyt3mMCz1hN04qX7P5uBo9jHSnBTOIVgCaOOhi5pF8V2RyJF0+jlDpa3vYj4uZ NHcsE7HbZdJI4ymdsg5FyEIMDG7c1WBbvcLESkNWiIGBsc3FYp+2iIuac4J2a1x4tH 2yoJ3EiIumXHZLptAZimy4sfI7SHtGblvp4NNjgqOqaxxtR9VCe5nfFgwsEla/afGk cptHUOQpJj7ooa6CraeyOvpKG95/MgTTd6vfwxcTnmh0Ve6I5oSV7cgs45dHEK+8QR 8Gm5B67cUHW0zZuetlMe6PUa/IWWqnkWqfvdiy4JdqzbH3N6MU3iYjKM8FB5bfz8v0 2LqrujPNe+QZQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [127.0.0.1] ([88.152.145.137]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MFKGP-1pg6No2XRx-00Fjns; Fri, 31 Mar 2023 02:00:37 +0200 Date: Fri, 31 Mar 2023 02:00:40 +0200 From: Heinrich Schuchardt To: Simon Glass CC: U-Boot Mailing List , Bin Meng , =?ISO-8859-1?Q?Beno=EEt_Th=E9baudeau?= , Ilias Apalodimas Subject: Re: [PATCH 32/38] fs: fat: Shrink the size of a few strings User-Agent: K-9 Mail for Android In-Reply-To: References: <20230330213227.2142353-1-sjg@chromium.org> <20230331103047.32.If2eea014ebc68815d68f373640c80a761a082f83@changeid> <4009FAD0-AC34-49F3-8535-D0686A291640@gmx.de> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:WsiGw+kW7mcIkCg4a42FbE3Q+mFcq9AHfpajYd4eCleM6QFOEP5 xRlXPPWNd1EG6+6e11/QwCg/IGuHK/UuIgPYVIKF0Ot50phGZ8ztL/QHTlu+4FwfqMAiTqb +yKMPBw69nUkNoAYjF27pSgB7yHhhY9hhiy2+UJ5vct53lz0FiZN9T8JfdHl6HbYS2zoolr EQ3iHOObbYXeUsM8sVNBA== UI-OutboundReport: notjunk:1;M01:P0:NePIxytUauI=;2n/Er/r23IJUo2qLRBrcdkcbcxO FjRE56Fz8KBYiDxDGlHekA8gliCjBGSDkGouA8b1GFfFJ7t/XEKaQSEPfH5hqO5CFQZjI9kAt YC1Mf4YOlcmzJ7oQAvUdz6Gvr6+aqbAZgCN8cCRrMdr++ExehCFS8G9Zx5ZYrZCWgIrXuz83G /f9GUp07rCbnkCu8kK0BuMUdMRkbXrcwtJffd6QU2qpM0CyWAOnk57firzy5eNx2HsCE9YIKi IodF+M3OjkZiV3wTLyaQgpW/pouZZKVpFM/2TiidJp4pu5AJ6e/elIKm1nAMU1wAKeVivN5zb jJALQfz7frUjwokmDjIzakqIsaHJqyYTLqhNfJPmy4WVJhFYL1LUYBN9i/abBQ7c9sjZiHzSY QwTfEtBo6Fgd+WE4t3e7wk4MSGRTTtXZuMundJhnFY9k02N9Weko5GU3akRmQeR5nc7NXmv3M bLD40Xp0t4u4zsU6TrcSly6pODWTNispmkCoUMlWeUvsVcRKlOOFWRQ3MV1jLpIFUH3qc9rOG OZh7t5/qrMuovZkpOdAwJCqx5Hh40KJczWgig5EcMIvkR+MKzy4nAlLs21u+HU3d8JZ36RVma mJgnx0nPJkUQw4fzQB7iS8flhf6QxXM2zNesd9MpP0e/GUZAUxpjpWOG6nO9YMprHfCLUSNDK qDfLOcrQZZe/TVty/kGHAn4HfYYk248cPI87U2HIYRbH01RKWoUray3yVOJncj9mAyJ74voN8 Z3L4DKRfrNYMrrGyCrqrc9uKe5noqN2WT5Rd9CBQPML4iTOkjjjnX6Z6bkIvOgOO0As4t9hkt /Xq7zjM0nrtmwNPIp3U8q8XWfFm1HCmgp/zfGecd/0EtSxIuMNcdClURM5zccrY69eZusbTKE us5TjQ66dqGpJzn/h+x+rO6jtt30EjfBWeMjMHQZfSwQEYwBd6gg8Metp83Cv09W3HfE8+Dsh 3wZepC3SRlktVE3pHvApYiMvHDY= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Am 31=2E M=C3=A4rz 2023 01:49:35 MESZ schrieb Simon Glass : >Hi Heinrich, > >On Fri, 31 Mar 2023 at 11:48, Heinrich Schuchardt wrote: >> >> >> >> Am 30=2E M=C3=A4rz 2023 23:32:21 MESZ schrieb Simon Glass : >> >To save a few bytes, replace Error with ** and try to use the same str= ing >> >for multiple messages where possible=2E >> > >> >Signed-off-by: Simon Glass >> >--- >> > >> > fs/fat/fat=2Ec | 12 ++++++------ >> > fs/fat/fat_write=2Ec | 14 ++++---------- >> > 2 files changed, 10 insertions(+), 16 deletions(-) >> > >> >diff --git a/fs/fat/fat=2Ec b/fs/fat/fat=2Ec >> >index 2da93dae3cf3=2E=2Ef0df7988e172 100644 >> >--- a/fs/fat/fat=2Ec >> >+++ b/fs/fat/fat=2Ec >> >@@ -97,8 +97,8 @@ int fat_register_device(struct blk_desc *dev_desc, i= nt part_no) >> > /* Read the partition table, if present */ >> > if (part_get_info(dev_desc, part_no, &info)) { >> > if (part_no !=3D 0) { >> >- printf("** Partition %d not valid on device %d = **\n", >> >- part_no, dev_desc->devnum); >> >+ printf("** Partition %d invalid on device %d **= \n", >> >+ part_no, dev_desc->devnum); >> > return -1; >> > } >> > >> >@@ -168,7 +168,7 @@ static __u32 get_fatent(fsdata *mydata, __u32 entr= y) >> > __u32 ret =3D 0x00; >> > >> > if (CHECK_CLUST(entry, mydata->fatsize)) { >> >- printf("Error: Invalid FAT entry: 0x%08x\n", entry); >> >+ printf("** Invalid FAT entry: %#08x\n", entry); >> >> The ** is superfluous=2E The text makes it clear that an error occured > >So should I drop the other ** strings in these files too? Please take >a look and see what you think=2E I suggest to avoid prefixes like 'Error:' and '**' in all our code if the = message text already indicates an error=2E Best regards Heinrich=20 > >[=2E=2E] > >Regards, >Simon