From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B7FAC433F5 for ; Fri, 22 Oct 2021 10:49:43 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D7D960560 for ; Fri, 22 Oct 2021 10:49:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7D7D960560 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5A30D83409; Fri, 22 Oct 2021 12:49:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="CoZtbpyC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4278B83459; Fri, 22 Oct 2021 12:49:38 +0200 (CEST) Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 68D23833AE for ; Fri, 22 Oct 2021 12:49:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=masahisa.kojima@linaro.org Received: by mail-il1-x12e.google.com with SMTP id 3so1266809ilq.7 for ; Fri, 22 Oct 2021 03:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iVAU3oJCQOpFmFxtHdc5YsLZKw9HvVvBCaVZRcghGhY=; b=CoZtbpyCK2yqyGi5JFfuuk2U2berHaQHo7AbRy9C1n8QenbCy2aLjRVgOND3gIP5cw o0jYgQYQFkS89fgnzGgrQHU9jm2rWvAb1+cG9mZgCdvDsk4gn2eye7AuEaZzYVcUp6mu I1IbbXZ0lDsIeYAxpoeoulyvflxIkZdq0+z0fX81EvnHnmG1SYGOyggWz+z8rC5olsM5 2jEVtn5yGnydn8/4EBvsOk/2pifzbncHYcAwiSMFz6iGq/iJFKE83LzHO2UoJyJNERCF mVe85BAxrHaDXIxLnZ3PLMVyjI+WUDfo29zME/7O+IQYvnB8hhTuXLwlYhqmfRMpTbfx 7dwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iVAU3oJCQOpFmFxtHdc5YsLZKw9HvVvBCaVZRcghGhY=; b=6+jupV850AKCW6nID90j0cOwpzH6KCzF30l4gMQNGRMHAuYDdM98Y1Xs/HNvPBpoiz AWeHlmICYjesAcFHdJNuYqPlgO4M8JWkwjJRas7Xx5JaKP9BU7x1IHO1wdpdG/Gk+ejr jmhJKQe4nYQWe7FTeob1itEdth+tiKPYMN3ObLdlTfWrFsah/VJudx+aQ09z57IKImSG MO4HDHAZnVmjnxoTpsZ5y7XmAYKwWtiabrkUOLJf7RkSwndMxuUtyNJBOF/sRTbp/qgT DQU/L3trrpUOIPdAutQOe+n4DDVto+oS9hcjnYOGHI4bsyCz0PbihkYEk3S/VqprZU6A SWCA== X-Gm-Message-State: AOAM533bylVerL1/K9Z0yPEcHh9RxBzl7i8z+mq3cClHWSE+hQe4ovvM ATXI9FhiGYiUjME8XyshC/tTDg1GMUo2RDtFmB0ouQ== X-Google-Smtp-Source: ABdhPJx190BH3VSg7mxSjQG/oYYu5OhZgbFAfpEe6bYUuu4Orr5qVEg2M8KdtmsswlFYT2ZLO99/hzWqzFmx/FciJmU= X-Received: by 2002:a05:6e02:1525:: with SMTP id i5mr7057052ilu.73.1634899772996; Fri, 22 Oct 2021 03:49:32 -0700 (PDT) MIME-Version: 1.0 References: <20211001111844.7422-1-masahisa.kojima@linaro.org> <20211001111844.7422-3-masahisa.kojima@linaro.org> In-Reply-To: From: Masahisa Kojima Date: Fri, 22 Oct 2021 19:49:21 +0900 Message-ID: Subject: Re: [PATCH v3 2/3] efi_loader: add UEFI GPT measurement To: Simon Glass Cc: U-Boot Mailing List , Heinrich Schuchardt , Ilias Apalodimas , Alexander Graf Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On Sat, 2 Oct 2021 at 00:23, Simon Glass wrote: > > Hi Masahisa, > > On Fri, 1 Oct 2021 at 05:19, Masahisa Kojima wrote: > > > > This commit adds the UEFI GPT disk partition topology > > measurement required in TCG PC Client PFP Spec. > > > > Signed-off-by: Masahisa Kojima > > --- > > > > Changes in v3: > > - EV_EFI_GPT_EVENT is measured before EV_SEPARATOR, same as > > other PCRs > > - use PTR_ARRAY instead of ARRAY > > - create sub-function of allocating io_aligned buffer > > - move search_gpt_dp_node() into efi_device_path.c > > > > include/blk.h | 3 + > > include/efi_loader.h | 3 +- > > include/efi_tcg2.h | 12 +++ > > lib/efi_loader/efi_boottime.c | 2 +- > > lib/efi_loader/efi_device_path.c | 27 +++++ > > lib/efi_loader/efi_tcg2.c | 163 ++++++++++++++++++++++++++++++- > > 6 files changed, 207 insertions(+), 3 deletions(-) > > Please can you go back through your patches and add tests for each one? I will send the selftest patch for the efi_tcg2.c. Thanks, Masahisa Kojima > > Regards, > Simon