Re: [PATCH v7 06/13] FWU: stm32mp1: Add helper functions for accessing FWU metadata

[Sughosh Ganu <sughosh.ganu@linaro.org>]

On Fri, 22 Jul 2022 at 09:09, Jassi Brar <jaswinder.singh@linaro.org> wrote:
>
> On Thu, 14 Jul 2022 at 13:40, Sughosh Ganu <sughosh.ganu@linaro.org> wrote:
> >
> > Add helper functions needed for accessing the FWU metadata which
> > contains information on the updatable images. These functions have
> > been added for the STM32MP157C-DK2 board which has the updatable
> > images on the uSD card, formatted as GPT partitions.
> >
> > Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
> > Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> > ---
> > Changes since V6: None
> >
> >  board/st/stm32mp1/stm32mp1.c | 40 ++++++++++++++++
> >  include/fwu.h                |  3 ++
> >  lib/fwu_updates/Makefile     |  6 +++
> >  lib/fwu_updates/fwu_gpt.c    | 88 ++++++++++++++++++++++++++++++++++++
> >  4 files changed, 137 insertions(+)
> >  create mode 100644 lib/fwu_updates/Makefile
> >  create mode 100644 lib/fwu_updates/fwu_gpt.c
> >
> fwu_gpt is to be used by all platforms that have the gpt-scheme, not just STM.
>
> So do you want to break this patch into two ? One generic that
> introduces the helper functions and another for stm using that api

Ilias has suggested moving the two API functions to common files and
having them defined as weak functions. I will be making this change in
the next version.

>
> Also, you may want to specify GPL-2.0-or-later everywhere.

I thought I had changed that in this version of the patchset, but
unfortunately these two files have not been changed. I will change
this in the next version.

-sughosh