From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15F72C433F5 for ; Sun, 19 Sep 2021 07:32:30 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9D0760F6C for ; Sun, 19 Sep 2021 07:32:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B9D0760F6C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AD96383251; Sun, 19 Sep 2021 09:32:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="KZMvmfDp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 222F18324B; Sun, 19 Sep 2021 09:32:23 +0200 (CEST) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 278DB83248 for ; Sun, 19 Sep 2021 09:32:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bmeng.cn@gmail.com Received: by mail-qk1-x729.google.com with SMTP id i132so3454590qke.1 for ; Sun, 19 Sep 2021 00:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Nwb9b86JRxcYkyIC4LDI5FezEQuAwF1JxQ4M2K2N+dg=; b=KZMvmfDpEup3FbIMH/5ipqvF0jMmIZRkUxR7pzdwSkqVFerfNaHydGvosR9PRwydsC NMKIV9mMNUTbmEC9MrkaVssy3+FPnXP3e+S4JFslu5XD49xpBp12II54Ocx1COKVbtXM Ee0BYsNr3vUVRIpTuezlflI7xJNT+1b/Kgk71pRIpDHVRPNnoCl3qNYT5PsMrDvLdl5Y X+9rUHvZgwWnlyMaDYDtxAoowY2Q/HTnOjyrNaujaDcasYMrmT5/6gGm9GT1rJW+cIR8 tNQKO53ZTu4dlnQkOBznqCWxfTYZUQnhGg1IMQ7OUl95lsFuu1TOmM/Gfb2j4fvbC4nl P4EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Nwb9b86JRxcYkyIC4LDI5FezEQuAwF1JxQ4M2K2N+dg=; b=CjzrEhi62DTG8Y4CMHb+foOFtVvCB4OQUnGC6GIGaKS7VhRx8Bo/eRWRI1Hy6ejD98 SJ5Gxc8cvWQ3XEOF1Gw+dr0KP/ukIs3UeFFqVzTqdjizTZb5sn2lmriG2aD9AU1sXiPb XGT9lccPFsonabLQyLuO7k+UqEWOu9tkEO+Cp2kOxo3pL/gVgYzqp9Fr/XwedhxcDl3y 7wxBz9mEorLlMR+GpRigiPfE9ggfNGpBr6dCTfgacGmllPxF3H4IV37oNK9dSysLPD5G bUNghH/jrKJgULH10zzseXGXy+IjWDX/p/f2fl/2R/c2JM13JvNzeDHkKIJSLnYdNDnh nCRg== X-Gm-Message-State: AOAM532chXFItyhJXzcYilDFTB2Z2R3LetIhvFeTLS7P8qf+xihyuRiX +k8eH6LmZNVMZqkp7IysXkdR8wuF9ocsIEJBG6Q= X-Google-Smtp-Source: ABdhPJynzqgmFk809Ta2I91dd1DNTslsmykcEogA26s4GyGMsAen17WC1CGXyRKHTgQMA+iQxKRJRvhOOWzJBRAqGf8= X-Received: by 2002:a25:ad52:: with SMTP id l18mr23073129ybe.453.1632036738734; Sun, 19 Sep 2021 00:32:18 -0700 (PDT) MIME-Version: 1.0 References: <20210918124655.1086645-1-vladimir.oltean@nxp.com> <20210918124655.1086645-2-vladimir.oltean@nxp.com> In-Reply-To: <20210918124655.1086645-2-vladimir.oltean@nxp.com> From: Bin Meng Date: Sun, 19 Sep 2021 15:32:06 +0800 Message-ID: Subject: Re: [PATCH 1/2] net: tsec: only call tsec_get_interface as fallback to DT-specified PHY mode To: Vladimir Oltean Cc: U-Boot Mailing List , Joe Hershberger , Ramon Fried Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sat, Sep 18, 2021 at 8:47 PM Vladimir Oltean wrote: > > Currently the init_phy function may overwrite the priv->interface > property, since it calls tsec_get_interface which tries to determine it > dynamically based on default register values in ECNTRL. > > Let's do that only if phy-connection-type happens to not be defined in > the device tree. > > Signed-off-by: Vladimir Oltean > --- > drivers/net/tsec.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > Reviewed-by: Bin Meng Tested-by: Bin Meng